From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
"richard@nod.at" <richard@nod.at>,
Mark Brown <broonie@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"cyrille.pitchen@microchip.com" <cyrille.pitchen@microchip.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Cristian.Birsan@microchip.com" <Cristian.Birsan@microchip.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories
Date: Mon, 22 Oct 2018 12:25:16 +0200 [thread overview]
Message-ID: <20181022122516.24ff2dae@bbrezillon> (raw)
In-Reply-To: <VI1PR04MB10383A3C1381532DF0C18F8699F40@VI1PR04MB1038.eurprd04.prod.outlook.com>
On Mon, 22 Oct 2018 10:17:58 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> It works,
Not really.
> [ 1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80
> [ 1.633854] Start [addr_width:00000000, read_dumy:08, read_opcode:00000000]
> [ 1.640811] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
> [ 1.646117] spi_nor_get_map_in_use:2882 smpt[1]=00000004
> [ 1.651421] spi_nor_get_map_in_use:2882 smpt[2]=04ff65fc
> [ 1.656724] spi_nor_get_map_in_use:2882 smpt[3]=00000002
> [ 1.662028] spi_nor_get_map_in_use:2882 smpt[4]=02ff65fd
> [ 1.667331] spi_nor_get_map_in_use:2882 smpt[5]=00000004
> [ 1.672635] spi_nor_get_map_in_use:2882 smpt[6]=ff0201fe
> [ 1.677937] spi_nor_get_map_in_use:2882 smpt[7]=00007ff1
> [ 1.683240] spi_nor_get_map_in_use:2882 smpt[8]=00037ff4
> [ 1.688542] spi_nor_get_map_in_use:2882 smpt[9]=03fbfff4
> [ 1.693845] spi_nor_get_map_in_use:2882 smpt[10]=ff0203fe
> [ 1.699234] spi_nor_get_map_in_use:2882 smpt[11]=03fbfff4
> [ 1.704625] spi_nor_get_map_in_use:2882 smpt[12]=00037ff4
> [ 1.710014] spi_nor_get_map_in_use:2882 smpt[13]=00007ff1
> [ 1.715403] spi_nor_get_map_in_use:2882 smpt[14]=ff0005ff
> [ 1.720791] spi_nor_get_map_in_use:2882 smpt[15]=03fffff4
> [ 1.726180] smpt[0]=[addr_width:00000000, read_dumy:08, read_opcode:00000065]
There's still a problem here: you should see this trace 3 times since
we have 3 command descriptors. And of course, the addr_width and
read_dummy are wrong.
> [ 1.733320] spi_nor_get_map_in_use:2912 map_id=0 smpt_len:16 i=:3
> [ 1.739406] End [addr_width:00000000, read_dumy:08, read_opcode:00000065]
> [ 1.746204] m25p80 spi0.0: s25fl512s (65536 Kbytes)
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@bootlin.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories
Date: Mon, 22 Oct 2018 12:25:16 +0200 [thread overview]
Message-ID: <20181022122516.24ff2dae@bbrezillon> (raw)
In-Reply-To: <VI1PR04MB10383A3C1381532DF0C18F8699F40@VI1PR04MB1038.eurprd04.prod.outlook.com>
On Mon, 22 Oct 2018 10:17:58 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> It works,
Not really.
> [ 1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80
> [ 1.633854] Start [addr_width:00000000, read_dumy:08, read_opcode:00000000]
> [ 1.640811] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc
> [ 1.646117] spi_nor_get_map_in_use:2882 smpt[1]=00000004
> [ 1.651421] spi_nor_get_map_in_use:2882 smpt[2]=04ff65fc
> [ 1.656724] spi_nor_get_map_in_use:2882 smpt[3]=00000002
> [ 1.662028] spi_nor_get_map_in_use:2882 smpt[4]=02ff65fd
> [ 1.667331] spi_nor_get_map_in_use:2882 smpt[5]=00000004
> [ 1.672635] spi_nor_get_map_in_use:2882 smpt[6]=ff0201fe
> [ 1.677937] spi_nor_get_map_in_use:2882 smpt[7]=00007ff1
> [ 1.683240] spi_nor_get_map_in_use:2882 smpt[8]=00037ff4
> [ 1.688542] spi_nor_get_map_in_use:2882 smpt[9]=03fbfff4
> [ 1.693845] spi_nor_get_map_in_use:2882 smpt[10]=ff0203fe
> [ 1.699234] spi_nor_get_map_in_use:2882 smpt[11]=03fbfff4
> [ 1.704625] spi_nor_get_map_in_use:2882 smpt[12]=00037ff4
> [ 1.710014] spi_nor_get_map_in_use:2882 smpt[13]=00007ff1
> [ 1.715403] spi_nor_get_map_in_use:2882 smpt[14]=ff0005ff
> [ 1.720791] spi_nor_get_map_in_use:2882 smpt[15]=03fffff4
> [ 1.726180] smpt[0]=[addr_width:00000000, read_dumy:08, read_opcode:00000065]
There's still a problem here: you should see this trace 3 times since
we have 3 command descriptors. And of course, the addr_width and
read_dummy are wrong.
> [ 1.733320] spi_nor_get_map_in_use:2912 map_id=0 smpt_len:16 i=:3
> [ 1.739406] End [addr_width:00000000, read_dumy:08, read_opcode:00000065]
> [ 1.746204] m25p80 spi0.0: s25fl512s (65536 Kbytes)
next prev parent reply other threads:[~2018-10-22 10:25 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 15:40 [PATCH v3 0/2] add support to non-uniform SFDP SPI NOR flash memories Tudor Ambarus
2018-09-11 15:40 ` Tudor Ambarus
2018-09-11 15:40 ` [PATCH v3 1/2] mtd: spi-nor: " Tudor Ambarus
2018-09-11 15:40 ` Tudor Ambarus
2018-09-11 18:55 ` Marek Vasut
2018-09-11 18:55 ` Marek Vasut
2018-09-17 17:03 ` Tudor Ambarus
2018-09-17 17:03 ` Tudor Ambarus
2018-10-16 9:51 ` Yogesh Narayan Gaur
2018-10-16 9:51 ` Yogesh Narayan Gaur
2018-10-16 12:04 ` Boris Brezillon
2018-10-16 12:04 ` Boris Brezillon
2018-10-16 12:17 ` Boris Brezillon
2018-10-16 12:17 ` Boris Brezillon
2018-10-17 1:54 ` Yogesh Narayan Gaur
2018-10-17 1:54 ` Yogesh Narayan Gaur
2018-10-16 15:14 ` Tudor Ambarus
2018-10-16 15:14 ` Tudor Ambarus
2018-10-16 16:34 ` Cyrille Pitchen
2018-10-16 16:34 ` Cyrille Pitchen
2018-10-17 2:07 ` Yogesh Narayan Gaur
2018-10-17 2:07 ` Yogesh Narayan Gaur
2018-10-17 3:50 ` Yogesh Narayan Gaur
2018-10-17 3:50 ` Yogesh Narayan Gaur
2018-10-17 7:07 ` Boris Brezillon
2018-10-17 7:07 ` Boris Brezillon
2018-10-17 7:10 ` Boris Brezillon
2018-10-17 7:10 ` Boris Brezillon
2018-10-17 7:17 ` Boris Brezillon
2018-10-17 7:17 ` Boris Brezillon
2018-10-17 7:29 ` Boris Brezillon
2018-10-17 7:29 ` Boris Brezillon
2018-10-17 7:46 ` Yogesh Narayan Gaur
2018-10-17 7:46 ` Yogesh Narayan Gaur
2018-10-17 8:00 ` Tudor Ambarus
2018-10-17 8:00 ` Tudor Ambarus
2018-10-17 8:20 ` Yogesh Narayan Gaur
2018-10-17 8:20 ` Yogesh Narayan Gaur
2018-10-17 8:48 ` Boris Brezillon
2018-10-17 8:48 ` Boris Brezillon
2018-10-17 9:52 ` Boris Brezillon
2018-10-17 9:52 ` Boris Brezillon
2018-10-22 6:04 ` Yogesh Narayan Gaur
2018-10-22 6:04 ` Yogesh Narayan Gaur
2018-10-22 7:34 ` Boris Brezillon
2018-10-22 7:34 ` Boris Brezillon
2018-10-22 8:01 ` Boris Brezillon
2018-10-22 8:01 ` Boris Brezillon
2018-10-22 8:32 ` Yogesh Narayan Gaur
2018-10-22 8:32 ` Yogesh Narayan Gaur
2018-10-22 9:09 ` Boris Brezillon
2018-10-22 9:09 ` Boris Brezillon
2018-10-22 8:33 ` Tudor Ambarus
2018-10-22 8:33 ` Tudor Ambarus
2018-10-22 9:15 ` Boris Brezillon
2018-10-22 9:15 ` Boris Brezillon
2018-10-22 10:03 ` Yogesh Narayan Gaur
2018-10-22 10:03 ` Yogesh Narayan Gaur
2018-10-22 10:10 ` Boris Brezillon
2018-10-22 10:10 ` Boris Brezillon
2018-10-22 10:17 ` Yogesh Narayan Gaur
2018-10-22 10:17 ` Yogesh Narayan Gaur
2018-10-22 10:25 ` Boris Brezillon [this message]
2018-10-22 10:25 ` Boris Brezillon
2018-10-22 10:20 ` Boris Brezillon
2018-10-22 10:20 ` Boris Brezillon
2018-10-22 10:26 ` Boris Brezillon
2018-10-22 10:26 ` Boris Brezillon
2018-10-22 10:39 ` Yogesh Narayan Gaur
2018-10-22 10:39 ` Yogesh Narayan Gaur
2018-10-22 10:46 ` Boris Brezillon
2018-10-22 10:46 ` Boris Brezillon
2018-10-22 10:52 ` Boris Brezillon
2018-10-22 10:52 ` Boris Brezillon
2018-10-22 11:03 ` Yogesh Narayan Gaur
2018-10-22 11:03 ` Yogesh Narayan Gaur
2018-10-22 11:43 ` Boris Brezillon
2018-10-22 11:43 ` Boris Brezillon
2018-10-22 11:46 ` Yogesh Narayan Gaur
2018-10-22 11:46 ` Yogesh Narayan Gaur
2018-10-22 11:52 ` Boris Brezillon
2018-10-22 11:52 ` Boris Brezillon
2018-10-23 4:47 ` Yogesh Narayan Gaur
2018-10-23 4:47 ` Yogesh Narayan Gaur
2018-10-23 5:39 ` Boris Brezillon
2018-10-23 5:39 ` Boris Brezillon
2018-10-23 8:18 ` Yogesh Narayan Gaur
2018-10-23 8:18 ` Yogesh Narayan Gaur
2018-10-23 8:48 ` Boris Brezillon
2018-10-23 8:48 ` Boris Brezillon
2018-10-23 8:59 ` Yogesh Narayan Gaur
2018-10-23 8:59 ` Yogesh Narayan Gaur
2018-10-23 9:09 ` Boris Brezillon
2018-10-23 9:09 ` Boris Brezillon
2018-10-23 9:01 ` Boris Brezillon
2018-10-23 9:01 ` Boris Brezillon
2018-10-23 9:05 ` Yogesh Narayan Gaur
2018-10-23 9:05 ` Yogesh Narayan Gaur
2018-10-23 9:10 ` Boris Brezillon
2018-10-23 9:10 ` Boris Brezillon
2018-10-23 9:15 ` Yogesh Narayan Gaur
2018-10-23 9:15 ` Yogesh Narayan Gaur
2018-10-17 9:06 ` Cyrille Pitchen
2018-10-17 9:06 ` Cyrille Pitchen
2018-09-11 15:40 ` [PATCH v3 2/2] mtd: spi-nor: parse SFDP Sector Map Parameter Table Tudor Ambarus
2018-09-11 15:40 ` Tudor Ambarus
2018-09-11 18:56 ` Marek Vasut
2018-09-11 18:56 ` Marek Vasut
2018-09-18 13:09 ` [PATCH v3 0/2] add support to non-uniform SFDP SPI NOR flash memories Boris Brezillon
2018-09-18 13:09 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022122516.24ff2dae@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Cristian.Birsan@microchip.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@microchip.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.