All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Mamta Shukla <mamtashukla555@gmail.com>
Cc: outreachy-kernel@googlegroups.com, airlied@linux.ie,
	daniel.vetter@ffwll.ch, sean@poorly.run,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*
Date: Mon, 22 Oct 2018 21:17:19 +0200	[thread overview]
Message-ID: <20181022191719.GA28324@ravnborg.org> (raw)
In-Reply-To: <20181020174926.GA32333@armorer>

Hi Mamta.

On Sat, Oct 20, 2018 at 11:19:26PM +0530, Mamta Shukla wrote:
> Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate
> drm-formatted specific log messages so that it will be easy to
> differentiate in case of multiple instances of driver.

While touching all these lines we could at the same time get
rid of the trailing "\n", which today is not needed.

But I dunno if this is a change that is welcomed.
Do not jump to do this until someone that knows
the DRM subsystems says OK.

Note: IMO we should only do this because we touch the lines
anyway. Removing '\n' without any other change is not worth
the code crunch.

	Sam


WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Mamta Shukla <mamtashukla555@gmail.com>
Cc: airlied@linux.ie, outreachy-kernel@googlegroups.com,
	sean@poorly.run, dri-devel@lists.freedesktop.org,
	daniel.vetter@ffwll.ch
Subject: Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*
Date: Mon, 22 Oct 2018 21:17:19 +0200	[thread overview]
Message-ID: <20181022191719.GA28324@ravnborg.org> (raw)
In-Reply-To: <20181020174926.GA32333@armorer>

Hi Mamta.

On Sat, Oct 20, 2018 at 11:19:26PM +0530, Mamta Shukla wrote:
> Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate
> drm-formatted specific log messages so that it will be easy to
> differentiate in case of multiple instances of driver.

While touching all these lines we could at the same time get
rid of the trailing "\n", which today is not needed.

But I dunno if this is a change that is welcomed.
Do not jump to do this until someone that knows
the DRM subsystems says OK.

Note: IMO we should only do this because we touch the lines
anyway. Removing '\n' without any other change is not worth
the code crunch.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-10-22 19:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-20 17:49 [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_* Mamta Shukla
2018-10-20 17:49 ` Mamta Shukla
2018-10-22 19:17 ` Sam Ravnborg [this message]
2018-10-22 19:17   ` Sam Ravnborg
2018-10-22 19:22 ` Chris Wilson
2018-10-22 19:22   ` Chris Wilson
2018-10-23 16:41   ` Sean Paul
2018-10-23 16:41     ` Sean Paul
2018-10-23 18:46     ` Rob Clark
2018-10-23 18:46       ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181022191719.GA28324@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mamtashukla555@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.