From: Sean Paul <sean@poorly.run>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mamta Shukla <mamtashukla555@gmail.com>,
outreachy-kernel@googlegroups.com, airlied@linux.ie,
daniel.vetter@ffwll.ch, sean@poorly.run,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*
Date: Tue, 23 Oct 2018 12:41:22 -0400 [thread overview]
Message-ID: <20181023164122.GF154160@art_vandelay> (raw)
In-Reply-To: <154023617749.9962.9645598871319141504@skylake-alporthouse-com>
On Mon, Oct 22, 2018 at 08:22:57PM +0100, Chris Wilson wrote:
> Quoting Mamta Shukla (2018-10-20 18:49:26)
> > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate
> > drm-formatted specific log messages so that it will be easy to
> > differentiate in case of multiple instances of driver.
>
> Do you not think this is a bit backwards? Both dev_* and DRM_DEV_*
> include the device id so that multiple instances can be distinguished.
> What DRM_DEV_* adds is the function name, which for user facing messages
> should not be required given a self-encapsulating informative message.
"given a self-encapsulating informative message." being the key here. I'm not
sure about i915, but most other drivers have vague/duplicated log messages which
rely on the function name for differentiation.
Sean
> -Chris
--
Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: airlied@linux.ie, daniel.vetter@ffwll.ch,
dri-devel@lists.freedesktop.org,
outreachy-kernel@googlegroups.com,
Mamta Shukla <mamtashukla555@gmail.com>,
sean@poorly.run
Subject: Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*
Date: Tue, 23 Oct 2018 12:41:22 -0400 [thread overview]
Message-ID: <20181023164122.GF154160@art_vandelay> (raw)
In-Reply-To: <154023617749.9962.9645598871319141504@skylake-alporthouse-com>
On Mon, Oct 22, 2018 at 08:22:57PM +0100, Chris Wilson wrote:
> Quoting Mamta Shukla (2018-10-20 18:49:26)
> > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate
> > drm-formatted specific log messages so that it will be easy to
> > differentiate in case of multiple instances of driver.
>
> Do you not think this is a bit backwards? Both dev_* and DRM_DEV_*
> include the device id so that multiple instances can be distinguished.
> What DRM_DEV_* adds is the function name, which for user facing messages
> should not be required given a self-encapsulating informative message.
"given a self-encapsulating informative message." being the key here. I'm not
sure about i915, but most other drivers have vague/duplicated log messages which
rely on the function name for differentiation.
Sean
> -Chris
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-23 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 17:49 [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_* Mamta Shukla
2018-10-20 17:49 ` Mamta Shukla
2018-10-22 19:17 ` Sam Ravnborg
2018-10-22 19:17 ` Sam Ravnborg
2018-10-22 19:22 ` Chris Wilson
2018-10-22 19:22 ` Chris Wilson
2018-10-23 16:41 ` Sean Paul [this message]
2018-10-23 16:41 ` Sean Paul
2018-10-23 18:46 ` Rob Clark
2018-10-23 18:46 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023164122.GF154160@art_vandelay \
--to=sean@poorly.run \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=mamtashukla555@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.