* [PATCH] staging: gasket: interrupt: use sizeof(*p) for memory allocation
@ 2018-10-24 4:16 Kimberly Brown
2018-10-24 10:52 ` [Outreachy kernel] " Sasha Levin
2018-10-26 0:04 ` [PATCH v2] staging: gasket: " Kimberly Brown
0 siblings, 2 replies; 4+ messages in thread
From: Kimberly Brown @ 2018-10-24 4:16 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Rob Springer, Todd Poynor, Ben Chan, Greg Kroah-Hartman
Use sizeof(*p) instead of sizeof(struct P) for memory allocation. This
change complies with the Linux kernel coding style. It improves
readability and decreases the opportunity for bugs if the pointer
variable type is changed. Issue found by checkpatch.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
---
drivers/staging/gasket/gasket_interrupt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
index 49d47afad64f..8353ab50b3ec 100644
--- a/drivers/staging/gasket/gasket_interrupt.c
+++ b/drivers/staging/gasket/gasket_interrupt.c
@@ -322,8 +322,7 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev)
const struct gasket_driver_desc *driver_desc =
gasket_get_driver_desc(gasket_dev);
- interrupt_data = kzalloc(sizeof(struct gasket_interrupt_data),
- GFP_KERNEL);
+ interrupt_data = kzalloc(sizeof(*interrupt_data), GFP_KERNEL);
if (!interrupt_data)
return -ENOMEM;
gasket_dev->interrupt_data = interrupt_data;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: gasket: interrupt: use sizeof(*p) for memory allocation
2018-10-24 4:16 [PATCH] staging: gasket: interrupt: use sizeof(*p) for memory allocation Kimberly Brown
@ 2018-10-24 10:52 ` Sasha Levin
2018-10-26 0:04 ` [PATCH v2] staging: gasket: " Kimberly Brown
1 sibling, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2018-10-24 10:52 UTC (permalink / raw)
To: Kimberly Brown
Cc: outreachy-kernel, Rob Springer, Todd Poynor, Ben Chan,
Greg Kroah-Hartman
On Wed, Oct 24, 2018 at 12:16:02AM -0400, Kimberly Brown wrote:
>Use sizeof(*p) instead of sizeof(struct P) for memory allocation. This
>change complies with the Linux kernel coding style. It improves
>readability and decreases the opportunity for bugs if the pointer
>variable type is changed. Issue found by checkpatch.
>
>Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
>---
> drivers/staging/gasket/gasket_interrupt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
>index 49d47afad64f..8353ab50b3ec 100644
>--- a/drivers/staging/gasket/gasket_interrupt.c
>+++ b/drivers/staging/gasket/gasket_interrupt.c
>@@ -322,8 +322,7 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev)
> const struct gasket_driver_desc *driver_desc =
> gasket_get_driver_desc(gasket_dev);
>
>- interrupt_data = kzalloc(sizeof(struct gasket_interrupt_data),
>- GFP_KERNEL);
>+ interrupt_data = kzalloc(sizeof(*interrupt_data), GFP_KERNEL);
> if (!interrupt_data)
> return -ENOMEM;
> gasket_dev->interrupt_data = interrupt_data;
This looks great. Maybe you'd like to do the same for the rest of the
function as well?
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] staging: gasket: use sizeof(*p) for memory allocation
2018-10-24 4:16 [PATCH] staging: gasket: interrupt: use sizeof(*p) for memory allocation Kimberly Brown
2018-10-24 10:52 ` [Outreachy kernel] " Sasha Levin
@ 2018-10-26 0:04 ` Kimberly Brown
2018-10-28 19:32 ` Todd Poynor
1 sibling, 1 reply; 4+ messages in thread
From: Kimberly Brown @ 2018-10-26 0:04 UTC (permalink / raw)
To: outreachy-kernel, Rob Springer, Todd Poynor, Ben Chan,
Greg Kroah-Hartman, Sasha Levin
Use sizeof(*p) instead of sizeof(struct P) for memory allocation. This
change complies with the Linux kernel coding style. It improves
readability and decreases the opportunity for bugs if the pointer
variable type is changed. Issue found by checkpatch.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
---
Changes in v2:
- Changed 4 additional memory allocations to use sizeof(*p).
- Removed 'interrupt:' from the subject line because the
gasket_page_table.c file is now included in this patch.
drivers/staging/gasket/gasket_interrupt.c | 17 ++++++++---------
drivers/staging/gasket/gasket_page_table.c | 3 ++-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
index 49d47afad64f..ad5657d213f0 100644
--- a/drivers/staging/gasket/gasket_interrupt.c
+++ b/drivers/staging/gasket/gasket_interrupt.c
@@ -184,7 +184,7 @@ gasket_interrupt_msix_init(struct gasket_interrupt_data *interrupt_data)
interrupt_data->msix_entries =
kcalloc(interrupt_data->num_interrupts,
- sizeof(struct msix_entry), GFP_KERNEL);
+ sizeof(*interrupt_data->msix_entries), GFP_KERNEL);
if (!interrupt_data->msix_entries)
return -ENOMEM;
@@ -322,8 +322,7 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev)
const struct gasket_driver_desc *driver_desc =
gasket_get_driver_desc(gasket_dev);
- interrupt_data = kzalloc(sizeof(struct gasket_interrupt_data),
- GFP_KERNEL);
+ interrupt_data = kzalloc(sizeof(*interrupt_data), GFP_KERNEL);
if (!interrupt_data)
return -ENOMEM;
gasket_dev->interrupt_data = interrupt_data;
@@ -336,17 +335,17 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev)
interrupt_data->pack_width = driver_desc->interrupt_pack_width;
interrupt_data->num_configured = 0;
- interrupt_data->eventfd_ctxs = kcalloc(driver_desc->num_interrupts,
- sizeof(struct eventfd_ctx *),
- GFP_KERNEL);
+ interrupt_data->eventfd_ctxs =
+ kcalloc(driver_desc->num_interrupts,
+ sizeof(*interrupt_data->eventfd_ctxs), GFP_KERNEL);
if (!interrupt_data->eventfd_ctxs) {
kfree(interrupt_data);
return -ENOMEM;
}
- interrupt_data->interrupt_counts = kcalloc(driver_desc->num_interrupts,
- sizeof(ulong),
- GFP_KERNEL);
+ interrupt_data->interrupt_counts =
+ kcalloc(driver_desc->num_interrupts,
+ sizeof(*interrupt_data->interrupt_counts), GFP_KERNEL);
if (!interrupt_data->interrupt_counts) {
kfree(interrupt_data->eventfd_ctxs);
kfree(interrupt_data);
diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index 5b398b7ba81d..5f4c9b49cb5a 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -1302,7 +1302,8 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
/* allocate the physical memory block */
gasket_dev->page_table[index]->coherent_pages =
- kcalloc(num_pages, sizeof(struct gasket_coherent_page_entry),
+ kcalloc(num_pages,
+ sizeof(*gasket_dev->page_table[index]->coherent_pages),
GFP_KERNEL);
if (!gasket_dev->page_table[index]->coherent_pages)
goto nomem;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: gasket: use sizeof(*p) for memory allocation
2018-10-26 0:04 ` [PATCH v2] staging: gasket: " Kimberly Brown
@ 2018-10-28 19:32 ` Todd Poynor
0 siblings, 0 replies; 4+ messages in thread
From: Todd Poynor @ 2018-10-28 19:32 UTC (permalink / raw)
To: kimbrownkd; +Cc: outreachy-kernel, Rob Springer, benchan, Greg KH, sashal
On Thu, Oct 25, 2018 at 5:04 PM Kimberly Brown <kimbrownkd@gmail.com> wrote:
>
> Use sizeof(*p) instead of sizeof(struct P) for memory allocation. This
> change complies with the Linux kernel coding style. It improves
> readability and decreases the opportunity for bugs if the pointer
> variable type is changed. Issue found by checkpatch.
>
> Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
> ---
> Changes in v2:
> - Changed 4 additional memory allocations to use sizeof(*p).
> - Removed 'interrupt:' from the subject line because the
> gasket_page_table.c file is now included in this patch.
>
> drivers/staging/gasket/gasket_interrupt.c | 17 ++++++++---------
> drivers/staging/gasket/gasket_page_table.c | 3 ++-
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
> index 49d47afad64f..ad5657d213f0 100644
> --- a/drivers/staging/gasket/gasket_interrupt.c
> +++ b/drivers/staging/gasket/gasket_interrupt.c
> @@ -184,7 +184,7 @@ gasket_interrupt_msix_init(struct gasket_interrupt_data *interrupt_data)
>
> interrupt_data->msix_entries =
> kcalloc(interrupt_data->num_interrupts,
> - sizeof(struct msix_entry), GFP_KERNEL);
> + sizeof(*interrupt_data->msix_entries), GFP_KERNEL);
> if (!interrupt_data->msix_entries)
> return -ENOMEM;
>
> @@ -322,8 +322,7 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev)
> const struct gasket_driver_desc *driver_desc =
> gasket_get_driver_desc(gasket_dev);
>
> - interrupt_data = kzalloc(sizeof(struct gasket_interrupt_data),
> - GFP_KERNEL);
> + interrupt_data = kzalloc(sizeof(*interrupt_data), GFP_KERNEL);
> if (!interrupt_data)
> return -ENOMEM;
> gasket_dev->interrupt_data = interrupt_data;
> @@ -336,17 +335,17 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev)
> interrupt_data->pack_width = driver_desc->interrupt_pack_width;
> interrupt_data->num_configured = 0;
>
> - interrupt_data->eventfd_ctxs = kcalloc(driver_desc->num_interrupts,
> - sizeof(struct eventfd_ctx *),
> - GFP_KERNEL);
> + interrupt_data->eventfd_ctxs =
> + kcalloc(driver_desc->num_interrupts,
> + sizeof(*interrupt_data->eventfd_ctxs), GFP_KERNEL);
> if (!interrupt_data->eventfd_ctxs) {
> kfree(interrupt_data);
> return -ENOMEM;
> }
>
> - interrupt_data->interrupt_counts = kcalloc(driver_desc->num_interrupts,
> - sizeof(ulong),
> - GFP_KERNEL);
> + interrupt_data->interrupt_counts =
> + kcalloc(driver_desc->num_interrupts,
> + sizeof(*interrupt_data->interrupt_counts), GFP_KERNEL);
> if (!interrupt_data->interrupt_counts) {
> kfree(interrupt_data->eventfd_ctxs);
> kfree(interrupt_data);
> diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
> index 5b398b7ba81d..5f4c9b49cb5a 100644
> --- a/drivers/staging/gasket/gasket_page_table.c
> +++ b/drivers/staging/gasket/gasket_page_table.c
> @@ -1302,7 +1302,8 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
>
> /* allocate the physical memory block */
> gasket_dev->page_table[index]->coherent_pages =
> - kcalloc(num_pages, sizeof(struct gasket_coherent_page_entry),
> + kcalloc(num_pages,
> + sizeof(*gasket_dev->page_table[index]->coherent_pages),
> GFP_KERNEL);
> if (!gasket_dev->page_table[index]->coherent_pages)
> goto nomem;
> --
> 2.17.1
Acked-by: Todd Poynor <toddpoynor@google.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-28 19:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-24 4:16 [PATCH] staging: gasket: interrupt: use sizeof(*p) for memory allocation Kimberly Brown
2018-10-24 10:52 ` [Outreachy kernel] " Sasha Levin
2018-10-26 0:04 ` [PATCH v2] staging: gasket: " Kimberly Brown
2018-10-28 19:32 ` Todd Poynor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.