* [PATCH] staging: greybus: remove unmatched right bracket @ 2018-11-04 2:02 Ioannis Valasakis 2018-11-04 6:27 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 5+ messages in thread From: Ioannis Valasakis @ 2018-11-04 2:02 UTC (permalink / raw) To: outreachy-kernel; +Cc: gregkh Remove unmatched right bracket. Reported by uncrustify. Signed-off-by: Ioannis Valasakis <code@wizofe.uk> --- drivers/staging/greybus/camera.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index 6dded10f4155..c6d65430ea4c 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam) debugfs_create_file(entry->name, entry->mask, gcam->debugfs.root, gcam, &gb_camera_debugfs_ops); - } } return 0; -- 2.19.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: greybus: remove unmatched right bracket 2018-11-04 2:02 [PATCH] staging: greybus: remove unmatched right bracket Ioannis Valasakis @ 2018-11-04 6:27 ` Julia Lawall 2018-11-04 12:01 ` Ioannis Valasakis 0 siblings, 1 reply; 5+ messages in thread From: Julia Lawall @ 2018-11-04 6:27 UTC (permalink / raw) To: Ioannis Valasakis; +Cc: outreachy-kernel, gregkh On Sun, 4 Nov 2018, Ioannis Valasakis wrote: > Remove unmatched right bracket. > Reported by uncrustify. > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk> Acked-by: Julia Lawall <julia.lawall@lip6.fr> I wondered how such a problem could go unnoticed, but this file seems to have a lot of other compilation problems that could perhaps also be fixed up. julia > --- > drivers/staging/greybus/camera.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > index 6dded10f4155..c6d65430ea4c 100644 > --- a/drivers/staging/greybus/camera.c > +++ b/drivers/staging/greybus/camera.c > @@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam) > debugfs_create_file(entry->name, entry->mask, > gcam->debugfs.root, gcam, > &gb_camera_debugfs_ops); > - } > } > > return 0; > -- > 2.19.1 > > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: greybus: remove unmatched right bracket 2018-11-04 6:27 ` [Outreachy kernel] " Julia Lawall @ 2018-11-04 12:01 ` Ioannis Valasakis 2018-11-04 12:03 ` Julia Lawall 0 siblings, 1 reply; 5+ messages in thread From: Ioannis Valasakis @ 2018-11-04 12:01 UTC (permalink / raw) To: Julia Lawall; +Cc: outreachy-kernel, gregkh On Sun, Nov 04, 2018 at 07:27:27AM +0100, Julia Lawall wrote: > > > On Sun, 4 Nov 2018, Ioannis Valasakis wrote: > > > Remove unmatched right bracket. > > Reported by uncrustify. > > > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk> > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > > I wondered how such a problem could go unnoticed, but this file seems to > have a lot of other compilation problems that could perhaps also be fixed > up. Weird indeed. I was wondering myself after compiling the modules but I noticed that camera isn't compile by running a make. Could you let me know how did you find out the compilation problems, i.e. how did you try compiling camera.c, so that I can replicate? thanks ioannis > > julia > > > --- > > drivers/staging/greybus/camera.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > > index 6dded10f4155..c6d65430ea4c 100644 > > --- a/drivers/staging/greybus/camera.c > > +++ b/drivers/staging/greybus/camera.c > > @@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam) > > debugfs_create_file(entry->name, entry->mask, > > gcam->debugfs.root, gcam, > > &gb_camera_debugfs_ops); > > - } > > } > > > > return 0; > > -- > > 2.19.1 > > > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local. > > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: greybus: remove unmatched right bracket 2018-11-04 12:01 ` Ioannis Valasakis @ 2018-11-04 12:03 ` Julia Lawall 2018-11-04 12:08 ` Ioannis Valasakis 0 siblings, 1 reply; 5+ messages in thread From: Julia Lawall @ 2018-11-04 12:03 UTC (permalink / raw) To: Ioannis Valasakis; +Cc: outreachy-kernel, gregkh On Sun, 4 Nov 2018, Ioannis Valasakis wrote: > On Sun, Nov 04, 2018 at 07:27:27AM +0100, Julia Lawall wrote: > > > > > > On Sun, 4 Nov 2018, Ioannis Valasakis wrote: > > > > > Remove unmatched right bracket. > > > Reported by uncrustify. > > > > > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk> > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > > > > I wondered how such a problem could go unnoticed, but this file seems to > > have a lot of other compilation problems that could perhaps also be fixed > > up. > Weird indeed. I was wondering myself after compiling the modules but I > noticed that camera isn't compile by running a make. Could you let me > know how did you find out the compilation problems, i.e. how did you try > compiling camera.c, so that I can replicate? make drivers/staging/greybus/camera.o julia > > thanks > ioannis > > > > julia > > > > > --- > > > drivers/staging/greybus/camera.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > > > index 6dded10f4155..c6d65430ea4c 100644 > > > --- a/drivers/staging/greybus/camera.c > > > +++ b/drivers/staging/greybus/camera.c > > > @@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam) > > > debugfs_create_file(entry->name, entry->mask, > > > gcam->debugfs.root, gcam, > > > &gb_camera_debugfs_ops); > > > - } > > > } > > > > > > return 0; > > > -- > > > 2.19.1 > > > > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local. > > > For more options, visit https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104120107.GA12077%40kvasir.local. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: greybus: remove unmatched right bracket 2018-11-04 12:03 ` Julia Lawall @ 2018-11-04 12:08 ` Ioannis Valasakis 0 siblings, 0 replies; 5+ messages in thread From: Ioannis Valasakis @ 2018-11-04 12:08 UTC (permalink / raw) To: Julia Lawall; +Cc: outreachy-kernel, gregkh On Sun, Nov 04, 2018 at 01:03:43PM +0100, Julia Lawall wrote: > > > On Sun, 4 Nov 2018, Ioannis Valasakis wrote: > > > On Sun, Nov 04, 2018 at 07:27:27AM +0100, Julia Lawall wrote: > > > > > > > > > On Sun, 4 Nov 2018, Ioannis Valasakis wrote: > > > > > > > Remove unmatched right bracket. > > > > Reported by uncrustify. > > > > > > > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk> > > > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > > > > > > I wondered how such a problem could go unnoticed, but this file seems to > > > have a lot of other compilation problems that could perhaps also be fixed > > > up. > > Weird indeed. I was wondering myself after compiling the modules but I > > noticed that camera isn't compile by running a make. Could you let me > > know how did you find out the compilation problems, i.e. how did you try > > compiling camera.c, so that I can replicate? > > make drivers/staging/greybus/camera.o Of course, you do that from the top level directory. I was running make from inside the greybus folder and I was getting path include errors! thanks! > > julia > > > > > > thanks > > ioannis > > > > > > julia > > > > > > > --- > > > > drivers/staging/greybus/camera.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > > > > index 6dded10f4155..c6d65430ea4c 100644 > > > > --- a/drivers/staging/greybus/camera.c > > > > +++ b/drivers/staging/greybus/camera.c > > > > @@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam) > > > > debugfs_create_file(entry->name, entry->mask, > > > > gcam->debugfs.root, gcam, > > > > &gb_camera_debugfs_ops); > > > > - } > > > > } > > > > > > > > return 0; > > > > -- > > > > 2.19.1 > > > > > > > > > > > > -- > > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local. > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104120107.GA12077%40kvasir.local. > > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-04 12:08 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-04 2:02 [PATCH] staging: greybus: remove unmatched right bracket Ioannis Valasakis 2018-11-04 6:27 ` [Outreachy kernel] " Julia Lawall 2018-11-04 12:01 ` Ioannis Valasakis 2018-11-04 12:03 ` Julia Lawall 2018-11-04 12:08 ` Ioannis Valasakis
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.