All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Lu Baolu <baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	Jean-Philippe Brucker
	<jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>,
	sanjay.k.kumar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	jacob.jun.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	yi.y.sun-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode
Date: Sun, 4 Nov 2018 23:15:05 -0800	[thread overview]
Message-ID: <20181105071505.GA13230@infradead.org> (raw)
In-Reply-To: <20181105053151.7173-12-baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

> --- a/include/linux/dma_remapping.h
> +++ b/include/linux/dma_remapping.h

FYI, this file seems to be entirely VT-D specific, but has an awfully
generic name.  It should be renamed to something more suitable (or maybe
just merged into intel-iommu.h?) and also grow some comments describing
the contents.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	kevin.tian@intel.com, ashok.raj@intel.com,
	Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
	sanjay.k.kumar@intel.com, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, yi.y.sun@intel.com,
	jacob.jun.pan@intel.com
Subject: Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode
Date: Sun, 4 Nov 2018 23:15:05 -0800	[thread overview]
Message-ID: <20181105071505.GA13230@infradead.org> (raw)
In-Reply-To: <20181105053151.7173-12-baolu.lu@linux.intel.com>

> --- a/include/linux/dma_remapping.h
> +++ b/include/linux/dma_remapping.h

FYI, this file seems to be entirely VT-D specific, but has an awfully
generic name.  It should be renamed to something more suitable (or maybe
just merged into intel-iommu.h?) and also grow some comments describing
the contents.

  parent reply	other threads:[~2018-11-05  7:15 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  5:31 [PATCH v4 00/12] iommu/vt-d: Add scalable mode support Lu Baolu
2018-11-05  5:31 ` Lu Baolu
2018-11-05  5:31 ` [PATCH v4 01/12] iommu/vt-d: Enumerate the scalable mode capability Lu Baolu
2018-11-05  5:31 ` [PATCH v4 02/12] iommu/vt-d: Manage scalalble mode PASID tables Lu Baolu
2018-11-05  5:31 ` [PATCH v4 03/12] iommu/vt-d: Move page table helpers into header Lu Baolu
2018-11-07  7:41   ` Liu, Yi L
2018-11-05  5:31 ` [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support Lu Baolu
2018-11-07  6:07   ` Liu, Yi L
     [not found]     ` <A2975661238FB949B60364EF0F2C257439D5FAA2-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-11-08  2:16       ` Lu Baolu
2018-11-08  2:16         ` Lu Baolu
     [not found]         ` <a6e43ddd-0889-4a4a-b908-993db28c6d87-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-11-08  3:49           ` Liu, Yi L
2018-11-08  3:49             ` Liu, Yi L
     [not found]             ` <A2975661238FB949B60364EF0F2C257439D604DF-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-11-08  5:24               ` Lu Baolu
2018-11-08  5:24                 ` Lu Baolu
2018-11-08  5:45                 ` Liu, Yi L
2018-11-08  6:14                   ` Lu Baolu
     [not found]                     ` <ad4f7e5b-9af1-7134-a573-6e78184de0ee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-11-08  7:20                       ` Liu, Yi L
2018-11-08  7:20                         ` Liu, Yi L
2018-11-09  1:39                         ` Lu Baolu
2018-11-09  2:59                           ` Liu, Yi L
2018-11-08  5:48                 ` Liu, Yi L
2018-11-08  5:48                   ` Liu, Yi L
2018-11-08  6:15                   ` Lu Baolu
2018-11-05  5:31 ` [PATCH v4 05/12] iommu/vt-d: Reserve a domain id for FL and PT modes Lu Baolu
2018-11-07  6:55   ` Liu, Yi L
     [not found]     ` <A2975661238FB949B60364EF0F2C257439D5FAE7-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-11-08  2:22       ` Lu Baolu
2018-11-08  2:22         ` Lu Baolu
2018-11-05  5:31 ` [PATCH v4 06/12] iommu/vt-d: Add second level page table interface Lu Baolu
2018-11-07  7:13   ` Liu, Yi L
     [not found]     ` <A2975661238FB949B60364EF0F2C257439D5FB11-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-11-08  2:27       ` Lu Baolu
2018-11-08  2:27         ` Lu Baolu
2018-11-08  4:00         ` Liu, Yi L
2018-11-05  5:31 ` [PATCH v4 07/12] iommu/vt-d: Setup pasid entry for RID2PASID support Lu Baolu
2018-11-05  5:31 ` [PATCH v4 08/12] iommu/vt-d: Pass pasid table to context mapping Lu Baolu
2018-11-07  7:25   ` Liu, Yi L
2018-11-08  2:34     ` Lu Baolu
2018-11-05  5:31 ` [PATCH v4 09/12] iommu/vt-d: Setup context and enable RID2PASID support Lu Baolu
2018-11-05  5:31 ` [PATCH v4 10/12] iommu/vt-d: Add first level page table interface Lu Baolu
     [not found]   ` <20181105053151.7173-11-baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-11-07  7:34     ` Liu, Yi L
2018-11-07  7:34       ` Liu, Yi L
2018-11-05  5:31 ` [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode Lu Baolu
     [not found]   ` <20181105053151.7173-12-baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-11-05  7:15     ` Christoph Hellwig [this message]
2018-11-05  7:15       ` Christoph Hellwig
2018-11-05  7:17       ` Lu Baolu
2018-11-05  5:31 ` [PATCH v4 12/12] iommu/vt-d: Remove deferred invalidation Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105071505.GA13230@infradead.org \
    --to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jacob.jun.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org \
    --cc=kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sanjay.k.kumar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=yi.y.sun-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.