All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, Vignesh R <vigneshr@ti.com>,
	Cyrille Pitchen <cyrille.pitchen@microchip.com>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
	Frieder Schrempf <frieder.schrempf@exceet.de>
Subject: Re: [PATCH v2 0/7] spi: spi-mem: Add a direct mapping API
Date: Tue, 6 Nov 2018 14:21:49 +0100	[thread overview]
Message-ID: <20181106142149.13e35c98@xps13> (raw)
In-Reply-To: <20181030133638.3322-1-boris.brezillon@bootlin.com>

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Tue, 30 Oct 2018
14:36:31 +0100:

> Hello,
> 
> I didn't have much review on the RFC, so I'm resending this series
> without "RFC" in the subject. Maybe I'll get more reviews this time.
> 
> A few things have changed since I submitted the RFC
> - The spi-nand framework has been merged, and I can thus patch this
>   driver to use the dirmap API
> - The MXIC controller has been submitted, and since I did my tests
>   with this controller, I can also add a patch showing how to
>   implement the dirmap hooks
> 
> Other changes are addressing the comments I received from Miquel.
> 
> I'd still like to get feedback on the API and controller interface if
> anyone is interested in reviewing it.
> 
> Thanks,
> 
> Boris
> 
> Boris Brezillon (7):
>   spi: spi-mem: Add missing word in the SPI_MEM_DATA_OUT description
>   spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum
>   spi: spi-mem: Split spi_mem_exec_op() code
>   spi: spi-mem: Add a new API to support direct mapping
>   mtd: devices: m25p80: Use the spi-mem dirmap API
>   mtd: spinand: Use the spi-mem dirmap API
>   spi: mxic: Add support for direct mapping
> 
>  drivers/mtd/devices/m25p80.c | 142 +++++++++++-------
>  drivers/mtd/nand/spi/core.c  | 231 +++++++++++++++++-------------
>  drivers/spi/spi-mem.c        | 269 ++++++++++++++++++++++++++++++++---
>  drivers/spi/spi-mxic.c       | 140 ++++++++++++++----
>  include/linux/mtd/spinand.h  |   7 +
>  include/linux/spi/spi-mem.h  |  84 ++++++++++-
>  6 files changed, 670 insertions(+), 203 deletions(-)
> 

For the whole series:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
	Vignesh R <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@microchip.com>,
	linux-spi@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
	Frieder Schrempf <frieder.schrempf@exceet.de>,
	Mark Brown <broonie@kernel.org>,
	linux-mtd@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 0/7] spi: spi-mem: Add a direct mapping API
Date: Tue, 6 Nov 2018 14:21:49 +0100	[thread overview]
Message-ID: <20181106142149.13e35c98@xps13> (raw)
In-Reply-To: <20181030133638.3322-1-boris.brezillon@bootlin.com>

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Tue, 30 Oct 2018
14:36:31 +0100:

> Hello,
> 
> I didn't have much review on the RFC, so I'm resending this series
> without "RFC" in the subject. Maybe I'll get more reviews this time.
> 
> A few things have changed since I submitted the RFC
> - The spi-nand framework has been merged, and I can thus patch this
>   driver to use the dirmap API
> - The MXIC controller has been submitted, and since I did my tests
>   with this controller, I can also add a patch showing how to
>   implement the dirmap hooks
> 
> Other changes are addressing the comments I received from Miquel.
> 
> I'd still like to get feedback on the API and controller interface if
> anyone is interested in reviewing it.
> 
> Thanks,
> 
> Boris
> 
> Boris Brezillon (7):
>   spi: spi-mem: Add missing word in the SPI_MEM_DATA_OUT description
>   spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum
>   spi: spi-mem: Split spi_mem_exec_op() code
>   spi: spi-mem: Add a new API to support direct mapping
>   mtd: devices: m25p80: Use the spi-mem dirmap API
>   mtd: spinand: Use the spi-mem dirmap API
>   spi: mxic: Add support for direct mapping
> 
>  drivers/mtd/devices/m25p80.c | 142 +++++++++++-------
>  drivers/mtd/nand/spi/core.c  | 231 +++++++++++++++++-------------
>  drivers/spi/spi-mem.c        | 269 ++++++++++++++++++++++++++++++++---
>  drivers/spi/spi-mxic.c       | 140 ++++++++++++++----
>  include/linux/mtd/spinand.h  |   7 +
>  include/linux/spi/spi-mem.h  |  84 ++++++++++-
>  6 files changed, 670 insertions(+), 203 deletions(-)
> 

For the whole series:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2018-11-06 13:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 13:36 [PATCH v2 0/7] spi: spi-mem: Add a direct mapping API Boris Brezillon
2018-10-30 13:36 ` Boris Brezillon
2018-10-30 13:36 ` [PATCH v2 1/7] spi: spi-mem: Add missing word in the SPI_MEM_DATA_OUT description Boris Brezillon
2018-10-30 13:36   ` Boris Brezillon
2018-10-30 13:36 ` [PATCH v2 2/7] spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum Boris Brezillon
2018-10-30 13:36   ` Boris Brezillon
2018-10-30 13:36 ` [PATCH v2 3/7] spi: spi-mem: Split spi_mem_exec_op() code Boris Brezillon
2018-10-30 13:36   ` Boris Brezillon
2018-10-30 13:36 ` [PATCH v2 4/7] spi: spi-mem: Add a new API to support direct mapping Boris Brezillon
2018-10-30 13:36   ` Boris Brezillon
2018-10-30 13:36 ` [PATCH v2 5/7] mtd: devices: m25p80: Use the spi-mem dirmap API Boris Brezillon
2018-10-30 13:36   ` Boris Brezillon
2018-10-31 10:28   ` Yogesh Narayan Gaur
2018-10-31 10:28     ` Yogesh Narayan Gaur
2018-10-31 10:49     ` Boris Brezillon
2018-10-31 10:49       ` Boris Brezillon
2018-10-31 11:03       ` Boris Brezillon
2018-10-31 11:03         ` Boris Brezillon
2018-10-30 13:36 ` [PATCH v2 6/7] mtd: spinand: " Boris Brezillon
2018-10-30 13:36   ` Boris Brezillon
2018-10-30 13:36 ` [PATCH v2 7/7] spi: mxic: Add support for direct mapping Boris Brezillon
2018-10-30 13:36   ` Boris Brezillon
2018-11-06 13:21 ` Miquel Raynal [this message]
2018-11-06 13:21   ` [PATCH v2 0/7] spi: spi-mem: Add a direct mapping API Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181106142149.13e35c98@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@microchip.com \
    --cc=dwmw2@infradead.org \
    --cc=frieder.schrempf@exceet.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.