All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Husemann <martin@NetBSD.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Portability of sh scripts
Date: Fri, 9 Nov 2018 13:08:42 +0100	[thread overview]
Message-ID: <20181109120842.GA21976@mail.duskware.de> (raw)

Hey folks,

I noticed that tools/imx_cntr_image.sh contains non-portable code:

	if [ $f == "u-boot-dtb.bin" ]; then

This is a "bash-ism", the operator "==" is not implemented by most test(1)
or sh(1) impmlementations. Simply replacing it with "=" fixes this.

Should I send a trivial patch or do you just fix it?

Thanks,

Martin

             reply	other threads:[~2018-11-09 12:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 12:08 Martin Husemann [this message]
2018-11-09 12:11 ` [U-Boot] Portability of sh scripts Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109120842.GA21976@mail.duskware.de \
    --to=martin@netbsd.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.