From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Portability of sh scripts
Date: Fri, 9 Nov 2018 07:11:15 -0500 [thread overview]
Message-ID: <20181109121115.GL11247@bill-the-cat> (raw)
In-Reply-To: <20181109120842.GA21976@mail.duskware.de>
On Fri, Nov 09, 2018 at 01:08:42PM +0100, Martin Husemann wrote:
> Hey folks,
>
> I noticed that tools/imx_cntr_image.sh contains non-portable code:
>
> if [ $f == "u-boot-dtb.bin" ]; then
>
> This is a "bash-ism", the operator "==" is not implemented by most test(1)
> or sh(1) impmlementations. Simply replacing it with "=" fixes this.
>
> Should I send a trivial patch or do you just fix it?
Please send a patch, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181109/7a981e59/attachment.sig>
prev parent reply other threads:[~2018-11-09 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 12:08 [U-Boot] Portability of sh scripts Martin Husemann
2018-11-09 12:11 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109121115.GL11247@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.