From: Johan Hovold <johan@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] USB: serial: quatech2: remove set but not used variable 'port_priv'
Date: Mon, 12 Nov 2018 09:09:34 +0000 [thread overview]
Message-ID: <20181112090934.GB13311@localhost> (raw)
On Thu, Oct 11, 2018 at 07:44:33AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> drivers/usb/serial/quatech2.c:503:27: warning:
> variable 'port_priv' set but not used [-Wunused-but-set-variable]
>
> It not used any more after
> commit 2be818a116b2 ("Revert "USB: quatech2: only write to the tty if the port is open."")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Now applied. Thanks for including the not-used-since information.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [-next] USB: serial: quatech2: remove set but not used variable 'port_priv'
Date: Mon, 12 Nov 2018 10:09:34 +0100 [thread overview]
Message-ID: <20181112090934.GB13311@localhost> (raw)
On Thu, Oct 11, 2018 at 07:44:33AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> drivers/usb/serial/quatech2.c:503:27: warning:
> variable 'port_priv' set but not used [-Wunused-but-set-variable]
>
> It not used any more after
> commit 2be818a116b2 ("Revert "USB: quatech2: only write to the tty if the port is open."")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Now applied. Thanks for including the not-used-since information.
Johan
next reply other threads:[~2018-11-12 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 9:09 Johan Hovold [this message]
2018-11-12 9:09 ` [-next] USB: serial: quatech2: remove set but not used variable 'port_priv' Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-10-11 7:44 [PATCH -next] " YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112090934.GB13311@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.