All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Wen Gong <wgong@qti.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Wen Gong <wgong@codeaurora.org>
Subject: Re: [PATCH] ath10k: support PCIe enter L1 state
Date: Thu, 15 Nov 2018 10:43:33 -0800	[thread overview]
Message-ID: <20181115184333.GA87504@google.com> (raw)
In-Reply-To: <c94346b26a6d4b11a045a176ca854051@aptaiexm02f.ap.qualcomm.com>

Hi,

On Thu, Nov 15, 2018 at 06:38:25AM +0000, Wen Gong wrote:
> > -----Original Message-----
> > From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Brian Norris
> > 
> > Is there some reason L1 was disabled in the first place? Was it known to be
> > unreliable?
>
> Hi Brian,
> It is a BUG for power, and it is not considered this BUG before.
> So this change will fix the bug.

I understand that the existing behavior is suboptimal for power, but on
the other hand, code that goes out of its way to *clear* the L1 flag
doesn't just pop up out of nowhere. Somebody clearly wrote that! If it
just meant "we didn't verify L1 at first", then maybe it's fine to
enable it unconditionally and see what happens, but if it meant "we
tried L1 on some old chip XXXX and it caused problems", then it would be
nice to know what those problems were.

Or maybe that is hard to figure out, given there's no public git history
tracking the original code, and we just need to try it out.

Anyway, I'm giving it a try here, but I just wanted to ask :)

Thanks,
Brian

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Wen Gong <wgong@qti.qualcomm.com>
Cc: Wen Gong <wgong@codeaurora.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: support PCIe enter L1 state
Date: Thu, 15 Nov 2018 10:43:33 -0800	[thread overview]
Message-ID: <20181115184333.GA87504@google.com> (raw)
In-Reply-To: <c94346b26a6d4b11a045a176ca854051@aptaiexm02f.ap.qualcomm.com>

Hi,

On Thu, Nov 15, 2018 at 06:38:25AM +0000, Wen Gong wrote:
> > -----Original Message-----
> > From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Brian Norris
> > 
> > Is there some reason L1 was disabled in the first place? Was it known to be
> > unreliable?
>
> Hi Brian,
> It is a BUG for power, and it is not considered this BUG before.
> So this change will fix the bug.

I understand that the existing behavior is suboptimal for power, but on
the other hand, code that goes out of its way to *clear* the L1 flag
doesn't just pop up out of nowhere. Somebody clearly wrote that! If it
just meant "we didn't verify L1 at first", then maybe it's fine to
enable it unconditionally and see what happens, but if it meant "we
tried L1 on some old chip XXXX and it caused problems", then it would be
nice to know what those problems were.

Or maybe that is hard to figure out, given there's no public git history
tracking the original code, and we just need to try it out.

Anyway, I'm giving it a try here, but I just wanted to ask :)

Thanks,
Brian

  reply	other threads:[~2018-11-15 18:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14  2:50 [PATCH] ath10k: support PCIe enter L1 state Wen Gong
2018-11-14  2:50 ` Wen Gong
2018-11-15  0:28 ` Brian Norris
2018-11-15  0:28   ` Brian Norris
2018-11-15  6:38   ` Wen Gong
2018-11-15  6:38     ` Wen Gong
2018-11-15 18:43     ` Brian Norris [this message]
2018-11-15 18:43       ` Brian Norris
2018-11-16  7:00       ` Kalle Valo
2018-11-16  7:00         ` Kalle Valo
2018-11-16  7:56         ` Michał Kazior
2018-11-16  7:56           ` Michał Kazior
2019-02-08 13:42           ` Kalle Valo
2019-02-08 13:42             ` Kalle Valo
2019-02-08 17:05             ` Brian Norris
2019-02-08 17:05               ` Brian Norris
2019-03-08  9:42               ` Kalle Valo
2019-03-08  9:42                 ` Kalle Valo
2019-12-02 18:48                 ` Brian Norris
2019-12-02 18:48                   ` Brian Norris
2020-02-13 11:15                   ` Kalle Valo
2020-02-13 11:15                     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115184333.GA87504@google.com \
    --to=briannorris@chromium.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    --cc=wgong@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.