From: Boris Brezillon <boris.brezillon@bootlin.com>
To: vitor <vitor.soares@synopsys.com>
Cc: <wsa@the-dreams.de>, <linux-i2c@vger.kernel.org>,
<corbet@lwn.net>, <linux-doc@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <arnd@arndb.de>,
<psroka@cadence.com>, <agolec@cadence.com>,
<adouglas@cadence.com>, <bfolta@cadence.com>, <dkos@cadence.com>,
<alicja@cadence.com>, <cwronka@cadence.com>,
<sureshp@cadence.com>, <rafalc@cadence.com>,
<thomas.petazzoni@bootlin.com>, <nm@ti.com>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<geert@linux-m68k.org>, <linus.walleij@linaro.org>,
<Xiang.Lin@synaptics.com>, <linux-gpio@vger.kernel.org>,
<nsekhar@ti.com>, <pgaj@cadence.com>, <peda@axentia.se>,
<mshettel@codeaurora.org>, <swboyd@chromium.org>,
<joao.pinto@synopsys.com>
Subject: Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts
Date: Mon, 26 Nov 2018 20:08:55 +0100 [thread overview]
Message-ID: <20181126200855.0caa45b0@bbrezillon> (raw)
In-Reply-To: <20181126195618.352eafb1@bbrezillon>
On Mon, 26 Nov 2018 19:56:18 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> >
> > - for the others it will easy the SoC integration avoiding
> > duplicated work and doing things from scratch.
>
> What would be duplicated? You want to support a new SoC, just add a new
> entry in the of_match_table and you're done. When you need to add
> SoC/integration specific stuff, create a struct and attach a different
> instance per-compatible so that each SoC can have its own configuration
> (or even init sequence if needed). That's how we do for pretty much all
> IPs out there, why should designware ones be different?
To be more specific, I'd like a real example that shows why the
separation is needed.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: vitor <vitor.soares@synopsys.com>
Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, psroka@cadence.com, agolec@cadence.com,
adouglas@cadence.com, bfolta@cadence.com, dkos@cadence.com,
alicja@cadence.com, cwronka@cadence.com, sureshp@cadence.com,
rafalc@cadence.com, thomas.petazzoni@bootlin.com, nm@ti.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
geert@linux-m68k.org, linus.walleij@linaro.org,
Xiang.Lin@synaptics.com, linux-gpio@vger.kernel.org,
nsekhar@ti.com, pgaj@cadence.com, peda@axentia.se,
mshettel@codeaurora.org, swboyd@chromium.org
Subject: Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts
Date: Mon, 26 Nov 2018 20:08:55 +0100 [thread overview]
Message-ID: <20181126200855.0caa45b0@bbrezillon> (raw)
In-Reply-To: <20181126195618.352eafb1@bbrezillon>
On Mon, 26 Nov 2018 19:56:18 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> >
> > - for the others it will easy the SoC integration avoiding
> > duplicated work and doing things from scratch.
>
> What would be duplicated? You want to support a new SoC, just add a new
> entry in the of_match_table and you're done. When you need to add
> SoC/integration specific stuff, create a struct and attach a different
> instance per-compatible so that each SoC can have its own configuration
> (or even init sequence if needed). That's how we do for pretty much all
> IPs out there, why should designware ones be different?
To be more specific, I'd like a real example that shows why the
separation is needed.
next prev parent reply other threads:[~2018-11-26 19:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 17:54 [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts Vitor Soares
2018-11-22 17:54 ` Vitor Soares
2018-11-22 20:02 ` Boris Brezillon
2018-11-23 12:39 ` vitor
2018-11-23 12:39 ` vitor
2018-11-23 12:50 ` Boris Brezillon
2018-11-23 12:50 ` Boris Brezillon
2018-11-26 12:06 ` vitor
2018-11-26 12:06 ` vitor
2018-11-26 12:35 ` Boris Brezillon
2018-11-26 12:35 ` Boris Brezillon
2018-11-26 18:33 ` vitor
2018-11-26 18:33 ` vitor
2018-11-26 18:56 ` Boris Brezillon
2018-11-26 18:56 ` Boris Brezillon
2018-11-26 19:08 ` Boris Brezillon [this message]
2018-11-26 19:08 ` Boris Brezillon
2018-11-26 19:28 ` vitor
2018-11-26 19:28 ` vitor
2018-11-26 20:06 ` Boris Brezillon
2018-11-26 20:06 ` Boris Brezillon
2018-11-26 20:11 ` vitor
2018-11-26 20:11 ` vitor
2018-11-26 21:33 ` Boris Brezillon
2018-11-26 21:33 ` Boris Brezillon
2018-11-27 11:50 ` vitor
2018-11-27 11:50 ` vitor
2018-11-27 12:33 ` Boris Brezillon
2018-11-27 12:33 ` Boris Brezillon
2018-12-04 0:34 ` vitor
2018-12-04 0:34 ` vitor
2018-12-04 9:19 ` Boris Brezillon
2018-12-04 9:19 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126200855.0caa45b0@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Xiang.Lin@synaptics.com \
--cc=adouglas@cadence.com \
--cc=agolec@cadence.com \
--cc=alicja@cadence.com \
--cc=arnd@arndb.de \
--cc=bfolta@cadence.com \
--cc=corbet@lwn.net \
--cc=cwronka@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=dkos@cadence.com \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joao.pinto@synopsys.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mshettel@codeaurora.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=peda@axentia.se \
--cc=pgaj@cadence.com \
--cc=psroka@cadence.com \
--cc=rafalc@cadence.com \
--cc=robh+dt@kernel.org \
--cc=sureshp@cadence.com \
--cc=swboyd@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vitor.soares@synopsys.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.