From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"joro@8bytes.org" <joro@8bytes.org>,
Mark Rutland <Mark.Rutland@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"tnowicki@caviumnetworks.com" <tnowicki@caviumnetworks.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver
Date: Tue, 27 Nov 2018 13:10:43 -0500 [thread overview]
Message-ID: <20181127131031-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com>
On Tue, Nov 27, 2018 at 05:58:18PM +0000, Jean-Philippe Brucker wrote:
> On 23/11/2018 21:48, Michael S. Tsirkin wrote:
> >> +struct virtio_iommu_config {
> >> + /* Supported page sizes */
> >> + __u64 page_size_mask;
> >> + /* Supported IOVA range */
> >> + struct virtio_iommu_range input_range;
> >> + /* Max domain ID size */
> >> + __u8 domain_bits;
> >> + __u8 padding[3];
> >
> > Not enough padding here it seems. Structure is 8 byte
> > aligned on 64 bit systems.
>
> The next field (probe_size) is 4 bytes, so the alignment ends up fine.
> That field is introduced in patch 6, maybe I should move it here?
>
> Thanks,
> Jean
Sounds like a good idea.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"joro@8bytes.org" <joro@8bytes.org>,
Mark Rutland <Mark.Rutland@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"tnowicki@caviumnetworks.com" <tnowicki@caviumnetworks.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver
Date: Tue, 27 Nov 2018 13:10:43 -0500 [thread overview]
Message-ID: <20181127131031-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com>
On Tue, Nov 27, 2018 at 05:58:18PM +0000, Jean-Philippe Brucker wrote:
> On 23/11/2018 21:48, Michael S. Tsirkin wrote:
> >> +struct virtio_iommu_config {
> >> + /* Supported page sizes */
> >> + __u64 page_size_mask;
> >> + /* Supported IOVA range */
> >> + struct virtio_iommu_range input_range;
> >> + /* Max domain ID size */
> >> + __u8 domain_bits;
> >> + __u8 padding[3];
> >
> > Not enough padding here it seems. Structure is 8 byte
> > aligned on 64 bit systems.
>
> The next field (probe_size) is 4 bytes, so the alignment ends up fine.
> That field is introduced in patch 6, maybe I should move it here?
>
> Thanks,
> Jean
Sounds like a good idea.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-11-27 18:10 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 19:37 [PATCH v5 0/7] Add virtio-iommu driver Jean-Philippe Brucker
2018-11-22 19:37 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-22 19:37 ` [PATCH v5 1/7] dt-bindings: virtio-mmio: Add IOMMU description Jean-Philippe Brucker
2018-11-22 19:37 ` Jean-Philippe Brucker
2018-11-22 19:37 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-22 19:37 ` [PATCH v5 2/7] dt-bindings: virtio: Add virtio-pci-iommu node Jean-Philippe Brucker
2018-11-22 19:37 ` Jean-Philippe Brucker
2018-11-22 19:37 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-22 19:37 ` [PATCH v5 3/7] of: Allow the iommu-map property to omit untranslated devices Jean-Philippe Brucker
2018-11-22 19:37 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-22 19:37 ` Jean-Philippe Brucker
2018-11-22 19:37 ` [PATCH v5 4/7] PCI: OF: Initialize dev->fwnode appropriately Jean-Philippe Brucker
2018-11-22 19:37 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-22 19:37 ` Jean-Philippe Brucker
2018-11-22 19:37 ` [PATCH v5 5/7] iommu: Add virtio-iommu driver Jean-Philippe Brucker
2018-11-22 19:37 ` Jean-Philippe Brucker
2018-11-22 19:37 ` [virtio-dev] " Jean-Philippe Brucker
[not found] ` <20181122193801.50510-6-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-11-23 8:27 ` Auger Eric
2018-11-23 8:27 ` [virtio-dev] " Auger Eric
2018-11-23 8:27 ` Auger Eric
2018-11-23 8:27 ` Auger Eric
2018-11-23 21:48 ` Michael S. Tsirkin
2018-11-23 21:48 ` [virtio-dev] " Michael S. Tsirkin
2018-11-23 21:48 ` Michael S. Tsirkin
2018-11-27 17:58 ` Jean-Philippe Brucker
2018-11-27 17:58 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-27 18:10 ` Michael S. Tsirkin [this message]
2018-11-27 18:10 ` Michael S. Tsirkin
2018-11-27 18:10 ` Michael S. Tsirkin
2018-11-27 17:58 ` Jean-Philippe Brucker
2018-11-23 21:48 ` Michael S. Tsirkin
2018-11-23 21:56 ` Michael S. Tsirkin
2018-11-23 21:56 ` [virtio-dev] " Michael S. Tsirkin
2018-11-27 17:55 ` Jean-Philippe Brucker
2018-11-27 17:55 ` Jean-Philippe Brucker
2018-11-27 17:55 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-27 18:10 ` Michael S. Tsirkin
2018-11-27 18:10 ` [virtio-dev] " Michael S. Tsirkin
2018-12-07 18:52 ` Jean-Philippe Brucker
2018-12-07 18:52 ` [virtio-dev] " Jean-Philippe Brucker
2018-12-07 18:52 ` Jean-Philippe Brucker
2018-12-12 14:56 ` Michael S. Tsirkin
[not found] ` <e1dde79c-0bc4-ea99-1bb0-9e70b56955fb-5wv7dgnIgG8@public.gmane.org>
2018-12-12 14:56 ` Michael S. Tsirkin
2018-12-12 14:56 ` Michael S. Tsirkin
2018-12-12 14:56 ` Michael S. Tsirkin
2018-12-12 15:27 ` Auger Eric
[not found] ` <20181212093709-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-12-12 15:27 ` Auger Eric
2018-12-12 15:27 ` Auger Eric
2018-12-12 15:27 ` Auger Eric
2018-12-13 12:37 ` Robin Murphy
2018-12-13 12:37 ` Robin Murphy
2018-12-13 14:13 ` Auger Eric
2018-12-13 14:13 ` [virtio-dev] " Auger Eric
2018-12-13 14:13 ` Auger Eric
2018-12-13 14:13 ` Auger Eric
2018-12-13 12:37 ` Robin Murphy
2018-12-07 18:52 ` Jean-Philippe Brucker
2018-11-27 18:10 ` Michael S. Tsirkin
2018-11-23 21:56 ` Michael S. Tsirkin
2018-11-23 22:02 ` Michael S. Tsirkin
2018-11-23 22:02 ` [virtio-dev] " Michael S. Tsirkin
2018-11-27 17:50 ` Jean-Philippe Brucker
2018-11-27 17:50 ` Jean-Philippe Brucker
2018-11-27 17:50 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-27 18:04 ` Michael S. Tsirkin
2018-11-27 18:04 ` [virtio-dev] " Michael S. Tsirkin
2018-11-27 18:10 ` Jean-Philippe Brucker
2018-11-27 18:10 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-27 18:53 ` Michael S. Tsirkin
2018-11-27 18:53 ` [virtio-dev] " Michael S. Tsirkin
2018-12-10 15:06 ` Jean-Philippe Brucker
2018-12-10 15:06 ` [virtio-dev] " Jean-Philippe Brucker
2018-12-10 22:53 ` Michael S. Tsirkin
2018-12-10 22:53 ` Michael S. Tsirkin
2018-12-10 22:53 ` [virtio-dev] " Michael S. Tsirkin
[not found] ` <20181210175132-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-12-11 16:29 ` Jean-Philippe Brucker
2018-12-11 16:29 ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 16:29 ` Jean-Philippe Brucker
2018-12-11 16:29 ` Jean-Philippe Brucker
2018-12-10 15:06 ` Jean-Philippe Brucker
2018-11-27 18:53 ` Michael S. Tsirkin
2018-11-27 18:10 ` Jean-Philippe Brucker
2018-11-27 18:13 ` Michael S. Tsirkin
2018-11-27 18:13 ` Michael S. Tsirkin
2018-11-27 18:13 ` [virtio-dev] " Michael S. Tsirkin
2018-11-23 22:02 ` Michael S. Tsirkin
2018-11-22 19:38 ` [PATCH v5 6/7] iommu/virtio: Add probe request Jean-Philippe Brucker
2018-11-22 19:38 ` Jean-Philippe Brucker
2018-11-22 19:38 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-22 19:38 ` [PATCH v5 7/7] iommu/virtio: Add event queue Jean-Philippe Brucker
2018-11-22 19:38 ` [virtio-dev] " Jean-Philippe Brucker
2018-11-22 19:38 ` Jean-Philippe Brucker
2018-11-23 8:28 ` [PATCH v5 0/7] Add virtio-iommu driver Auger Eric
2018-11-23 8:28 ` [virtio-dev] " Auger Eric
2018-11-27 7:09 ` Bharat Bhushan
2018-11-27 7:09 ` Bharat Bhushan
2018-11-27 7:09 ` [virtio-dev] " Bharat Bhushan
2018-11-23 8:28 ` Auger Eric
[not found] ` <20181122193801.50510-1-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-11-27 16:53 ` Michael S. Tsirkin
2018-11-27 16:53 ` [virtio-dev] " Michael S. Tsirkin
2018-11-27 16:53 ` Michael S. Tsirkin
2018-11-27 17:09 ` Auger Eric
2018-11-27 17:09 ` Auger Eric
2018-11-27 17:09 ` [virtio-dev] " Auger Eric
2018-11-27 17:16 ` Michael S. Tsirkin
[not found] ` <6c061729-c404-ac25-f86f-7fe222bf5bc7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-27 17:16 ` Michael S. Tsirkin
2018-11-27 17:16 ` [virtio-dev] " Michael S. Tsirkin
2018-11-27 17:16 ` Michael S. Tsirkin
2018-11-27 18:02 ` Auger Eric
2018-11-27 18:02 ` Auger Eric
2018-11-27 18:02 ` [virtio-dev] " Auger Eric
2018-12-03 13:27 ` Auger Eric
2018-12-03 13:27 ` Auger Eric
2018-12-03 13:27 ` [virtio-dev] " Auger Eric
2018-11-27 16:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127131031-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Robin.Murphy@arm.com \
--cc=Will.Deacon@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=joro@8bytes.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-pci@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tnowicki@caviumnetworks.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.