From: Keith Busch <keith.busch@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] blk-mq: Export iterating all tagged requests
Date: Fri, 30 Nov 2018 13:39:02 -0700 [thread overview]
Message-ID: <20181130203901.GA11193@localhost.localdomain> (raw)
In-Reply-To: <823fc3bf-78a4-c8fb-c80c-e3944f320af0@kernel.dk>
On Fri, Nov 30, 2018 at 01:36:09PM -0700, Jens Axboe wrote:
> On 11/30/18 1:26 PM, Keith Busch wrote:
> > A driver may wish to iterate every tagged request, not just ones that
> > satisfy blk_mq_request_started(). The intended use is so a driver may
> > terminate entered requests on quiesced queues.
>
> How about we just move the started check into the handler passed in for
> those that care about it? Much saner to make the interface iterate
> everything, and leave whatever state check to the callback.
I agree that's better. I initially didn't want to examine all the users
but looks like only 4 drivers using the current tagset iterator, so
that's not too daunting. I'll give it a look.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] blk-mq: Export iterating all tagged requests
Date: Fri, 30 Nov 2018 13:39:02 -0700 [thread overview]
Message-ID: <20181130203901.GA11193@localhost.localdomain> (raw)
In-Reply-To: <823fc3bf-78a4-c8fb-c80c-e3944f320af0@kernel.dk>
On Fri, Nov 30, 2018@01:36:09PM -0700, Jens Axboe wrote:
> On 11/30/18 1:26 PM, Keith Busch wrote:
> > A driver may wish to iterate every tagged request, not just ones that
> > satisfy blk_mq_request_started(). The intended use is so a driver may
> > terminate entered requests on quiesced queues.
>
> How about we just move the started check into the handler passed in for
> those that care about it? Much saner to make the interface iterate
> everything, and leave whatever state check to the callback.
I agree that's better. I initially didn't want to examine all the users
but looks like only 4 drivers using the current tagset iterator, so
that's not too daunting. I'll give it a look.
next prev parent reply other threads:[~2018-11-30 20:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 20:26 [PATCH 1/2] blk-mq: Export iterating all tagged requests Keith Busch
2018-11-30 20:26 ` Keith Busch
2018-11-30 20:26 ` [PATCH 2/2] nvme: Remove queue flushing hack Keith Busch
2018-11-30 20:26 ` Keith Busch
2018-11-30 20:36 ` [PATCH 1/2] blk-mq: Export iterating all tagged requests Jens Axboe
2018-11-30 20:36 ` Jens Axboe
2018-11-30 20:39 ` Keith Busch [this message]
2018-11-30 20:39 ` Keith Busch
2018-12-01 16:48 ` Christoph Hellwig
2018-12-01 16:48 ` Christoph Hellwig
2018-12-01 17:11 ` Hannes Reinecke
2018-12-01 17:11 ` Hannes Reinecke
2018-12-01 18:32 ` Bart Van Assche
2018-12-01 18:32 ` Bart Van Assche
2018-12-03 18:57 ` James Smart
2018-12-03 18:57 ` James Smart
2018-12-04 1:33 ` Sagi Grimberg
2018-12-04 1:33 ` Sagi Grimberg
2018-12-04 15:46 ` Keith Busch
2018-12-04 15:46 ` Keith Busch
2018-12-04 16:26 ` James Smart
2018-12-04 16:26 ` James Smart
2018-12-04 17:23 ` Sagi Grimberg
2018-12-04 17:23 ` Sagi Grimberg
2018-12-04 19:13 ` James Smart
2018-12-04 19:13 ` James Smart
2018-12-04 17:38 ` Sagi Grimberg
2018-12-04 17:38 ` Sagi Grimberg
2018-12-04 17:48 ` Keith Busch
2018-12-04 17:48 ` Keith Busch
2018-12-04 19:33 ` James Smart
2018-12-04 19:33 ` James Smart
2018-12-04 21:21 ` Keith Busch
2018-12-04 21:21 ` Keith Busch
2018-12-04 21:43 ` Keith Busch
2018-12-04 21:43 ` Keith Busch
2018-12-04 22:09 ` James Smart
2018-12-04 22:09 ` James Smart
2018-12-03 7:44 ` Ming Lei
2018-12-03 7:44 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130203901.GA11193@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.