From: Keith Busch <keith.busch@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 1/2] blk-mq: Export iterating all tagged requests
Date: Tue, 4 Dec 2018 08:46:00 -0700 [thread overview]
Message-ID: <20181204154559.GJ14775@localhost.localdomain> (raw)
In-Reply-To: <8cd9a950-6605-6387-e4d4-4346a46da781@grimberg.me>
On Mon, Dec 03, 2018 at 05:33:06PM -0800, Sagi Grimberg wrote:
> >>
> > Yes, I'm very much in favour of this, too.
> > We always have this IMO slightly weird notion of stopping the queue, set
> > some error flags in the driver, then _restarting_ the queue, just so
> > that the driver then sees the error flag and terminates the requests.
> > Which I always found quite counter-intuitive.
>
> What about requests that come in after the iteration runs? how are those
> terminated?
If we've reached a dead state, I think you'd want to start a queue freeze
before running the terminating iterator.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] blk-mq: Export iterating all tagged requests
Date: Tue, 4 Dec 2018 08:46:00 -0700 [thread overview]
Message-ID: <20181204154559.GJ14775@localhost.localdomain> (raw)
In-Reply-To: <8cd9a950-6605-6387-e4d4-4346a46da781@grimberg.me>
On Mon, Dec 03, 2018@05:33:06PM -0800, Sagi Grimberg wrote:
> >>
> > Yes, I'm very much in favour of this, too.
> > We always have this IMO slightly weird notion of stopping the queue, set
> > some error flags in the driver, then _restarting_ the queue, just so
> > that the driver then sees the error flag and terminates the requests.
> > Which I always found quite counter-intuitive.
>
> What about requests that come in after the iteration runs? how are those
> terminated?
If we've reached a dead state, I think you'd want to start a queue freeze
before running the terminating iterator.
next prev parent reply other threads:[~2018-12-04 15:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 20:26 [PATCH 1/2] blk-mq: Export iterating all tagged requests Keith Busch
2018-11-30 20:26 ` Keith Busch
2018-11-30 20:26 ` [PATCH 2/2] nvme: Remove queue flushing hack Keith Busch
2018-11-30 20:26 ` Keith Busch
2018-11-30 20:36 ` [PATCH 1/2] blk-mq: Export iterating all tagged requests Jens Axboe
2018-11-30 20:36 ` Jens Axboe
2018-11-30 20:39 ` Keith Busch
2018-11-30 20:39 ` Keith Busch
2018-12-01 16:48 ` Christoph Hellwig
2018-12-01 16:48 ` Christoph Hellwig
2018-12-01 17:11 ` Hannes Reinecke
2018-12-01 17:11 ` Hannes Reinecke
2018-12-01 18:32 ` Bart Van Assche
2018-12-01 18:32 ` Bart Van Assche
2018-12-03 18:57 ` James Smart
2018-12-03 18:57 ` James Smart
2018-12-04 1:33 ` Sagi Grimberg
2018-12-04 1:33 ` Sagi Grimberg
2018-12-04 15:46 ` Keith Busch [this message]
2018-12-04 15:46 ` Keith Busch
2018-12-04 16:26 ` James Smart
2018-12-04 16:26 ` James Smart
2018-12-04 17:23 ` Sagi Grimberg
2018-12-04 17:23 ` Sagi Grimberg
2018-12-04 19:13 ` James Smart
2018-12-04 19:13 ` James Smart
2018-12-04 17:38 ` Sagi Grimberg
2018-12-04 17:38 ` Sagi Grimberg
2018-12-04 17:48 ` Keith Busch
2018-12-04 17:48 ` Keith Busch
2018-12-04 19:33 ` James Smart
2018-12-04 19:33 ` James Smart
2018-12-04 21:21 ` Keith Busch
2018-12-04 21:21 ` Keith Busch
2018-12-04 21:43 ` Keith Busch
2018-12-04 21:43 ` Keith Busch
2018-12-04 22:09 ` James Smart
2018-12-04 22:09 ` James Smart
2018-12-03 7:44 ` Ming Lei
2018-12-03 7:44 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204154559.GJ14775@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.