From: Dan Carpenter <dan.carpenter@oracle.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ptp: fix an IS_ERR() vs NULL check
Date: Mon, 03 Dec 2018 10:04:58 +0000 [thread overview]
Message-ID: <20181203100458.GZ3073@unbuntlaptop> (raw)
In-Reply-To: <20181130163252.e6z33t23j3qud57z@localhost>
On Fri, Nov 30, 2018 at 08:32:52AM -0800, Richard Cochran wrote:
> On Fri, Nov 30, 2018 at 03:58:34PM +0300, Dan Carpenter wrote:
> > The pps_register_source() function doesn't return NULL, it returns
> > error pointers.
>
> It keeps a local variable for errno, but then it returns NULL.
> But this is about to change with this recent patch:
>
> 26.Nov'18 YueHaibing [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails
>
> It hasn't been merged yet AFAICT, but gregkh said he take it.
Oh, yeah. That patch has actually been applied, but we didn't update
the caller. I should have made the Fixes tag point to that YueHaibing's
patch.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ptp: fix an IS_ERR() vs NULL check
Date: Mon, 3 Dec 2018 13:04:58 +0300 [thread overview]
Message-ID: <20181203100458.GZ3073@unbuntlaptop> (raw)
In-Reply-To: <20181130163252.e6z33t23j3qud57z@localhost>
On Fri, Nov 30, 2018 at 08:32:52AM -0800, Richard Cochran wrote:
> On Fri, Nov 30, 2018 at 03:58:34PM +0300, Dan Carpenter wrote:
> > The pps_register_source() function doesn't return NULL, it returns
> > error pointers.
>
> It keeps a local variable for errno, but then it returns NULL.
> But this is about to change with this recent patch:
>
> 26.Nov'18 YueHaibing [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails
>
> It hasn't been merged yet AFAICT, but gregkh said he take it.
Oh, yeah. That patch has actually been applied, but we didn't update
the caller. I should have made the Fixes tag point to that YueHaibing's
patch.
regards,
dan carpenter
next prev parent reply other threads:[~2018-12-03 10:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 12:58 [PATCH] ptp: fix an IS_ERR() vs NULL check Dan Carpenter
2018-11-30 12:58 ` Dan Carpenter
2018-11-30 16:32 ` Richard Cochran
2018-11-30 16:32 ` Richard Cochran
2018-12-03 10:04 ` Dan Carpenter [this message]
2018-12-03 10:04 ` Dan Carpenter
[not found] ` <20181203105506.GA21127@unbuntlaptop>
2018-12-04 4:42 ` [PATCH v2] " Richard Cochran
2018-12-04 4:42 ` Richard Cochran
2018-12-04 7:00 ` Dan Carpenter
2018-12-04 7:00 ` Dan Carpenter
2018-12-04 10:54 ` Greg Kroah-Hartman
2018-12-04 10:54 ` Greg Kroah-Hartman
2018-12-04 14:55 ` Richard Cochran
2018-12-04 14:55 ` Richard Cochran
2018-12-04 15:10 ` Dan Carpenter
2018-12-04 15:10 ` Dan Carpenter
2018-12-06 12:38 ` Richard Cochran
2018-12-06 12:38 ` Richard Cochran
2018-12-06 13:57 ` Greg Kroah-Hartman
2018-12-06 13:57 ` Greg Kroah-Hartman
2018-12-07 6:00 ` [PATCH v3] " Dan Carpenter
2018-12-07 6:00 ` Dan Carpenter
2018-12-12 14:17 ` Richard Cochran
2018-12-12 14:17 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203100458.GZ3073@unbuntlaptop \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.