All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	YueHaibing <yuehaibing@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3] ptp: fix an IS_ERR() vs NULL check
Date: Wed, 12 Dec 2018 14:17:02 +0000	[thread overview]
Message-ID: <20181212141702.a23sehqcytipsmp5@localhost> (raw)
In-Reply-To: <20181207060046.GA3943@unbuntlaptop>

On Fri, Dec 07, 2018 at 09:00:46AM +0300, Dan Carpenter wrote:
> We recently modified pps_register_source() to return error pointers
> instead of NULL but it seems like there was a merge issue and part of
> the commit was lost.  Anyway, the ptp_clock_register() function needs to
> be updated to check for IS_ERR() as well.
> 
> Fixes: 3b1ad360acad ("pps: using ERR_PTR instead of NULL while pps_register_source fails")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Greg,

This patch provides the missing hunk.  Please apply it.

Thanks,
Richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	YueHaibing <yuehaibing@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3] ptp: fix an IS_ERR() vs NULL check
Date: Wed, 12 Dec 2018 06:17:02 -0800	[thread overview]
Message-ID: <20181212141702.a23sehqcytipsmp5@localhost> (raw)
In-Reply-To: <20181207060046.GA3943@unbuntlaptop>

On Fri, Dec 07, 2018 at 09:00:46AM +0300, Dan Carpenter wrote:
> We recently modified pps_register_source() to return error pointers
> instead of NULL but it seems like there was a merge issue and part of
> the commit was lost.  Anyway, the ptp_clock_register() function needs to
> be updated to check for IS_ERR() as well.
> 
> Fixes: 3b1ad360acad ("pps: using ERR_PTR instead of NULL while pps_register_source fails")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Greg,

This patch provides the missing hunk.  Please apply it.

Thanks,
Richard

  reply	other threads:[~2018-12-12 14:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 12:58 [PATCH] ptp: fix an IS_ERR() vs NULL check Dan Carpenter
2018-11-30 12:58 ` Dan Carpenter
2018-11-30 16:32 ` Richard Cochran
2018-11-30 16:32   ` Richard Cochran
2018-12-03 10:04   ` Dan Carpenter
2018-12-03 10:04     ` Dan Carpenter
     [not found]   ` <20181203105506.GA21127@unbuntlaptop>
2018-12-04  4:42     ` [PATCH v2] " Richard Cochran
2018-12-04  4:42       ` Richard Cochran
2018-12-04  7:00       ` Dan Carpenter
2018-12-04  7:00         ` Dan Carpenter
2018-12-04 10:54         ` Greg Kroah-Hartman
2018-12-04 10:54           ` Greg Kroah-Hartman
2018-12-04 14:55         ` Richard Cochran
2018-12-04 14:55           ` Richard Cochran
2018-12-04 15:10           ` Dan Carpenter
2018-12-04 15:10             ` Dan Carpenter
2018-12-06 12:38             ` Richard Cochran
2018-12-06 12:38               ` Richard Cochran
2018-12-06 13:57               ` Greg Kroah-Hartman
2018-12-06 13:57                 ` Greg Kroah-Hartman
2018-12-07  6:00                 ` [PATCH v3] " Dan Carpenter
2018-12-07  6:00                   ` Dan Carpenter
2018-12-12 14:17                   ` Richard Cochran [this message]
2018-12-12 14:17                     ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212141702.a23sehqcytipsmp5@localhost \
    --to=richardcochran@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.