* [virtio-dev] [PATCH v3] packed-ring: fix example code
@ 2018-12-05 2:16 Tiwei Bie
2018-12-05 14:04 ` [virtio-dev] " Cornelia Huck
2018-12-05 15:14 ` Michael S. Tsirkin
0 siblings, 2 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-12-05 2:16 UTC (permalink / raw)
To: virtio-dev; +Cc: mst, cohuck, stefanha
Driver can't just check whether USED bit equals to the used
wrap counter when checking whether a descriptor is a used
descriptor, because driver also needs to check whether the
descriptor has been made available. Below is an example:
Assuming ring size is 4, ring's initial state will be:
+----+----+----+----+
| 00 | 00 | 00 | 00 |
+----+----+----+----+
00 means AVAIL=0 USED=0, 01 means AVAIL=0 USED=1
10 means AVAIL=1 USED=0, 11 means AVAIL=1 USED=1
After driver made two descriptor chains available and each
chain consists of two descriptors, the ring could be:
+----+-----------+----+-----------+
| 10 | 10 (id=0) | 10 | 10 (id=1) |
+----+-----------+----+-----------+
After device processed all the available descriptors and made
them used (e.g. in order), the ring could be:
+-----------+----+-----------+----+
| 11 (id=0) | 10 | 11 (id=1) | 10 |
+-----------+----+-----------+----+
After driver processed all the used descriptors and made
one descriptor (not chained, just one descriptor) available,
the ring could be:
+-----------+----+----+----+
| 01 (id=0) | 10 | 11 | 10 |
+-----------+----+----+----+
After device made that descriptor used, the ring will be:
+-----------+----+----+----+
| 00 (id=0) | 10 | 11 | 10 |
+-----------+----+----+----+
If driver just checks whether USED bit equals to the used
wrap counter when checking whether a descriptor is a used
descriptor, after processing the first descriptor (whose
AVAIL and USED bits are both 0), and advancing vq->next_used
pointer, it will then also treat the next descriptor, i.e.
the second descriptor (whose AVAIL and USED bits are 1 and
0 respectively) as a used descriptor which is wrong.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
v2:
- Add "Fixes" tag;
- Refine commit log;
v3:
- Compare with vq->used_wrap_count (MST);
- Add comments (MST);
- Refine commit log;
packed-ring.tex | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/packed-ring.tex b/packed-ring.tex
index f24f49b..c8cd83b 100644
--- a/packed-ring.tex
+++ b/packed-ring.tex
@@ -687,16 +687,29 @@ vq->driver_event.flags = RING_EVENT_FLAGS_DISABLE;
for (;;) {
struct pvirtq_desc *d = vq->desc[vq->next_used];
+ /*
+ * Check that
+ * 1. Descriptor has been made available.
+ * Note: there are many other ways to check this, e.g.
+ * track the number of outstanding available descriptors or buffers
+ * and check that it's not 0.
+ * 2. Descriptor has been used by device.
+ */
flags = d->flags;
+ bool avail = flags & VIRTQ_DESC_F_AVAIL;
bool used = flags & VIRTQ_DESC_F_USED;
-
- if (used != vq->used_wrap_count) {
+ if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
vq->driver_event.flags = RING_EVENT_FLAGS_ENABLE;
memory_barrier();
+ /*
+ * Re-test in case another thread submitted more descriptors
+ * and/or device used more descriptors before driver enabled events.
+ */
flags = d->flags;
+ bool avail = flags & VIRTQ_DESC_F_AVAIL;
bool used = flags & VIRTQ_DESC_F_USED;
- if (used != vq->used_wrap_count) {
+ if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
break;
}
--
2.17.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH v3] packed-ring: fix example code
2018-12-05 2:16 [virtio-dev] [PATCH v3] packed-ring: fix example code Tiwei Bie
@ 2018-12-05 14:04 ` Cornelia Huck
2018-12-05 15:03 ` Tiwei Bie
2018-12-05 15:14 ` Michael S. Tsirkin
1 sibling, 1 reply; 6+ messages in thread
From: Cornelia Huck @ 2018-12-05 14:04 UTC (permalink / raw)
To: Tiwei Bie; +Cc: virtio-dev, mst, stefanha
On Wed, 5 Dec 2018 10:16:51 +0800
Tiwei Bie <tiwei.bie@intel.com> wrote:
> Driver can't just check whether USED bit equals to the used
> wrap counter when checking whether a descriptor is a used
> descriptor, because driver also needs to check whether the
> descriptor has been made available. Below is an example:
>
> Assuming ring size is 4, ring's initial state will be:
>
> +----+----+----+----+
> | 00 | 00 | 00 | 00 |
> +----+----+----+----+
>
> 00 means AVAIL=0 USED=0, 01 means AVAIL=0 USED=1
> 10 means AVAIL=1 USED=0, 11 means AVAIL=1 USED=1
>
> After driver made two descriptor chains available and each
> chain consists of two descriptors, the ring could be:
>
> +----+-----------+----+-----------+
> | 10 | 10 (id=0) | 10 | 10 (id=1) |
> +----+-----------+----+-----------+
>
> After device processed all the available descriptors and made
> them used (e.g. in order), the ring could be:
>
> +-----------+----+-----------+----+
> | 11 (id=0) | 10 | 11 (id=1) | 10 |
> +-----------+----+-----------+----+
>
> After driver processed all the used descriptors and made
> one descriptor (not chained, just one descriptor) available,
> the ring could be:
>
> +-----------+----+----+----+
> | 01 (id=0) | 10 | 11 | 10 |
> +-----------+----+----+----+
>
> After device made that descriptor used, the ring will be:
>
> +-----------+----+----+----+
> | 00 (id=0) | 10 | 11 | 10 |
> +-----------+----+----+----+
>
> If driver just checks whether USED bit equals to the used
> wrap counter when checking whether a descriptor is a used
> descriptor, after processing the first descriptor (whose
> AVAIL and USED bits are both 0), and advancing vq->next_used
> pointer, it will then also treat the next descriptor, i.e.
> the second descriptor (whose AVAIL and USED bits are 1 and
> 0 respectively) as a used descriptor which is wrong.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> v2:
> - Add "Fixes" tag;
> - Refine commit log;
>
> v3:
> - Compare with vq->used_wrap_count (MST);
> - Add comments (MST);
> - Refine commit log;
>
> packed-ring.tex | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/packed-ring.tex b/packed-ring.tex
> index f24f49b..c8cd83b 100644
> --- a/packed-ring.tex
> +++ b/packed-ring.tex
> @@ -687,16 +687,29 @@ vq->driver_event.flags = RING_EVENT_FLAGS_DISABLE;
> for (;;) {
> struct pvirtq_desc *d = vq->desc[vq->next_used];
>
> + /*
> + * Check that
> + * 1. Descriptor has been made available.
> + * Note: there are many other ways to check this, e.g.
> + * track the number of outstanding available descriptors or buffers
> + * and check that it's not 0.
> + * 2. Descriptor has been used by device.
s/device/the device/
> + */
> flags = d->flags;
> + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> bool used = flags & VIRTQ_DESC_F_USED;
> -
> - if (used != vq->used_wrap_count) {
> + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> vq->driver_event.flags = RING_EVENT_FLAGS_ENABLE;
> memory_barrier();
>
> + /*
> + * Re-test in case another thread submitted more descriptors
> + * and/or device used more descriptors before driver enabled events.
s/device/the device/
s/driver/the driver/
(Also in the patch description.)
> + */
> flags = d->flags;
> + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> bool used = flags & VIRTQ_DESC_F_USED;
> - if (used != vq->used_wrap_count) {
> + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> break;
> }
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH v3] packed-ring: fix example code
2018-12-05 14:04 ` [virtio-dev] " Cornelia Huck
@ 2018-12-05 15:03 ` Tiwei Bie
2018-12-05 15:18 ` Michael S. Tsirkin
0 siblings, 1 reply; 6+ messages in thread
From: Tiwei Bie @ 2018-12-05 15:03 UTC (permalink / raw)
To: Cornelia Huck; +Cc: virtio-dev, mst, stefanha
On Wed, Dec 05, 2018 at 03:04:08PM +0100, Cornelia Huck wrote:
> On Wed, 5 Dec 2018 10:16:51 +0800
> Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> > Driver can't just check whether USED bit equals to the used
> > wrap counter when checking whether a descriptor is a used
> > descriptor, because driver also needs to check whether the
> > descriptor has been made available. Below is an example:
> >
> > Assuming ring size is 4, ring's initial state will be:
> >
> > +----+----+----+----+
> > | 00 | 00 | 00 | 00 |
> > +----+----+----+----+
> >
> > 00 means AVAIL=0 USED=0, 01 means AVAIL=0 USED=1
> > 10 means AVAIL=1 USED=0, 11 means AVAIL=1 USED=1
> >
> > After driver made two descriptor chains available and each
> > chain consists of two descriptors, the ring could be:
> >
> > +----+-----------+----+-----------+
> > | 10 | 10 (id=0) | 10 | 10 (id=1) |
> > +----+-----------+----+-----------+
> >
> > After device processed all the available descriptors and made
> > them used (e.g. in order), the ring could be:
> >
> > +-----------+----+-----------+----+
> > | 11 (id=0) | 10 | 11 (id=1) | 10 |
> > +-----------+----+-----------+----+
> >
> > After driver processed all the used descriptors and made
> > one descriptor (not chained, just one descriptor) available,
> > the ring could be:
> >
> > +-----------+----+----+----+
> > | 01 (id=0) | 10 | 11 | 10 |
> > +-----------+----+----+----+
> >
> > After device made that descriptor used, the ring will be:
> >
> > +-----------+----+----+----+
> > | 00 (id=0) | 10 | 11 | 10 |
> > +-----------+----+----+----+
> >
> > If driver just checks whether USED bit equals to the used
> > wrap counter when checking whether a descriptor is a used
> > descriptor, after processing the first descriptor (whose
> > AVAIL and USED bits are both 0), and advancing vq->next_used
> > pointer, it will then also treat the next descriptor, i.e.
> > the second descriptor (whose AVAIL and USED bits are 1 and
> > 0 respectively) as a used descriptor which is wrong.
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> > v2:
> > - Add "Fixes" tag;
> > - Refine commit log;
> >
> > v3:
> > - Compare with vq->used_wrap_count (MST);
> > - Add comments (MST);
> > - Refine commit log;
> >
> > packed-ring.tex | 19 ++++++++++++++++---
> > 1 file changed, 16 insertions(+), 3 deletions(-)
> >
> > diff --git a/packed-ring.tex b/packed-ring.tex
> > index f24f49b..c8cd83b 100644
> > --- a/packed-ring.tex
> > +++ b/packed-ring.tex
> > @@ -687,16 +687,29 @@ vq->driver_event.flags = RING_EVENT_FLAGS_DISABLE;
> > for (;;) {
> > struct pvirtq_desc *d = vq->desc[vq->next_used];
> >
> > + /*
> > + * Check that
> > + * 1. Descriptor has been made available.
> > + * Note: there are many other ways to check this, e.g.
> > + * track the number of outstanding available descriptors or buffers
> > + * and check that it's not 0.
> > + * 2. Descriptor has been used by device.
>
> s/device/the device/
>
> > + */
> > flags = d->flags;
> > + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> > bool used = flags & VIRTQ_DESC_F_USED;
> > -
> > - if (used != vq->used_wrap_count) {
> > + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> > vq->driver_event.flags = RING_EVENT_FLAGS_ENABLE;
> > memory_barrier();
> >
> > + /*
> > + * Re-test in case another thread submitted more descriptors
> > + * and/or device used more descriptors before driver enabled events.
>
> s/device/the device/
> s/driver/the driver/
>
> (Also in the patch description.)
Got it. Will fix them in the next version. Thanks!
>
> > + */
> > flags = d->flags;
> > + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> > bool used = flags & VIRTQ_DESC_F_USED;
> > - if (used != vq->used_wrap_count) {
> > + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> > break;
> > }
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH v3] packed-ring: fix example code
2018-12-05 15:03 ` Tiwei Bie
@ 2018-12-05 15:18 ` Michael S. Tsirkin
2018-12-05 15:45 ` Tiwei Bie
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2018-12-05 15:18 UTC (permalink / raw)
To: Tiwei Bie; +Cc: Cornelia Huck, virtio-dev, stefanha
On Wed, Dec 05, 2018 at 11:03:33PM +0800, Tiwei Bie wrote:
> On Wed, Dec 05, 2018 at 03:04:08PM +0100, Cornelia Huck wrote:
> > On Wed, 5 Dec 2018 10:16:51 +0800
> > Tiwei Bie <tiwei.bie@intel.com> wrote:
> >
> > > Driver can't just check whether USED bit equals to the used
> > > wrap counter when checking whether a descriptor is a used
> > > descriptor, because driver also needs to check whether the
> > > descriptor has been made available. Below is an example:
> > >
> > > Assuming ring size is 4, ring's initial state will be:
> > >
> > > +----+----+----+----+
> > > | 00 | 00 | 00 | 00 |
> > > +----+----+----+----+
> > >
> > > 00 means AVAIL=0 USED=0, 01 means AVAIL=0 USED=1
> > > 10 means AVAIL=1 USED=0, 11 means AVAIL=1 USED=1
> > >
> > > After driver made two descriptor chains available and each
> > > chain consists of two descriptors, the ring could be:
> > >
> > > +----+-----------+----+-----------+
> > > | 10 | 10 (id=0) | 10 | 10 (id=1) |
> > > +----+-----------+----+-----------+
> > >
> > > After device processed all the available descriptors and made
> > > them used (e.g. in order), the ring could be:
> > >
> > > +-----------+----+-----------+----+
> > > | 11 (id=0) | 10 | 11 (id=1) | 10 |
> > > +-----------+----+-----------+----+
> > >
> > > After driver processed all the used descriptors and made
> > > one descriptor (not chained, just one descriptor) available,
> > > the ring could be:
> > >
> > > +-----------+----+----+----+
> > > | 01 (id=0) | 10 | 11 | 10 |
> > > +-----------+----+----+----+
> > >
> > > After device made that descriptor used, the ring will be:
> > >
> > > +-----------+----+----+----+
> > > | 00 (id=0) | 10 | 11 | 10 |
> > > +-----------+----+----+----+
> > >
> > > If driver just checks whether USED bit equals to the used
> > > wrap counter when checking whether a descriptor is a used
> > > descriptor, after processing the first descriptor (whose
> > > AVAIL and USED bits are both 0), and advancing vq->next_used
> > > pointer, it will then also treat the next descriptor, i.e.
> > > the second descriptor (whose AVAIL and USED bits are 1 and
> > > 0 respectively) as a used descriptor which is wrong.
> > >
> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > > ---
> > > v2:
> > > - Add "Fixes" tag;
> > > - Refine commit log;
> > >
> > > v3:
> > > - Compare with vq->used_wrap_count (MST);
> > > - Add comments (MST);
> > > - Refine commit log;
> > >
> > > packed-ring.tex | 19 ++++++++++++++++---
> > > 1 file changed, 16 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/packed-ring.tex b/packed-ring.tex
> > > index f24f49b..c8cd83b 100644
> > > --- a/packed-ring.tex
> > > +++ b/packed-ring.tex
> > > @@ -687,16 +687,29 @@ vq->driver_event.flags = RING_EVENT_FLAGS_DISABLE;
> > > for (;;) {
> > > struct pvirtq_desc *d = vq->desc[vq->next_used];
> > >
> > > + /*
> > > + * Check that
> > > + * 1. Descriptor has been made available.
> > > + * Note: there are many other ways to check this, e.g.
> > > + * track the number of outstanding available descriptors or buffers
> > > + * and check that it's not 0.
> > > + * 2. Descriptor has been used by device.
> >
> > s/device/the device/
> >
> > > + */
> > > flags = d->flags;
> > > + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> > > bool used = flags & VIRTQ_DESC_F_USED;
> > > -
> > > - if (used != vq->used_wrap_count) {
> > > + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> > > vq->driver_event.flags = RING_EVENT_FLAGS_ENABLE;
> > > memory_barrier();
> > >
> > > + /*
> > > + * Re-test in case another thread submitted more descriptors
> > > + * and/or device used more descriptors before driver enabled events.
> >
> > s/device/the device/
> > s/driver/the driver/
> >
> > (Also in the patch description.)
>
> Got it. Will fix them in the next version. Thanks!
And it's fine to mention threads but we really should also write it in
terms of driver/device, used/available and parallel processing. E.g.
* Re-test in case the driver made more descriptors available in
* parallel with the used descriptor processing (e.g. from another
* thread) and/or the device used more descriptors before the driver
* enabled events.
> >
> > > + */
> > > flags = d->flags;
> > > + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> > > bool used = flags & VIRTQ_DESC_F_USED;
> > > - if (used != vq->used_wrap_count) {
> > > + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> > > break;
> > > }
> > >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH v3] packed-ring: fix example code
2018-12-05 15:18 ` Michael S. Tsirkin
@ 2018-12-05 15:45 ` Tiwei Bie
0 siblings, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-12-05 15:45 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Cornelia Huck, virtio-dev, stefanha
On Wed, Dec 05, 2018 at 10:18:32AM -0500, Michael S. Tsirkin wrote:
> On Wed, Dec 05, 2018 at 11:03:33PM +0800, Tiwei Bie wrote:
> > On Wed, Dec 05, 2018 at 03:04:08PM +0100, Cornelia Huck wrote:
> > > On Wed, 5 Dec 2018 10:16:51 +0800
> > > Tiwei Bie <tiwei.bie@intel.com> wrote:
> > >
> > > > Driver can't just check whether USED bit equals to the used
> > > > wrap counter when checking whether a descriptor is a used
> > > > descriptor, because driver also needs to check whether the
> > > > descriptor has been made available. Below is an example:
> > > >
> > > > Assuming ring size is 4, ring's initial state will be:
> > > >
> > > > +----+----+----+----+
> > > > | 00 | 00 | 00 | 00 |
> > > > +----+----+----+----+
> > > >
> > > > 00 means AVAIL=0 USED=0, 01 means AVAIL=0 USED=1
> > > > 10 means AVAIL=1 USED=0, 11 means AVAIL=1 USED=1
> > > >
> > > > After driver made two descriptor chains available and each
> > > > chain consists of two descriptors, the ring could be:
> > > >
> > > > +----+-----------+----+-----------+
> > > > | 10 | 10 (id=0) | 10 | 10 (id=1) |
> > > > +----+-----------+----+-----------+
> > > >
> > > > After device processed all the available descriptors and made
> > > > them used (e.g. in order), the ring could be:
> > > >
> > > > +-----------+----+-----------+----+
> > > > | 11 (id=0) | 10 | 11 (id=1) | 10 |
> > > > +-----------+----+-----------+----+
> > > >
> > > > After driver processed all the used descriptors and made
> > > > one descriptor (not chained, just one descriptor) available,
> > > > the ring could be:
> > > >
> > > > +-----------+----+----+----+
> > > > | 01 (id=0) | 10 | 11 | 10 |
> > > > +-----------+----+----+----+
> > > >
> > > > After device made that descriptor used, the ring will be:
> > > >
> > > > +-----------+----+----+----+
> > > > | 00 (id=0) | 10 | 11 | 10 |
> > > > +-----------+----+----+----+
> > > >
> > > > If driver just checks whether USED bit equals to the used
> > > > wrap counter when checking whether a descriptor is a used
> > > > descriptor, after processing the first descriptor (whose
> > > > AVAIL and USED bits are both 0), and advancing vq->next_used
> > > > pointer, it will then also treat the next descriptor, i.e.
> > > > the second descriptor (whose AVAIL and USED bits are 1 and
> > > > 0 respectively) as a used descriptor which is wrong.
> > > >
> > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29
> > > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > > > ---
> > > > v2:
> > > > - Add "Fixes" tag;
> > > > - Refine commit log;
> > > >
> > > > v3:
> > > > - Compare with vq->used_wrap_count (MST);
> > > > - Add comments (MST);
> > > > - Refine commit log;
> > > >
> > > > packed-ring.tex | 19 ++++++++++++++++---
> > > > 1 file changed, 16 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/packed-ring.tex b/packed-ring.tex
> > > > index f24f49b..c8cd83b 100644
> > > > --- a/packed-ring.tex
> > > > +++ b/packed-ring.tex
> > > > @@ -687,16 +687,29 @@ vq->driver_event.flags = RING_EVENT_FLAGS_DISABLE;
> > > > for (;;) {
> > > > struct pvirtq_desc *d = vq->desc[vq->next_used];
> > > >
> > > > + /*
> > > > + * Check that
> > > > + * 1. Descriptor has been made available.
> > > > + * Note: there are many other ways to check this, e.g.
> > > > + * track the number of outstanding available descriptors or buffers
> > > > + * and check that it's not 0.
> > > > + * 2. Descriptor has been used by device.
> > >
> > > s/device/the device/
> > >
> > > > + */
> > > > flags = d->flags;
> > > > + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> > > > bool used = flags & VIRTQ_DESC_F_USED;
> > > > -
> > > > - if (used != vq->used_wrap_count) {
> > > > + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> > > > vq->driver_event.flags = RING_EVENT_FLAGS_ENABLE;
> > > > memory_barrier();
> > > >
> > > > + /*
> > > > + * Re-test in case another thread submitted more descriptors
> > > > + * and/or device used more descriptors before driver enabled events.
> > >
> > > s/device/the device/
> > > s/driver/the driver/
> > >
> > > (Also in the patch description.)
> >
> > Got it. Will fix them in the next version. Thanks!
>
> And it's fine to mention threads but we really should also write it in
> terms of driver/device, used/available and parallel processing. E.g.
>
> * Re-test in case the driver made more descriptors available in
> * parallel with the used descriptor processing (e.g. from another
> * thread) and/or the device used more descriptors before the driver
> * enabled events.
Got it. Thanks!
>
>
>
> > >
> > > > + */
> > > > flags = d->flags;
> > > > + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> > > > bool used = flags & VIRTQ_DESC_F_USED;
> > > > - if (used != vq->used_wrap_count) {
> > > > + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> > > > break;
> > > > }
> > > >
> > >
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [virtio-dev] Re: [PATCH v3] packed-ring: fix example code
2018-12-05 2:16 [virtio-dev] [PATCH v3] packed-ring: fix example code Tiwei Bie
2018-12-05 14:04 ` [virtio-dev] " Cornelia Huck
@ 2018-12-05 15:14 ` Michael S. Tsirkin
1 sibling, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2018-12-05 15:14 UTC (permalink / raw)
To: Tiwei Bie; +Cc: virtio-dev, cohuck, stefanha
I'd add to the commit log:
When driver is processing used descriptors in parallel
with adding new available descriptors ...
and then as described.
On Wed, Dec 05, 2018 at 10:16:51AM +0800, Tiwei Bie wrote:
> Driver can't just check whether USED bit equals to the used
> wrap counter when checking whether a descriptor is a used
> descriptor, because driver also needs to check whether the
> descriptor has been made available.
> Below is an example:
>
> Assuming ring size is 4, ring's initial state will be:
>
> +----+----+----+----+
> | 00 | 00 | 00 | 00 |
> +----+----+----+----+
>
> 00 means AVAIL=0 USED=0, 01 means AVAIL=0 USED=1
> 10 means AVAIL=1 USED=0, 11 means AVAIL=1 USED=1
>
> After driver made two descriptor chains available and each
> chain consists of two descriptors, the ring could be:
>
> +----+-----------+----+-----------+
> | 10 | 10 (id=0) | 10 | 10 (id=1) |
> +----+-----------+----+-----------+
>
> After device processed all the available descriptors and made
> them used (e.g. in order), the ring could be:
>
> +-----------+----+-----------+----+
> | 11 (id=0) | 10 | 11 (id=1) | 10 |
> +-----------+----+-----------+----+
>
> After driver processed all the used descriptors and made
> one descriptor (not chained, just one descriptor) available,
> the ring could be:
>
> +-----------+----+----+----+
> | 01 (id=0) | 10 | 11 | 10 |
> +-----------+----+----+----+
>
> After device made that descriptor used, the ring will be:
>
> +-----------+----+----+----+
> | 00 (id=0) | 10 | 11 | 10 |
> +-----------+----+----+----+
>
> If driver just checks whether USED bit equals to the used
> wrap counter when checking whether a descriptor is a used
> descriptor, after processing the first descriptor (whose
> AVAIL and USED bits are both 0), and advancing vq->next_used
> pointer, it will then also treat the next descriptor, i.e.
> the second descriptor (whose AVAIL and USED bits are 1 and
> 0 respectively) as a used descriptor which is wrong.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/29
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> v2:
> - Add "Fixes" tag;
> - Refine commit log;
>
> v3:
> - Compare with vq->used_wrap_count (MST);
> - Add comments (MST);
> - Refine commit log;
>
> packed-ring.tex | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/packed-ring.tex b/packed-ring.tex
> index f24f49b..c8cd83b 100644
> --- a/packed-ring.tex
> +++ b/packed-ring.tex
> @@ -687,16 +687,29 @@ vq->driver_event.flags = RING_EVENT_FLAGS_DISABLE;
> for (;;) {
> struct pvirtq_desc *d = vq->desc[vq->next_used];
>
> + /*
> + * Check that
> + * 1. Descriptor has been made available.
Maybe here as well, we can say
... this check is necessary if driver is making
new descriptors available in parallel with this
processing of used descriptors (e.g. from another thread).
> + * Note: there are many other ways to check this, e.g.
> + * track the number of outstanding available descriptors or buffers
> + * and check that it's not 0.
> + * 2. Descriptor has been used by device.
> + */
> flags = d->flags;
> + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> bool used = flags & VIRTQ_DESC_F_USED;
> -
> - if (used != vq->used_wrap_count) {
> + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> vq->driver_event.flags = RING_EVENT_FLAGS_ENABLE;
> memory_barrier();
>
> + /*
> + * Re-test in case another thread submitted more descriptors
> + * and/or device used more descriptors before driver enabled events.
> + */
> flags = d->flags;
> + bool avail = flags & VIRTQ_DESC_F_AVAIL;
> bool used = flags & VIRTQ_DESC_F_USED;
> - if (used != vq->used_wrap_count) {
> + if (avail != vq->used_wrap_count || used != vq->used_wrap_count) {
> break;
> }
>
> --
> 2.17.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-05 15:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-05 2:16 [virtio-dev] [PATCH v3] packed-ring: fix example code Tiwei Bie
2018-12-05 14:04 ` [virtio-dev] " Cornelia Huck
2018-12-05 15:03 ` Tiwei Bie
2018-12-05 15:18 ` Michael S. Tsirkin
2018-12-05 15:45 ` Tiwei Bie
2018-12-05 15:14 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.