From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org,
Russell Currey <ruscur@russell.cc>,
Sam Bobroff <sbobroff@linux.ibm.com>,
oohall@gmail.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
jroedel@suse.de, Mathias Nyman <mathias.nyman@intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
dmaengine@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [1/6] driver core: Introduce device_iommu_mapped() function
Date: Wed, 12 Dec 2018 12:04:35 +0100 [thread overview]
Message-ID: <20181212110435.GC1990@kroah.com> (raw)
On Tue, Dec 11, 2018 at 02:43:38PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Some places in the kernel check the iommu_group pointer in
> 'struct device' in order to find ot whether a device is
> mapped by an IOMMU.
>
> This is not good way to make this check, as the pointer will
> be moved to 'struct dev_iommu_data'. This way to make the
> check is also not very readable.
>
> Introduce an explicit function to perform this check.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
No need to have a cc: line if I have already acked it :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org,
Russell Currey <ruscur@russell.cc>,
Sam Bobroff <sbobroff@linux.ibm.com>,
oohall@gmail.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
jroedel@suse.de, Mathias Nyman <mathias.nyman@intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
dmaengine@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/6] driver core: Introduce device_iommu_mapped() function
Date: Wed, 12 Dec 2018 12:04:35 +0100 [thread overview]
Message-ID: <20181212110435.GC1990@kroah.com> (raw)
In-Reply-To: <20181211134343.10664-2-joro@8bytes.org>
On Tue, Dec 11, 2018 at 02:43:38PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Some places in the kernel check the iommu_group pointer in
> 'struct device' in order to find ot whether a device is
> mapped by an IOMMU.
>
> This is not good way to make this check, as the pointer will
> be moved to 'struct dev_iommu_data'. This way to make the
> check is also not very readable.
>
> Introduce an explicit function to perform this check.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
No need to have a cc: line if I have already acked it :)
thanks,
greg k-h
next reply other threads:[~2018-12-12 11:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 11:04 Greg Kroah-Hartman [this message]
2018-12-12 11:04 ` [PATCH 1/6] driver core: Introduce device_iommu_mapped() function Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2018-12-17 11:21 [5/6] xhci: Use device_iommu_mapped() Mathias Nyman
2018-12-17 11:21 ` [PATCH 5/6] " Mathias Nyman
2018-12-17 11:21 ` Mathias Nyman
2018-12-17 9:31 [1/6] driver core: Introduce device_iommu_mapped() function Joerg Roedel
2018-12-17 9:31 ` [PATCH 1/6] " Joerg Roedel
2018-12-17 9:31 ` Joerg Roedel
2018-12-17 9:21 [3/6] ACPI/IORT: Use device_iommu_mapped() Hanjun Guo
2018-12-17 9:21 ` [PATCH 3/6] " Hanjun Guo
2018-12-17 9:21 ` Hanjun Guo
2018-12-17 6:11 [6/6] dmaengine: sh: rcar-dmac: " Vinod Koul
2018-12-17 6:11 ` [PATCH 6/6] " Vinod Koul
2018-12-17 6:11 [1/6] driver core: Introduce device_iommu_mapped() function Vinod Koul
2018-12-17 6:11 ` [PATCH 1/6] " Vinod Koul
2018-12-12 11:07 [1/6] " Joerg Roedel
2018-12-12 11:07 ` [PATCH 1/6] " Joerg Roedel
2018-12-11 15:18 [1/6] " Joerg Roedel
2018-12-11 15:18 ` [PATCH 1/6] " Joerg Roedel
2018-12-11 15:18 ` Joerg Roedel
2018-12-11 14:59 [1/6] " Sergei Shtylyov
2018-12-11 14:59 ` [PATCH 1/6] " Sergei Shtylyov
2018-12-11 14:59 ` Sergei Shtylyov
2018-12-11 13:43 [6/6] dmaengine: sh: rcar-dmac: Use device_iommu_mapped() Joerg Roedel
2018-12-11 13:43 ` [PATCH 6/6] " Joerg Roedel
2018-12-11 13:43 [5/6] xhci: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 5/6] " Joerg Roedel
2018-12-11 13:43 [4/6] powerpc/iommu: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 4/6] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
2018-12-11 13:43 [3/6] ACPI/IORT: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 3/6] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
2018-12-11 13:43 [2/6] iommu/of: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 2/6] " Joerg Roedel
2018-12-11 13:43 [1/6] driver core: Introduce device_iommu_mapped() function Joerg Roedel
2018-12-11 13:43 ` [PATCH 1/6] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
2018-12-11 13:43 [PATCH 0/6 v2] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212110435.GC1990@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=hanjun.guo@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@intel.com \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
--cc=sbobroff@linux.ibm.com \
--cc=sudeep.holla@arm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.