From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org
Cc: Russell Currey <ruscur@russell.cc>,
Sam Bobroff <sbobroff@linux.ibm.com>,
oohall@gmail.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
jroedel@suse.de, Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
dmaengine@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [5/6] xhci: Use device_iommu_mapped()
Date: Mon, 17 Dec 2018 13:21:43 +0200 [thread overview]
Message-ID: <3d5b3bb3-b119-7798-4c26-910782ef1bdf@linux.intel.com> (raw)
On 11.12.2018 15:43, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Replace the dev->iommu_group check with a proper function
> call that better reprensents its purpose.
>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index dae3be1b9c8f..8eacd2ed412b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -244,7 +244,7 @@ static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
> * an iommu. Doing anything when there is no iommu is definitely
> * unsafe...
> */
> - if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !dev->iommu_group)
> + if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !device_iommu_mapped(dev))
> return;
>
> xhci_info(xhci, "Zeroing 64bit base registers, expecting fault\n");
>
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mathias Nyman <mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Sam Bobroff <sbobroff-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Russell Currey <ruscur-3Su/lFKaw5ejKv3TNrM5DQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vinod Koul <vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
jroedel-l3A5Bk7waGM@public.gmane.org,
oohall-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/6] xhci: Use device_iommu_mapped()
Date: Mon, 17 Dec 2018 13:21:43 +0200 [thread overview]
Message-ID: <3d5b3bb3-b119-7798-4c26-910782ef1bdf@linux.intel.com> (raw)
In-Reply-To: <20181211134343.10664-6-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On 11.12.2018 15:43, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
>
> Replace the dev->iommu_group check with a proper function
> call that better reprensents its purpose.
>
> Cc: Mathias Nyman <mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Acked-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> Signed-off-by: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index dae3be1b9c8f..8eacd2ed412b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -244,7 +244,7 @@ static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
> * an iommu. Doing anything when there is no iommu is definitely
> * unsafe...
> */
> - if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !dev->iommu_group)
> + if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !device_iommu_mapped(dev))
> return;
>
> xhci_info(xhci, "Zeroing 64bit base registers, expecting fault\n");
>
Acked-by: Mathias Nyman <mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org
Cc: Russell Currey <ruscur@russell.cc>,
Sam Bobroff <sbobroff@linux.ibm.com>,
oohall@gmail.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
jroedel@suse.de, Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
dmaengine@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 5/6] xhci: Use device_iommu_mapped()
Date: Mon, 17 Dec 2018 13:21:43 +0200 [thread overview]
Message-ID: <3d5b3bb3-b119-7798-4c26-910782ef1bdf@linux.intel.com> (raw)
In-Reply-To: <20181211134343.10664-6-joro@8bytes.org>
On 11.12.2018 15:43, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Replace the dev->iommu_group check with a proper function
> call that better reprensents its purpose.
>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index dae3be1b9c8f..8eacd2ed412b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -244,7 +244,7 @@ static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
> * an iommu. Doing anything when there is no iommu is definitely
> * unsafe...
> */
> - if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !dev->iommu_group)
> + if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !device_iommu_mapped(dev))
> return;
>
> xhci_info(xhci, "Zeroing 64bit base registers, expecting fault\n");
>
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
next reply other threads:[~2018-12-17 11:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 11:21 Mathias Nyman [this message]
2018-12-17 11:21 ` [PATCH 5/6] xhci: Use device_iommu_mapped() Mathias Nyman
2018-12-17 11:21 ` Mathias Nyman
-- strict thread matches above, loose matches on Subject: below --
2018-12-17 9:31 [1/6] driver core: Introduce device_iommu_mapped() function Joerg Roedel
2018-12-17 9:31 ` [PATCH 1/6] " Joerg Roedel
2018-12-17 9:31 ` Joerg Roedel
2018-12-17 9:21 [3/6] ACPI/IORT: Use device_iommu_mapped() Hanjun Guo
2018-12-17 9:21 ` [PATCH 3/6] " Hanjun Guo
2018-12-17 9:21 ` Hanjun Guo
2018-12-17 6:11 [6/6] dmaengine: sh: rcar-dmac: " Vinod Koul
2018-12-17 6:11 ` [PATCH 6/6] " Vinod Koul
2018-12-17 6:11 [1/6] driver core: Introduce device_iommu_mapped() function Vinod Koul
2018-12-17 6:11 ` [PATCH 1/6] " Vinod Koul
2018-12-12 11:07 [1/6] " Joerg Roedel
2018-12-12 11:07 ` [PATCH 1/6] " Joerg Roedel
2018-12-12 11:04 [1/6] " Greg Kroah-Hartman
2018-12-12 11:04 ` [PATCH 1/6] " Greg Kroah-Hartman
2018-12-11 15:18 [1/6] " Joerg Roedel
2018-12-11 15:18 ` [PATCH 1/6] " Joerg Roedel
2018-12-11 15:18 ` Joerg Roedel
2018-12-11 14:59 [1/6] " Sergei Shtylyov
2018-12-11 14:59 ` [PATCH 1/6] " Sergei Shtylyov
2018-12-11 14:59 ` Sergei Shtylyov
2018-12-11 13:43 [6/6] dmaengine: sh: rcar-dmac: Use device_iommu_mapped() Joerg Roedel
2018-12-11 13:43 ` [PATCH 6/6] " Joerg Roedel
2018-12-11 13:43 [5/6] xhci: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 5/6] " Joerg Roedel
2018-12-11 13:43 [4/6] powerpc/iommu: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 4/6] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
2018-12-11 13:43 [3/6] ACPI/IORT: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 3/6] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
2018-12-11 13:43 [2/6] iommu/of: " Joerg Roedel
2018-12-11 13:43 ` [PATCH 2/6] " Joerg Roedel
2018-12-11 13:43 [1/6] driver core: Introduce device_iommu_mapped() function Joerg Roedel
2018-12-11 13:43 ` [PATCH 1/6] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
2018-12-11 13:43 [PATCH 0/6 v2] " Joerg Roedel
2018-12-11 13:43 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d5b3bb3-b119-7798-4c26-910782ef1bdf@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@intel.com \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
--cc=sbobroff@linux.ibm.com \
--cc=sudeep.holla@arm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.