From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Hui Peng <benquike@gmail.com>,
Mathias Payer <mathias.payer@nebelwelt.net>
Subject: [v2] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data
Date: Wed, 12 Dec 2018 12:40:24 +0100 [thread overview]
Message-ID: <20181212114024.GA26559@kroah.com> (raw)
On Mon, Dec 10, 2018 at 01:50:20PM +0100, Sebastian Andrzej Siewior wrote:
> On 2018-12-10 09:04:43 [+0100], Greg KH wrote:
> > From: Hui Peng <benquike@gmail.com>
> >
> > The function hso_probe reads if_num from the USB device (as an u8) and uses
> > it without a length check to index an array, resulting in an OOB memory read
> > in hso_probe or hso_get_config_data. Added a length check for both locations
> > and updated hso_probe to bail on error.
>
> The function hso_probe reads if_num from the USB device (as an u8) and uses
> it without a length check to index an array, resulting in an OOB memory read
> in hso_probe or hso_get_config_data.
>
> Add a length check for both locations and update hso_probe to bail on
> error.
>
> > This issue has been assigned CVE-2018-19985.
> >
> > Reported-by: Hui Peng <benquike@gmail.com>
> > Reported-by: Mathias Payer <mathias.payer@nebelwelt.net>
> > Signed-off-by: Hui Peng <benquike@gmail.com>
> > Signed-off-by: Mathias Payer <mathias.payer@nebelwelt.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Thanks, will update the changelog and add resend.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Hui Peng <benquike@gmail.com>,
Mathias Payer <mathias.payer@nebelwelt.net>
Subject: Re: [PATCH v2] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data
Date: Wed, 12 Dec 2018 12:40:24 +0100 [thread overview]
Message-ID: <20181212114024.GA26559@kroah.com> (raw)
In-Reply-To: <20181210125020.64nybfkrotjun7rw@linutronix.de>
On Mon, Dec 10, 2018 at 01:50:20PM +0100, Sebastian Andrzej Siewior wrote:
> On 2018-12-10 09:04:43 [+0100], Greg KH wrote:
> > From: Hui Peng <benquike@gmail.com>
> >
> > The function hso_probe reads if_num from the USB device (as an u8) and uses
> > it without a length check to index an array, resulting in an OOB memory read
> > in hso_probe or hso_get_config_data. Added a length check for both locations
> > and updated hso_probe to bail on error.
>
> The function hso_probe reads if_num from the USB device (as an u8) and uses
> it without a length check to index an array, resulting in an OOB memory read
> in hso_probe or hso_get_config_data.
>
> Add a length check for both locations and update hso_probe to bail on
> error.
>
> > This issue has been assigned CVE-2018-19985.
> >
> > Reported-by: Hui Peng <benquike@gmail.com>
> > Reported-by: Mathias Payer <mathias.payer@nebelwelt.net>
> > Signed-off-by: Hui Peng <benquike@gmail.com>
> > Signed-off-by: Mathias Payer <mathias.payer@nebelwelt.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Thanks, will update the changelog and add resend.
greg k-h
next reply other threads:[~2018-12-12 11:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 11:40 Greg Kroah-Hartman [this message]
2018-12-12 11:40 ` [PATCH v2] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data Greg KH
-- strict thread matches above, loose matches on Subject: below --
2018-12-12 23:41 [v3] " David Miller
2018-12-12 23:41 ` [PATCH v3] " David Miller
2018-12-12 11:42 [v3] " Greg Kroah-Hartman
2018-12-12 11:42 ` [PATCH v3] " Greg KH
2018-12-10 12:50 [v2] " Sebastian Andrzej Siewior
2018-12-10 12:50 ` [PATCH v2] " Sebastian Andrzej Siewior
2018-12-10 8:04 [v2] " Greg Kroah-Hartman
2018-12-10 8:04 ` [PATCH v2] " Greg KH
2018-12-10 7:18 USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] " Greg Kroah-Hartman
2018-12-10 7:18 ` [PATCH] " Greg KH
2018-12-09 20:59 USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory Mathias Payer
2018-12-09 20:59 ` [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data Mathias Payer
2018-12-09 20:40 David Miller
2018-12-09 20:40 ` [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] " David Miller
2018-12-09 20:17 Mathias Payer
2018-12-09 20:17 ` [PATCH] " Mathias Payer
2018-12-09 20:06 David Miller
2018-12-09 20:06 ` [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] " David Miller
2018-12-09 20:04 Mathias Payer
2018-12-09 20:04 ` [PATCH] " Mathias Payer
2018-12-09 20:02 Mathias Payer
2018-12-09 20:02 ` [PATCH] " Mathias Payer
2018-12-09 19:54 David Miller
2018-12-09 19:54 ` [PATCH] " David Miller
2018-12-09 16:32 Greg Kroah-Hartman
2018-12-09 16:32 ` [PATCH] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212114024.GA26559@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benquike@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.payer@nebelwelt.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.