All of lore.kernel.org
 help / color / mirror / Atom feed
* [rocko/master][PATCH v2] tidl-utils: add TIDL import tool source compilation.
@ 2018-12-11 21:54 Jianzhong Xu
  2018-12-12 21:11 ` Denys Dmytriyenko
  0 siblings, 1 reply; 3+ messages in thread
From: Jianzhong Xu @ 2018-12-11 21:54 UTC (permalink / raw)
  To: meta-arago

Signed-off-by: Jianzhong Xu <xuj@ti.com>
---
 .../nativesdk-packagegroup-arago-sdk-host.bb       |  1 +
 .../recipes-ti/tidl-utils/tidl-import_git.bb       | 43 ++++++++++++++++++++++
 .../recipes-ti/tidl-utils/tidl-utils.bb            |  7 ++--
 .../recipes-ti/tidl-utils/tidl-utils.inc           |  2 +
 4 files changed, 49 insertions(+), 4 deletions(-)
 create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
 create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc

diff --git a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
index 54466b7..af83521 100644
--- a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
+++ b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
@@ -13,6 +13,7 @@ EXTRA_TI_TOOLS = " \
     nativesdk-clacc \
     nativesdk-open62541-examples \
     nativesdk-open62541-tests \
+    nativesdk-tidl-import \
 "
 
 RDEPENDS_${PN} = "\
diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
new file mode 100644
index 0000000..a644fbe
--- /dev/null
+++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
@@ -0,0 +1,43 @@
+SUMMARY = " TIDL import tool for conversion of Caffe and TF models into TI custom network format "
+DESCRIPTION = "TIDL import tool is using protobuf to read and parse information from external network models \
+               This is ARM Linux implementation."
+
+require ./tidl-utils.inc
+
+LICENSE = "BSD-3"
+LIC_FILES_CHKSUM = "file://modules/ti_dl/inc/itidl_ti.h;md5=7baa68fec0aadbac92c3b41b283d26c4"
+
+PV = "01.00.00.00"
+PR = "r1"
+
+S = "${WORKDIR}/git/src/importTool/"
+
+DEPENDS="protobuf zlib protobuf-native"
+
+EXTRA_OEMAKE += "TIARM_TOOLS=${GCC_ARM_NONE_TOOLCHAIN}"
+EXTRA_OEMAKE += "XDAIS_PATH=${XDAIS_INSTALL_DIR}"
+EXTRA_OEMAKE += "SHOW_COMMANDS=1"
+EXTRA_OEMAKE += "CORE=eve"
+EXTRA_OEMAKE += "TARGET_BUILD=release"
+EXTRA_OEMAKE += "TARGET_PLATFORM=PC"
+
+EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUX_IMPORT_TOOL=64BIT PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include"
+EXTRA_MAKE_ARGS_class-target = "LINUX_BUILD_TOOLS=${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX} PROTOBUF_LIB_DIR=${STAGING_LIBDIR} PROTOBUF_INC_DIR=${STAGING_INCDIR} LINUXENV=oearm"
+
+EXTRA_OEMAKE += "${EXTRA_MAKE_ARGS}"
+
+do_compile() {
+    cd ${S}/modules/ti_dl/utils
+    ./genProtoSrc.sh
+    cd ${S}
+    oe_runmake -C modules/ti_dl/utils/tidlModelImport
+}
+
+do_install () {
+    install -d ${D}${bindir}
+    install -m 755 ${S}/modules/ti_dl/utils/tidlModelImport/out/tidl_model_import.out ${D}${bindir}
+}
+
+INSANE_SKIP_${PN} = "ldflags"
+
+BBCLASSEXTEND="native nativesdk"
diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
index 569de5a..575a0a0 100644
--- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
+++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
@@ -3,16 +3,15 @@ DESCRIPTION = "TIDL Utilities for standalone simulation and importing / translat
 HOMEPAGE = "http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components.html#tidl"
 LICENSE = "TI-TFL"
 
-PV = "1.0.0.0"
+require ./tidl-utils.inc
+
+PV = "1.0.0.1"
 INC_PR = "r0"
 
 LIC_FILES_CHKSUM = "file://docs/LICENSE.txt;md5=a93aa5af7a3bbbb6fb34c8df59efaa5c"
 
 RDEPENDS_${PN}_class-target += " tidl-api tidl-examples "
 
-SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master"
-SRCREV = "994d90ae583610673d9d39086ca5e84027a9c56e"
-
 PR = "${INC_PR}.0"
 
 S = "${WORKDIR}/git"
diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
new file mode 100644
index 0000000..37ce84d
--- /dev/null
+++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
@@ -0,0 +1,2 @@
+SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master"
+SRCREV = "0021b6f15ee4a1a8919905429a5045fd02afe5b1"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [rocko/master][PATCH v2] tidl-utils: add TIDL import tool source compilation.
  2018-12-11 21:54 [rocko/master][PATCH v2] tidl-utils: add TIDL import tool source compilation Jianzhong Xu
@ 2018-12-12 21:11 ` Denys Dmytriyenko
  2018-12-12 21:45   ` Xu, Jianzhong
  0 siblings, 1 reply; 3+ messages in thread
From: Denys Dmytriyenko @ 2018-12-12 21:11 UTC (permalink / raw)
  To: Jianzhong Xu; +Cc: meta-arago

So, you did remove the SUMMARY from .inc file.

But you didn't address my comment about formatting issues with extra or 
missing spaces...

Normally I don't complain about one or two of those in a patch - those are 
minor and as long as they don't break parsing or build, I accept them as is.

But most open source projects and communities have coding styles, e.g. Linux 
kernel. And OpenEmbedded has it as well. When there are too many such coding 
style issues in a patch, I won't take it.

Some examples, but the list is not complete:

> +DEPENDS="protobuf zlib protobuf-native"
> +BBCLASSEXTEND="native nativesdk"

There should be exactly 1 space on each side of the = sign.

> +SUMMARY = " TIDL import tool for conversion of Caffe and TF models into TI custom network format "

There should not be spaces at the beginning and end of the text.

>  RDEPENDS_${PN}_class-target += " tidl-api tidl-examples "

I know this was already in the recipe before your patch, but please also fix 
it - there's no need for spaces at the beginning and end of the list, when 
using += operand.

-- 
Denys


On Tue, Dec 11, 2018 at 04:54:34PM -0500, Jianzhong Xu wrote:
> Signed-off-by: Jianzhong Xu <xuj@ti.com>
> ---
>  .../nativesdk-packagegroup-arago-sdk-host.bb       |  1 +
>  .../recipes-ti/tidl-utils/tidl-import_git.bb       | 43 ++++++++++++++++++++++
>  .../recipes-ti/tidl-utils/tidl-utils.bb            |  7 ++--
>  .../recipes-ti/tidl-utils/tidl-utils.inc           |  2 +
>  4 files changed, 49 insertions(+), 4 deletions(-)
>  create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
>  create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
> 
> diff --git a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
> index 54466b7..af83521 100644
> --- a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
> +++ b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
> @@ -13,6 +13,7 @@ EXTRA_TI_TOOLS = " \
>      nativesdk-clacc \
>      nativesdk-open62541-examples \
>      nativesdk-open62541-tests \
> +    nativesdk-tidl-import \
>  "
>  
>  RDEPENDS_${PN} = "\
> diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
> new file mode 100644
> index 0000000..a644fbe
> --- /dev/null
> +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
> @@ -0,0 +1,43 @@
> +SUMMARY = " TIDL import tool for conversion of Caffe and TF models into TI custom network format "
> +DESCRIPTION = "TIDL import tool is using protobuf to read and parse information from external network models \
> +               This is ARM Linux implementation."
> +
> +require ./tidl-utils.inc
> +
> +LICENSE = "BSD-3"
> +LIC_FILES_CHKSUM = "file://modules/ti_dl/inc/itidl_ti.h;md5=7baa68fec0aadbac92c3b41b283d26c4"
> +
> +PV = "01.00.00.00"
> +PR = "r1"
> +
> +S = "${WORKDIR}/git/src/importTool/"
> +
> +DEPENDS="protobuf zlib protobuf-native"
> +
> +EXTRA_OEMAKE += "TIARM_TOOLS=${GCC_ARM_NONE_TOOLCHAIN}"
> +EXTRA_OEMAKE += "XDAIS_PATH=${XDAIS_INSTALL_DIR}"
> +EXTRA_OEMAKE += "SHOW_COMMANDS=1"
> +EXTRA_OEMAKE += "CORE=eve"
> +EXTRA_OEMAKE += "TARGET_BUILD=release"
> +EXTRA_OEMAKE += "TARGET_PLATFORM=PC"
> +
> +EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUX_IMPORT_TOOL=64BIT PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include"
> +EXTRA_MAKE_ARGS_class-target = "LINUX_BUILD_TOOLS=${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX} PROTOBUF_LIB_DIR=${STAGING_LIBDIR} PROTOBUF_INC_DIR=${STAGING_INCDIR} LINUXENV=oearm"
> +
> +EXTRA_OEMAKE += "${EXTRA_MAKE_ARGS}"
> +
> +do_compile() {
> +    cd ${S}/modules/ti_dl/utils
> +    ./genProtoSrc.sh
> +    cd ${S}
> +    oe_runmake -C modules/ti_dl/utils/tidlModelImport
> +}
> +
> +do_install () {
> +    install -d ${D}${bindir}
> +    install -m 755 ${S}/modules/ti_dl/utils/tidlModelImport/out/tidl_model_import.out ${D}${bindir}
> +}
> +
> +INSANE_SKIP_${PN} = "ldflags"
> +
> +BBCLASSEXTEND="native nativesdk"
> diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
> index 569de5a..575a0a0 100644
> --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
> +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
> @@ -3,16 +3,15 @@ DESCRIPTION = "TIDL Utilities for standalone simulation and importing / translat
>  HOMEPAGE = "http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components.html#tidl"
>  LICENSE = "TI-TFL"
>  
> -PV = "1.0.0.0"
> +require ./tidl-utils.inc
> +
> +PV = "1.0.0.1"
>  INC_PR = "r0"
>  
>  LIC_FILES_CHKSUM = "file://docs/LICENSE.txt;md5=a93aa5af7a3bbbb6fb34c8df59efaa5c"
>  
>  RDEPENDS_${PN}_class-target += " tidl-api tidl-examples "
>  
> -SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master"
> -SRCREV = "994d90ae583610673d9d39086ca5e84027a9c56e"
> -
>  PR = "${INC_PR}.0"
>  
>  S = "${WORKDIR}/git"
> diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
> new file mode 100644
> index 0000000..37ce84d
> --- /dev/null
> +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
> @@ -0,0 +1,2 @@
> +SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master"
> +SRCREV = "0021b6f15ee4a1a8919905429a5045fd02afe5b1"
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [rocko/master][PATCH v2] tidl-utils: add TIDL import tool source compilation.
  2018-12-12 21:11 ` Denys Dmytriyenko
@ 2018-12-12 21:45   ` Xu, Jianzhong
  0 siblings, 0 replies; 3+ messages in thread
From: Xu, Jianzhong @ 2018-12-12 21:45 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org

Denys,

Thanks for the instructions. I addressed some of the space issues in this patch, but apparently not all of them. Let me address them now and submit another version of the patch. 

Thanks,
Jianzhong

-----Original Message-----
From: Dmytriyenko, Denys 
Sent: Wednesday, December 12, 2018 4:12 PM
To: Xu, Jianzhong
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [rocko/master][PATCH v2] tidl-utils: add TIDL import tool source compilation.

So, you did remove the SUMMARY from .inc file.

But you didn't address my comment about formatting issues with extra or 
missing spaces...

Normally I don't complain about one or two of those in a patch - those are 
minor and as long as they don't break parsing or build, I accept them as is.

But most open source projects and communities have coding styles, e.g. Linux 
kernel. And OpenEmbedded has it as well. When there are too many such coding 
style issues in a patch, I won't take it.

Some examples, but the list is not complete:

> +DEPENDS="protobuf zlib protobuf-native"
> +BBCLASSEXTEND="native nativesdk"

There should be exactly 1 space on each side of the = sign.

> +SUMMARY = " TIDL import tool for conversion of Caffe and TF models into TI custom network format "

There should not be spaces at the beginning and end of the text.

>  RDEPENDS_${PN}_class-target += " tidl-api tidl-examples "

I know this was already in the recipe before your patch, but please also fix 
it - there's no need for spaces at the beginning and end of the list, when 
using += operand.

-- 
Denys


On Tue, Dec 11, 2018 at 04:54:34PM -0500, Jianzhong Xu wrote:
> Signed-off-by: Jianzhong Xu <xuj@ti.com>
> ---
>  .../nativesdk-packagegroup-arago-sdk-host.bb       |  1 +
>  .../recipes-ti/tidl-utils/tidl-import_git.bb       | 43 ++++++++++++++++++++++
>  .../recipes-ti/tidl-utils/tidl-utils.bb            |  7 ++--
>  .../recipes-ti/tidl-utils/tidl-utils.inc           |  2 +
>  4 files changed, 49 insertions(+), 4 deletions(-)
>  create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
>  create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
> 
> diff --git a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
> index 54466b7..af83521 100644
> --- a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
> +++ b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb
> @@ -13,6 +13,7 @@ EXTRA_TI_TOOLS = " \
>      nativesdk-clacc \
>      nativesdk-open62541-examples \
>      nativesdk-open62541-tests \
> +    nativesdk-tidl-import \
>  "
>  
>  RDEPENDS_${PN} = "\
> diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
> new file mode 100644
> index 0000000..a644fbe
> --- /dev/null
> +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb
> @@ -0,0 +1,43 @@
> +SUMMARY = " TIDL import tool for conversion of Caffe and TF models into TI custom network format "
> +DESCRIPTION = "TIDL import tool is using protobuf to read and parse information from external network models \
> +               This is ARM Linux implementation."
> +
> +require ./tidl-utils.inc
> +
> +LICENSE = "BSD-3"
> +LIC_FILES_CHKSUM = "file://modules/ti_dl/inc/itidl_ti.h;md5=7baa68fec0aadbac92c3b41b283d26c4"
> +
> +PV = "01.00.00.00"
> +PR = "r1"
> +
> +S = "${WORKDIR}/git/src/importTool/"
> +
> +DEPENDS="protobuf zlib protobuf-native"
> +
> +EXTRA_OEMAKE += "TIARM_TOOLS=${GCC_ARM_NONE_TOOLCHAIN}"
> +EXTRA_OEMAKE += "XDAIS_PATH=${XDAIS_INSTALL_DIR}"
> +EXTRA_OEMAKE += "SHOW_COMMANDS=1"
> +EXTRA_OEMAKE += "CORE=eve"
> +EXTRA_OEMAKE += "TARGET_BUILD=release"
> +EXTRA_OEMAKE += "TARGET_PLATFORM=PC"
> +
> +EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUX_IMPORT_TOOL=64BIT PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include"
> +EXTRA_MAKE_ARGS_class-target = "LINUX_BUILD_TOOLS=${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX} PROTOBUF_LIB_DIR=${STAGING_LIBDIR} PROTOBUF_INC_DIR=${STAGING_INCDIR} LINUXENV=oearm"
> +
> +EXTRA_OEMAKE += "${EXTRA_MAKE_ARGS}"
> +
> +do_compile() {
> +    cd ${S}/modules/ti_dl/utils
> +    ./genProtoSrc.sh
> +    cd ${S}
> +    oe_runmake -C modules/ti_dl/utils/tidlModelImport
> +}
> +
> +do_install () {
> +    install -d ${D}${bindir}
> +    install -m 755 ${S}/modules/ti_dl/utils/tidlModelImport/out/tidl_model_import.out ${D}${bindir}
> +}
> +
> +INSANE_SKIP_${PN} = "ldflags"
> +
> +BBCLASSEXTEND="native nativesdk"
> diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
> index 569de5a..575a0a0 100644
> --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
> +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb
> @@ -3,16 +3,15 @@ DESCRIPTION = "TIDL Utilities for standalone simulation and importing / translat
>  HOMEPAGE = "http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components.html#tidl"
>  LICENSE = "TI-TFL"
>  
> -PV = "1.0.0.0"
> +require ./tidl-utils.inc
> +
> +PV = "1.0.0.1"
>  INC_PR = "r0"
>  
>  LIC_FILES_CHKSUM = "file://docs/LICENSE.txt;md5=a93aa5af7a3bbbb6fb34c8df59efaa5c"
>  
>  RDEPENDS_${PN}_class-target += " tidl-api tidl-examples "
>  
> -SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master"
> -SRCREV = "994d90ae583610673d9d39086ca5e84027a9c56e"
> -
>  PR = "${INC_PR}.0"
>  
>  S = "${WORKDIR}/git"
> diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
> new file mode 100644
> index 0000000..37ce84d
> --- /dev/null
> +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc
> @@ -0,0 +1,2 @@
> +SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master"
> +SRCREV = "0021b6f15ee4a1a8919905429a5045fd02afe5b1"
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-12 21:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-11 21:54 [rocko/master][PATCH v2] tidl-utils: add TIDL import tool source compilation Jianzhong Xu
2018-12-12 21:11 ` Denys Dmytriyenko
2018-12-12 21:45   ` Xu, Jianzhong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.