From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-rdma@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v3 3/6] nvme-core: optionally poll sync commands
Date: Fri, 14 Dec 2018 16:44:05 +0100 [thread overview]
Message-ID: <20181214154405.GB24417@lst.de> (raw)
In-Reply-To: <20181213213410.9841-4-sagi@grimberg.me>
On Thu, Dec 13, 2018 at 01:34:07PM -0800, Sagi Grimberg wrote:
> Pass poll bool to indicate that we need it to poll. This prepares us for
> polling support in nvmf since connect is an I/O that will be queued
> and has to be polled in order to complete. If poll is passed,
> we call nvme_execute_rq_polled which sends the requests and polls
> for its completion.
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3 3/6] nvme-core: optionally poll sync commands
Date: Fri, 14 Dec 2018 16:44:05 +0100 [thread overview]
Message-ID: <20181214154405.GB24417@lst.de> (raw)
In-Reply-To: <20181213213410.9841-4-sagi@grimberg.me>
On Thu, Dec 13, 2018@01:34:07PM -0800, Sagi Grimberg wrote:
> Pass poll bool to indicate that we need it to poll. This prepares us for
> polling support in nvmf since connect is an I/O that will be queued
> and has to be polled in order to complete. If poll is passed,
> we call nvme_execute_rq_polled which sends the requests and polls
> for its completion.
Looks fine,
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2018-12-14 15:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 21:34 [PATCH v3 0/6] restore nvme-rdma polling Sagi Grimberg
2018-12-13 21:34 ` Sagi Grimberg
2018-12-13 21:34 ` [PATCH v3 1/6] block: clear REQ_HIPRI if polling is not supported Sagi Grimberg
2018-12-13 21:34 ` Sagi Grimberg
2018-12-13 21:34 ` [PATCH v3 2/6] block: make request_to_qc_t public Sagi Grimberg
2018-12-13 21:34 ` Sagi Grimberg
2018-12-14 15:43 ` Christoph Hellwig
2018-12-14 15:43 ` Christoph Hellwig
2018-12-14 16:52 ` Jens Axboe
2018-12-14 16:52 ` Jens Axboe
2018-12-13 21:34 ` [PATCH v3 3/6] nvme-core: optionally poll sync commands Sagi Grimberg
2018-12-13 21:34 ` Sagi Grimberg
2018-12-14 15:44 ` Christoph Hellwig [this message]
2018-12-14 15:44 ` Christoph Hellwig
2018-12-13 21:34 ` [PATCH v3 4/6] nvme-fabrics: allow nvmf_connect_io_queue to poll Sagi Grimberg
2018-12-13 21:34 ` Sagi Grimberg
2018-12-13 21:34 ` [PATCH v3 5/6] nvme-fabrics: allow user to pass in nr_poll_queues Sagi Grimberg
2018-12-13 21:34 ` Sagi Grimberg
2018-12-13 21:34 ` [PATCH v3 6/6] nvme-rdma: implement polling queue map Sagi Grimberg
2018-12-13 21:34 ` Sagi Grimberg
2018-12-14 15:46 ` Christoph Hellwig
2018-12-14 15:46 ` Christoph Hellwig
2018-12-14 18:59 ` Sagi Grimberg
2018-12-14 18:59 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214154405.GB24417@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.