From: Christoph Hellwig <hch@lst.de>
To: yupeng <yupeng0921@gmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
axboe@fb.com, hch@lst.de, sagi@grimberg.me, jthumshirn@suse.de
Subject: Re: [PATCH v4 1/2] export trace.c helper functions to other modules
Date: Tue, 18 Dec 2018 17:57:06 +0100 [thread overview]
Message-ID: <20181218165706.GA13271@lst.de> (raw)
In-Reply-To: <20181218045138.4282-1-yupeng0921@gmail.com>
On Mon, Dec 17, 2018 at 08:51:37PM -0800, yupeng wrote:
> Export bellow three functions:
> nvme_trace_parse_admin_cmd
> nvme_trace_parse_nvm_cmd
> nvme_trace_disk_name
> Thus any other modules which depends on nvme-core could use the trace
> events in trace.h
But we don't actually use these trace events anywhere outside of core.c,
even with your second patch, do we?
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v4 1/2] export trace.c helper functions to other modules
Date: Tue, 18 Dec 2018 17:57:06 +0100 [thread overview]
Message-ID: <20181218165706.GA13271@lst.de> (raw)
In-Reply-To: <20181218045138.4282-1-yupeng0921@gmail.com>
On Mon, Dec 17, 2018@08:51:37PM -0800, yupeng wrote:
> Export bellow three functions:
> nvme_trace_parse_admin_cmd
> nvme_trace_parse_nvm_cmd
> nvme_trace_disk_name
> Thus any other modules which depends on nvme-core could use the trace
> events in trace.h
But we don't actually use these trace events anywhere outside of core.c,
even with your second patch, do we?
next prev parent reply other threads:[~2018-12-18 16:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 4:51 [PATCH v4 1/2] export trace.c helper functions to other modules yupeng
2018-12-18 4:51 ` yupeng
2018-12-18 4:51 ` [PATCH v4 2/2] trace nvme submit queue status yupeng
2018-12-18 4:51 ` yupeng
2018-12-18 7:26 ` Sagi Grimberg
2018-12-18 7:26 ` Sagi Grimberg
2018-12-18 7:44 ` peng yu
2018-12-18 7:44 ` peng yu
2018-12-18 17:03 ` Christoph Hellwig
2018-12-18 17:03 ` Christoph Hellwig
2018-12-18 17:26 ` Keith Busch
2018-12-18 17:26 ` Keith Busch
2018-12-18 17:47 ` hch
2018-12-18 17:47 ` hch
2018-12-18 18:03 ` Keith Busch
2018-12-18 18:03 ` Keith Busch
2018-12-19 1:19 ` peng yu
2018-12-19 1:19 ` peng yu
2018-12-19 7:36 ` hch
2018-12-19 7:36 ` hch
2018-12-18 7:26 ` [PATCH v4 1/2] export trace.c helper functions to other modules Sagi Grimberg
2018-12-18 7:26 ` Sagi Grimberg
2018-12-18 16:57 ` Christoph Hellwig [this message]
2018-12-18 16:57 ` Christoph Hellwig
2018-12-18 16:58 ` Christoph Hellwig
2018-12-18 16:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218165706.GA13271@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yupeng0921@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.