From: Christoph Hellwig <hch@lst.de>
To: peng yu <yupeng0921@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
axboe@fb.com, hch@lst.de, jthumshirn@suse.de
Subject: Re: [PATCH v4 2/2] trace nvme submit queue status
Date: Tue, 18 Dec 2018 18:03:13 +0100 [thread overview]
Message-ID: <20181218170313.GA13540@lst.de> (raw)
In-Reply-To: <CAG3TDc1Od_aAq7VC5y_cu0mms2muzWXrBv-fCsHQkXEdXsBmoQ@mail.gmail.com>
On Mon, Dec 17, 2018 at 11:44:51PM -0800, peng yu wrote:
> Sorry, I don't quite understand your meaning. Do you mean I'd better
> change this:
> trace_nvme_sq(req->rq_disk,
> nvmeq->qid,
> le16_to_cpu(cqe->sq_head),
> nvmeq->sq_tail);
> to something like below:
> trace_nvme_sq(req->rq_disk, nvmeq->qid, le16_to_cpu(cqe->sq_head),
> nvmeq->sq_tail);
> Please let me know whether my understanding is correct.
Yes. Let me know if this version that I've applied is fine with you:
http://git.infradead.org/nvme.git/commitdiff/ed537628e59166a080d618825a7d175565a9cad4
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v4 2/2] trace nvme submit queue status
Date: Tue, 18 Dec 2018 18:03:13 +0100 [thread overview]
Message-ID: <20181218170313.GA13540@lst.de> (raw)
In-Reply-To: <CAG3TDc1Od_aAq7VC5y_cu0mms2muzWXrBv-fCsHQkXEdXsBmoQ@mail.gmail.com>
On Mon, Dec 17, 2018@11:44:51PM -0800, peng yu wrote:
> Sorry, I don't quite understand your meaning. Do you mean I'd better
> change this:
> trace_nvme_sq(req->rq_disk,
> nvmeq->qid,
> le16_to_cpu(cqe->sq_head),
> nvmeq->sq_tail);
> to something like below:
> trace_nvme_sq(req->rq_disk, nvmeq->qid, le16_to_cpu(cqe->sq_head),
> nvmeq->sq_tail);
> Please let me know whether my understanding is correct.
Yes. Let me know if this version that I've applied is fine with you:
http://git.infradead.org/nvme.git/commitdiff/ed537628e59166a080d618825a7d175565a9cad4
next prev parent reply other threads:[~2018-12-18 17:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 4:51 [PATCH v4 1/2] export trace.c helper functions to other modules yupeng
2018-12-18 4:51 ` yupeng
2018-12-18 4:51 ` [PATCH v4 2/2] trace nvme submit queue status yupeng
2018-12-18 4:51 ` yupeng
2018-12-18 7:26 ` Sagi Grimberg
2018-12-18 7:26 ` Sagi Grimberg
2018-12-18 7:44 ` peng yu
2018-12-18 7:44 ` peng yu
2018-12-18 17:03 ` Christoph Hellwig [this message]
2018-12-18 17:03 ` Christoph Hellwig
2018-12-18 17:26 ` Keith Busch
2018-12-18 17:26 ` Keith Busch
2018-12-18 17:47 ` hch
2018-12-18 17:47 ` hch
2018-12-18 18:03 ` Keith Busch
2018-12-18 18:03 ` Keith Busch
2018-12-19 1:19 ` peng yu
2018-12-19 1:19 ` peng yu
2018-12-19 7:36 ` hch
2018-12-19 7:36 ` hch
2018-12-18 7:26 ` [PATCH v4 1/2] export trace.c helper functions to other modules Sagi Grimberg
2018-12-18 7:26 ` Sagi Grimberg
2018-12-18 16:57 ` Christoph Hellwig
2018-12-18 16:57 ` Christoph Hellwig
2018-12-18 16:58 ` Christoph Hellwig
2018-12-18 16:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218170313.GA13540@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yupeng0921@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.