From: Sebastian Ott <sebott@linux.ibm.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Cc: linux-pci@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Russell Currey <ruscur@russell.cc>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 2/3] PCI/IOV: provide flag to skip VF scanning
Date: Fri, 21 Dec 2018 15:14:19 +0100 [thread overview]
Message-ID: <20181221141420.22555-2-sebott@linux.ibm.com> (raw)
In-Reply-To: <20181220200750.GF183878@google.com>
Provide a flag to skip scanning for new VFs after SRIOV enablement.
This can be set by implementations for which the VFs are already
reported by other means.
Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/pci/iov.c | 6 ++++++
include/linux/pci.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 408db232a328..3aa115ed3a65 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -257,6 +257,9 @@ static int sriov_add_vfs(struct pci_dev *dev, u16 num_vfs)
unsigned int i;
int rc;
+ if (dev->no_vf_scan)
+ return 0;
+
for (i = 0; i < num_vfs; i++) {
rc = pci_iov_add_virtfn(dev, i);
if (rc)
@@ -385,6 +388,9 @@ static void sriov_del_vfs(struct pci_dev *dev)
struct pci_sriov *iov = dev->sriov;
int i;
+ if (dev->no_vf_scan)
+ return;
+
for (i = 0; i < iov->num_VFs; i++)
pci_iov_remove_virtfn(dev, i);
}
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 11c71c4ecf75..f9bc7651c406 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -405,6 +405,7 @@ struct pci_dev {
unsigned int non_compliant_bars:1; /* Broken BARs; ignore them */
unsigned int is_probed:1; /* Device probing in progress */
unsigned int link_active_reporting:1;/* Device capable of reporting link active */
+ unsigned int no_vf_scan:1; /* Don't scan for VFs after IOV enablement */
pci_dev_flags_t dev_flags;
atomic_t enable_cnt; /* pci_enable_device has been called */
--
2.13.4
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Ott <sebott@linux.ibm.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 2/3] PCI/IOV: provide flag to skip VF scanning
Date: Fri, 21 Dec 2018 15:14:19 +0100 [thread overview]
Message-ID: <20181221141420.22555-2-sebott@linux.ibm.com> (raw)
In-Reply-To: <20181220200750.GF183878@google.com>
Provide a flag to skip scanning for new VFs after SRIOV enablement.
This can be set by implementations for which the VFs are already
reported by other means.
Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/pci/iov.c | 6 ++++++
include/linux/pci.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 408db232a328..3aa115ed3a65 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -257,6 +257,9 @@ static int sriov_add_vfs(struct pci_dev *dev, u16 num_vfs)
unsigned int i;
int rc;
+ if (dev->no_vf_scan)
+ return 0;
+
for (i = 0; i < num_vfs; i++) {
rc = pci_iov_add_virtfn(dev, i);
if (rc)
@@ -385,6 +388,9 @@ static void sriov_del_vfs(struct pci_dev *dev)
struct pci_sriov *iov = dev->sriov;
int i;
+ if (dev->no_vf_scan)
+ return;
+
for (i = 0; i < iov->num_VFs; i++)
pci_iov_remove_virtfn(dev, i);
}
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 11c71c4ecf75..f9bc7651c406 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -405,6 +405,7 @@ struct pci_dev {
unsigned int non_compliant_bars:1; /* Broken BARs; ignore them */
unsigned int is_probed:1; /* Device probing in progress */
unsigned int link_active_reporting:1;/* Device capable of reporting link active */
+ unsigned int no_vf_scan:1; /* Don't scan for VFs after IOV enablement */
pci_dev_flags_t dev_flags;
atomic_t enable_cnt; /* pci_enable_device has been called */
--
2.13.4
next prev parent reply other threads:[~2018-12-21 14:14 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 12:34 [PATCH 0/2] sriov enablement on s390 Sebastian Ott
2018-09-12 12:34 ` [PATCH 1/2] pci: provide pcibios_sriov_add_vfs Sebastian Ott
2018-09-12 12:34 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-09-12 13:02 ` [PATCH 0/2] sriov enablement on s390 Bjorn Helgaas
2018-09-12 14:40 ` Benjamin Herrenschmidt
2018-09-13 12:41 ` Sebastian Ott
2018-09-13 12:41 ` [PATCH 1/2] pci: provide add_vfs/del_vfs callbacks Sebastian Ott
2018-09-13 12:41 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-10-10 12:55 ` [PATCH 0/2] sriov enablement on s390 Sebastian Ott
2018-10-10 12:55 ` Sebastian Ott
2018-10-10 16:26 ` Bjorn Helgaas
2018-10-10 16:26 ` Bjorn Helgaas
2018-12-05 13:45 ` Sebastian Ott
2018-12-05 13:45 ` Sebastian Ott
2018-12-12 21:54 ` Bjorn Helgaas
2018-12-12 21:54 ` Bjorn Helgaas
2018-12-13 17:54 ` [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs Sebastian Ott
2018-12-13 17:54 ` Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig
2018-12-14 13:12 ` Christoph Hellwig
2018-12-13 17:54 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-12-13 17:54 ` Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig
2018-12-14 13:12 ` Christoph Hellwig
2018-12-14 13:18 ` Christoph Hellwig
2018-12-14 13:18 ` Christoph Hellwig
2018-12-17 17:30 ` Sebastian Ott
2018-12-17 17:30 ` Sebastian Ott
2018-12-17 17:35 ` Christoph Hellwig
2018-12-17 17:35 ` Christoph Hellwig
2018-12-18 10:16 ` [PATCH 1/2] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-18 10:16 ` Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
2018-12-19 7:52 ` Christoph Hellwig
2018-12-20 20:07 ` Bjorn Helgaas
2018-12-20 20:07 ` Bjorn Helgaas
2018-12-21 14:14 ` [PATCH 1/3] PCI/IOV: factor out sriov_add_vfs Sebastian Ott
2018-12-21 14:14 ` Sebastian Ott
2018-12-21 14:14 ` Sebastian Ott [this message]
2018-12-21 14:14 ` [PATCH 2/3] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-21 14:14 ` [PATCH 3/3] s390/pci: " Sebastian Ott
2018-12-21 14:14 ` Sebastian Ott
2018-12-21 14:19 ` [PATCH 1/2] PCI/IOV: provide flag to " Sebastian Ott
2018-12-21 14:19 ` Sebastian Ott
2019-01-02 1:14 ` Bjorn Helgaas
2019-01-02 1:14 ` Bjorn Helgaas
2018-12-18 10:16 ` [PATCH 2/2] s390/pci: " Sebastian Ott
2018-12-18 10:16 ` Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
2018-12-19 7:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221141420.22555-2-sebott@linux.ibm.com \
--to=sebott@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.