From: Bin Liu <b-liu@ti.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, od@zcrc.me
Subject: [2/4] usb: musb: jz4740: Add support for devicetree
Date: Mon, 7 Jan 2019 13:47:25 -0600 [thread overview]
Message-ID: <20190107194725.GB25910@uda0271908> (raw)
Hi,
On Thu, Dec 13, 2018 at 03:45:53PM +0100, Paul Cercueil wrote:
> Add support for probing the driver from devicetree.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/usb/musb/jz4740.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> index 04d8b2bc205a..9a2cebcac260 100644
> --- a/drivers/usb/musb/jz4740.c
> +++ b/drivers/usb/musb/jz4740.c
> @@ -10,6 +10,7 @@
> #include <linux/errno.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/usb/usb_phy_generic.h>
>
> @@ -188,11 +189,17 @@ static int jz4740_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id jz4740_musb_of_match[] = {
> + { .compatible = "ingenic,jz4740-musb" },
> + {},
> +};
should be wrapped by '#ifdef CONFIG_OF'?
miss MODULE_DEVICE_TABLE()
> +
> static struct platform_driver jz4740_driver = {
> .probe = jz4740_probe,
> .remove = jz4740_remove,
> .driver = {
> .name = "musb-jz4740",
> + .of_match_table = of_match_ptr(jz4740_musb_of_match),
> },
> };
>
Regards,
-Bin.
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, od@zcrc.me
Subject: Re: [PATCH 2/4] usb: musb: jz4740: Add support for devicetree
Date: Mon, 7 Jan 2019 13:47:25 -0600 [thread overview]
Message-ID: <20190107194725.GB25910@uda0271908> (raw)
In-Reply-To: <20181213144555.24031-2-paul@crapouillou.net>
Hi,
On Thu, Dec 13, 2018 at 03:45:53PM +0100, Paul Cercueil wrote:
> Add support for probing the driver from devicetree.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/usb/musb/jz4740.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> index 04d8b2bc205a..9a2cebcac260 100644
> --- a/drivers/usb/musb/jz4740.c
> +++ b/drivers/usb/musb/jz4740.c
> @@ -10,6 +10,7 @@
> #include <linux/errno.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/usb/usb_phy_generic.h>
>
> @@ -188,11 +189,17 @@ static int jz4740_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id jz4740_musb_of_match[] = {
> + { .compatible = "ingenic,jz4740-musb" },
> + {},
> +};
should be wrapped by '#ifdef CONFIG_OF'?
miss MODULE_DEVICE_TABLE()
> +
> static struct platform_driver jz4740_driver = {
> .probe = jz4740_probe,
> .remove = jz4740_remove,
> .driver = {
> .name = "musb-jz4740",
> + .of_match_table = of_match_ptr(jz4740_musb_of_match),
> },
> };
>
Regards,
-Bin.
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<od@zcrc.me>
Subject: Re: [PATCH 2/4] usb: musb: jz4740: Add support for devicetree
Date: Mon, 7 Jan 2019 13:47:25 -0600 [thread overview]
Message-ID: <20190107194725.GB25910@uda0271908> (raw)
In-Reply-To: <20181213144555.24031-2-paul@crapouillou.net>
Hi,
On Thu, Dec 13, 2018 at 03:45:53PM +0100, Paul Cercueil wrote:
> Add support for probing the driver from devicetree.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/usb/musb/jz4740.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> index 04d8b2bc205a..9a2cebcac260 100644
> --- a/drivers/usb/musb/jz4740.c
> +++ b/drivers/usb/musb/jz4740.c
> @@ -10,6 +10,7 @@
> #include <linux/errno.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/usb/usb_phy_generic.h>
>
> @@ -188,11 +189,17 @@ static int jz4740_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id jz4740_musb_of_match[] = {
> + { .compatible = "ingenic,jz4740-musb" },
> + {},
> +};
should be wrapped by '#ifdef CONFIG_OF'?
miss MODULE_DEVICE_TABLE()
> +
> static struct platform_driver jz4740_driver = {
> .probe = jz4740_probe,
> .remove = jz4740_remove,
> .driver = {
> .name = "musb-jz4740",
> + .of_match_table = of_match_ptr(jz4740_musb_of_match),
> },
> };
>
Regards,
-Bin.
next reply other threads:[~2019-01-07 19:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 19:47 Bin Liu [this message]
2019-01-07 19:47 ` [PATCH 2/4] usb: musb: jz4740: Add support for devicetree Bin Liu
2019-01-07 19:47 ` Bin Liu
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 20:11 [4/4] usb: musb: jz4740: Drop dependency on USB_OTG_BLACKLIST_HUB Bin Liu
2019-01-07 20:11 ` [PATCH 4/4] " Bin Liu
2019-01-07 20:11 ` Bin Liu
2019-01-07 20:10 [3/4] usb: musb: jz4740: Drop dependency on MACH_JZ4740, use COMPILE_TEST Bin Liu
2019-01-07 20:10 ` [PATCH 3/4] " Bin Liu
2019-01-07 20:10 ` Bin Liu
2018-12-20 20:33 [1/4] Documentation: dt: Add binding info for jz4740-musb driver Rob Herring
2018-12-20 20:33 ` [PATCH 1/4] " Rob Herring
2018-12-20 20:33 ` Rob Herring
2018-12-13 14:45 [4/4] usb: musb: jz4740: Drop dependency on USB_OTG_BLACKLIST_HUB Paul Cercueil
2018-12-13 14:45 ` [PATCH 4/4] " Paul Cercueil
2018-12-13 14:45 [3/4] usb: musb: jz4740: Drop dependency on MACH_JZ4740, use COMPILE_TEST Paul Cercueil
2018-12-13 14:45 ` [PATCH 3/4] " Paul Cercueil
2018-12-13 14:45 [2/4] usb: musb: jz4740: Add support for devicetree Paul Cercueil
2018-12-13 14:45 ` [PATCH 2/4] " Paul Cercueil
2018-12-13 14:45 [1/4] Documentation: dt: Add binding info for jz4740-musb driver Paul Cercueil
2018-12-13 14:45 ` [PATCH 1/4] " Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107194725.GB25910@uda0271908 \
--to=b-liu@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.