Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays

[Eduardo Habkost <ehabkost@redhat.com>]

On Tue, Jan 08, 2019 at 11:20:12AM +0100, Cornelia Huck wrote:
> On Tue, 8 Jan 2019 07:45:43 +0100
> Gerd Hoffmann <kraxel@redhat.com> wrote:
> 
> >   Hi,
> > 
> > > +    { "migration", "decompress-error-check", "off" },
> > > +    { "hda-audio", "use-timer", "false" },
> > > +    { "cirrus-vga", "global-vmstate", "true" },
> > > +    { "VGA", "global-vmstate", "true" },
> > > +    { "vmware-svga", "global-vmstate", "true" },
> > > +    { "qxl-vga", "global-vmstate", "true" },  
> > 
> > I'd like to have the fields aligned.  Especially in cases like this one
> > where multiple devices get the same value assigned it makes things more
> > readable:
> > 
> >     { "migration",   "decompress-error-check", "off"   },
> >     { "hda-audio",   "use-timer",              "false" },
> >     { "cirrus-vga",  "global-vmstate",         "true"  },
> >     { "VGA",         "global-vmstate",         "true"  },
> >     { "vmware-svga", "global-vmstate",         "true"  },
> >     { "qxl-vga",     "global-vmstate",         "true"  },
> > 
> > thanks,
> >   Gerd
> > 
> 
> I'm a bit on the fence here. It does make things more readable (at
> least in your example), but I find editing aligned tables a bit
> annoying. OTOH, that won't happen often, anyway.

I'm unsure, too.  Also, not merging this series is increasing the
likelihood of conflicts with other patches.  I'm queueing this
version, and we can discuss alignment alternatives later.

(I'm less worried about conflicts caused by future alignment
patches because alignment conflicts are easier to sort out than
redoing the .driver/.property/.value conversion).

-- 
Eduardo