From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org,
"David Hildenbrand" <david@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays
Date: Tue, 8 Jan 2019 11:21:09 +0100 [thread overview]
Message-ID: <20190108112109.41a93a75.cohuck@redhat.com> (raw)
In-Reply-To: <20190107193020.21744-4-ehabkost@redhat.com>
On Mon, 7 Jan 2019 17:30:20 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Instead of verbose arrays with 4 lines for each entry, make each
> entry take only one line. This makes long arrays that couldn't
> fit in the screen become short and readable.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> include/hw/i386/pc.h | 18 +-
> hw/core/machine.c | 338 ++++-------------
> hw/i386/pc.c | 720 +++++++------------------------------
> hw/i386/pc_piix.c | 192 ++--------
> hw/ppc/spapr.c | 72 +---
> hw/s390x/s390-virtio-ccw.c | 75 +---
> hw/xen/xen-common.c | 18 +-
> 7 files changed, 265 insertions(+), 1168 deletions(-)
>
(...)
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index c737507053..811fdf913d 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
(...)
> @@ -810,15 +798,8 @@ static void ccw_machine_2_6_class_options(MachineClass *mc)
> {
> S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);
> static GlobalProperty compat[] = {
> - {
> - .driver = TYPE_S390_IPL,
> - .property = "iplbext_migration",
> - .value = "off",
> - }, {
> - .driver = TYPE_VIRTUAL_CSS_BRIDGE,
> - .property = "css_dev_path",
> - .value = "off",
> - },
> + { TYPE_S390_IPL, "iplbext_migration", "off", },
> + { TYPE_VIRTUAL_CSS_BRIDGE, "css_dev_path", "off", },
The indentation looks off here.
> };
>
> s390mc->ri_allowed = false;
(...)
With or without alignment:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "David Hildenbrand" <david@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-s390x@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays
Date: Tue, 8 Jan 2019 11:21:09 +0100 [thread overview]
Message-ID: <20190108112109.41a93a75.cohuck@redhat.com> (raw)
In-Reply-To: <20190107193020.21744-4-ehabkost@redhat.com>
On Mon, 7 Jan 2019 17:30:20 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Instead of verbose arrays with 4 lines for each entry, make each
> entry take only one line. This makes long arrays that couldn't
> fit in the screen become short and readable.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> include/hw/i386/pc.h | 18 +-
> hw/core/machine.c | 338 ++++-------------
> hw/i386/pc.c | 720 +++++++------------------------------
> hw/i386/pc_piix.c | 192 ++--------
> hw/ppc/spapr.c | 72 +---
> hw/s390x/s390-virtio-ccw.c | 75 +---
> hw/xen/xen-common.c | 18 +-
> 7 files changed, 265 insertions(+), 1168 deletions(-)
>
(...)
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index c737507053..811fdf913d 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
(...)
> @@ -810,15 +798,8 @@ static void ccw_machine_2_6_class_options(MachineClass *mc)
> {
> S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);
> static GlobalProperty compat[] = {
> - {
> - .driver = TYPE_S390_IPL,
> - .property = "iplbext_migration",
> - .value = "off",
> - }, {
> - .driver = TYPE_VIRTUAL_CSS_BRIDGE,
> - .property = "css_dev_path",
> - .value = "off",
> - },
> + { TYPE_S390_IPL, "iplbext_migration", "off", },
> + { TYPE_VIRTUAL_CSS_BRIDGE, "css_dev_path", "off", },
The indentation looks off here.
> };
>
> s390mc->ri_allowed = false;
(...)
With or without alignment:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-01-08 10:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 19:30 [PATCH 0/3] machine: Make compat_props arrays shorter and more readable Eduardo Habkost
2019-01-07 19:30 ` [Qemu-devel] " Eduardo Habkost
2019-01-07 19:30 ` [PATCH 1/3] spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro Eduardo Habkost
2019-01-07 19:30 ` [Qemu-devel] " Eduardo Habkost
2019-01-07 19:35 ` Marc-André Lureau
2019-01-07 19:35 ` Marc-André Lureau
2019-01-08 0:07 ` David Gibson
2019-01-08 0:07 ` [Qemu-devel] " David Gibson
2019-01-08 9:59 ` Cornelia Huck
2019-01-08 9:59 ` [Qemu-devel] " Cornelia Huck
2019-01-07 19:30 ` [PATCH 2/3] machine: Eliminate unnecessary stringify() usage Eduardo Habkost
2019-01-07 19:30 ` [Qemu-devel] " Eduardo Habkost
2019-01-07 19:34 ` Marc-André Lureau
2019-01-07 19:34 ` Marc-André Lureau
2019-01-08 0:08 ` David Gibson
2019-01-08 0:08 ` [Qemu-devel] " David Gibson
2019-01-08 10:03 ` Cornelia Huck
2019-01-08 10:03 ` [Qemu-devel] " Cornelia Huck
2019-01-08 14:36 ` Philippe Mathieu-Daudé
2019-01-08 14:36 ` Philippe Mathieu-Daudé
2019-01-07 19:30 ` [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays Eduardo Habkost
2019-01-07 19:30 ` [Qemu-devel] " Eduardo Habkost
2019-01-07 19:40 ` Marc-André Lureau
2019-01-07 19:40 ` Marc-André Lureau
2019-01-08 6:45 ` Gerd Hoffmann
2019-01-08 6:45 ` Gerd Hoffmann
2019-01-08 10:20 ` Cornelia Huck
2019-01-08 10:20 ` Cornelia Huck
2019-01-10 0:43 ` Eduardo Habkost
2019-01-10 0:43 ` Eduardo Habkost
2019-01-08 10:21 ` Cornelia Huck [this message]
2019-01-08 10:21 ` Cornelia Huck
2019-01-08 14:38 ` Philippe Mathieu-Daudé
2019-01-08 14:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108112109.41a93a75.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.