All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"kevin.tian@intel.com" <kevin.tian@intel.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	"tnowicki@caviumnetworks.com" <tnowicki@caviumnetworks.com>,
	"mst@redhat.com" <mst@redhat.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Robin Murphy <Robin.Murphy@arm.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"frowand.list@gmail.com" <frowand.list@gmail.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"devicetree@vger.kernel.org" <devicetree@vger.ker>
Subject: Re: [PATCH v6 0/7] Add virtio-iommu driver
Date: Fri, 11 Jan 2019 13:28:46 +0100	[thread overview]
Message-ID: <20190111122846.GE5825@8bytes.org> (raw)
In-Reply-To: <9110873f-d344-b6b9-c722-9accfc329db2@arm.com>

Hi Jean-Philippe,

On Thu, Dec 13, 2018 at 12:50:29PM +0000, Jean-Philippe Brucker wrote:
> We already do deferred flush: UNMAP requests are added to the queue by
> iommu_unmap(), and then flushed out by iotlb_sync(). So we switch to the
> host only on iotlb_sync(), or when the request queue is full.

So the mappings can stay in place until iotlb_sync() returns? What
happens when the guest sends a map-request for a region it sent and
unmap request before, but did not call iotlb_sync inbetween?

Regards,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Mark Rutland <Mark.Rutland@arm.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"frowand.list@gmail.com" <frowand.list@gmail.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>,
	"tnowicki@caviumnetworks.com" <tnowicki@caviumnetworks.com>,
	"kevin.tian@intel.com" <kevin.tian@intel.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Robin Murphy <Robin.Murphy@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	"bharat.bhushan@nxp.com" <bharat.bhushan@nxp.com>
Subject: Re: [PATCH v6 0/7] Add virtio-iommu driver
Date: Fri, 11 Jan 2019 13:28:46 +0100	[thread overview]
Message-ID: <20190111122846.GE5825@8bytes.org> (raw)
In-Reply-To: <9110873f-d344-b6b9-c722-9accfc329db2@arm.com>

Hi Jean-Philippe,

On Thu, Dec 13, 2018 at 12:50:29PM +0000, Jean-Philippe Brucker wrote:
> We already do deferred flush: UNMAP requests are added to the queue by
> iommu_unmap(), and then flushed out by iotlb_sync(). So we switch to the
> host only on iotlb_sync(), or when the request queue is full.

So the mappings can stay in place until iotlb_sync() returns? What
happens when the guest sends a map-request for a region it sent and
unmap request before, but did not call iotlb_sync inbetween?

Regards,

	Joerg

  parent reply	other threads:[~2019-01-11 12:28 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 18:20 [PATCH v6 0/7] Add virtio-iommu driver Jean-Philippe Brucker
2018-12-11 18:20 ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 18:20 ` Jean-Philippe Brucker
2018-12-11 18:20 ` [PATCH v6 1/7] dt-bindings: virtio-mmio: Add IOMMU description Jean-Philippe Brucker
2018-12-11 18:20   ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 18:20 ` Jean-Philippe Brucker
2018-12-11 18:20 ` [PATCH v6 2/7] dt-bindings: virtio: Add virtio-pci-iommu node Jean-Philippe Brucker
2018-12-11 18:20   ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 18:20   ` Jean-Philippe Brucker
2018-12-11 18:20 ` Jean-Philippe Brucker
2018-12-11 18:21 ` [PATCH v6 3/7] of: Allow the iommu-map property to omit untranslated devices Jean-Philippe Brucker
2018-12-11 18:21 ` Jean-Philippe Brucker
2018-12-11 18:21   ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 18:21 ` [PATCH v6 4/7] PCI: OF: Initialize dev->fwnode appropriately Jean-Philippe Brucker
2018-12-11 18:21   ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 18:21 ` Jean-Philippe Brucker
2018-12-11 18:21 ` [PATCH v6 5/7] iommu: Add virtio-iommu driver Jean-Philippe Brucker
2018-12-11 18:21   ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 18:21 ` Jean-Philippe Brucker
2018-12-11 18:21 ` [PATCH v6 6/7] iommu/virtio: Add probe request Jean-Philippe Brucker
2018-12-11 18:21 ` Jean-Philippe Brucker
2018-12-11 18:21   ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 18:21 ` [PATCH v6 7/7] iommu/virtio: Add event queue Jean-Philippe Brucker
2018-12-11 18:21 ` Jean-Philippe Brucker
2018-12-11 18:21   ` [virtio-dev] " Jean-Philippe Brucker
     [not found] ` <20181211182104.18241-1-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-12-11 18:31   ` [PATCH v6 0/7] Add virtio-iommu driver Christoph Hellwig
2018-12-11 18:31     ` Christoph Hellwig
2018-12-11 19:07     ` Jean-Philippe Brucker
2018-12-11 19:07       ` [virtio-dev] " Jean-Philippe Brucker
2018-12-11 19:07     ` Jean-Philippe Brucker
2018-12-12  0:39     ` Michael S. Tsirkin
2018-12-12  0:39     ` Michael S. Tsirkin
2018-12-12  0:39       ` [virtio-dev] " Michael S. Tsirkin
2018-12-11 18:31 ` Christoph Hellwig
2018-12-12 10:35 ` Joerg Roedel
2018-12-12 10:35   ` Joerg Roedel
2018-12-12 14:35   ` Michael S. Tsirkin
2018-12-12 14:35     ` [virtio-dev] " Michael S. Tsirkin
2018-12-12 14:35   ` Michael S. Tsirkin
2018-12-13 12:50   ` Jean-Philippe Brucker
2018-12-13 12:50     ` [virtio-dev] " Jean-Philippe Brucker
2018-12-13 12:50     ` Jean-Philippe Brucker
2018-12-13 14:17     ` Christoph Hellwig
2018-12-13 14:17     ` Christoph Hellwig
2018-12-13 14:17       ` Christoph Hellwig
2018-12-19 23:09     ` Michael S. Tsirkin
2018-12-19 23:09     ` Michael S. Tsirkin
2018-12-19 23:09       ` [virtio-dev] " Michael S. Tsirkin
2018-12-19 23:09       ` Michael S. Tsirkin
2018-12-20 17:59       ` Jean-Philippe Brucker
2018-12-20 17:59       ` Jean-Philippe Brucker
2018-12-20 17:59         ` [virtio-dev] " Jean-Philippe Brucker
2018-12-20 18:17         ` Michael S. Tsirkin
2018-12-20 18:17         ` Michael S. Tsirkin
2018-12-20 18:17           ` [virtio-dev] " Michael S. Tsirkin
2018-12-20 18:17           ` Michael S. Tsirkin
2019-01-11 12:28     ` Joerg Roedel [this message]
2019-01-11 12:28       ` Joerg Roedel
2019-01-11 13:00       ` Jean-Philippe Brucker
2019-01-11 13:00       ` Jean-Philippe Brucker
2019-01-11 13:00         ` [virtio-dev] " Jean-Philippe Brucker
2019-01-11 13:00         ` Jean-Philippe Brucker
2019-01-11 12:28     ` Joerg Roedel
2018-12-13 12:50   ` Jean-Philippe Brucker
2018-12-12 10:35 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190111122846.GE5825@8bytes.org \
    --to=joro@8bytes.org \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=Robin.Murphy@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.ker \
    --cc=frowand.list@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jasowang@redhat.com \
    --cc=jean-philippe.brucker@arm.com \
    --cc=kevin.tian@intel.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-pci@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=tnowicki@caviumnetworks.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.