All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: mst@redhat.com, laurent@vivier.eu, imammedo@redhat.com,
	philmd@redhat.com, Wei Yang <richardw.yang@linux.intel.com>
Subject: [Qemu-trivial] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
Date: Wed, 30 Jan 2019 08:06:51 +0800	[thread overview]
Message-ID: <20190130000653.16267-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190130000653.16267-1-richardw.yang@linux.intel.com>

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
---
 hw/i386/pc.c         | 27 ---------------------------
 include/hw/i386/pc.h |  1 -
 2 files changed, 28 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5317e08f60..734d3268fa 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
                                         pci_address_space, -1);
 }
 
-void pc_acpi_init(const char *default_dsdt)
-{
-    char *filename;
-
-    if (acpi_tables != NULL) {
-        /* manually set via -acpitable, leave it alone */
-        return;
-    }
-
-    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
-    if (filename == NULL) {
-        warn_report("failed to find %s", default_dsdt);
-    } else {
-        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
-                                          &error_abort);
-        Error *err = NULL;
-
-        qemu_opt_set(opts, "file", filename, &error_abort);
-
-        acpi_table_add_builtin(opts, &err);
-        if (err) {
-            warn_reportf_err(err, "failed to load %s: ", filename);
-        }
-        g_free(filename);
-    }
-}
-
 void xen_load_linux(PCMachineState *pcms)
 {
     int i;
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 9d29c4b1df..541124ba6d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
 
 void pc_cpus_init(PCMachineState *pcms);
 void pc_hot_add_cpu(const int64_t id, Error **errp);
-void pc_acpi_init(const char *default_dsdt);
 
 void pc_guest_info_init(PCMachineState *pcms);
 
-- 
2.19.1



WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: mst@redhat.com, laurent@vivier.eu, imammedo@redhat.com,
	philmd@redhat.com, Wei Yang <richardw.yang@linux.intel.com>
Subject: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
Date: Wed, 30 Jan 2019 08:06:51 +0800	[thread overview]
Message-ID: <20190130000653.16267-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190130000653.16267-1-richardw.yang@linux.intel.com>

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
---
 hw/i386/pc.c         | 27 ---------------------------
 include/hw/i386/pc.h |  1 -
 2 files changed, 28 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5317e08f60..734d3268fa 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
                                         pci_address_space, -1);
 }
 
-void pc_acpi_init(const char *default_dsdt)
-{
-    char *filename;
-
-    if (acpi_tables != NULL) {
-        /* manually set via -acpitable, leave it alone */
-        return;
-    }
-
-    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
-    if (filename == NULL) {
-        warn_report("failed to find %s", default_dsdt);
-    } else {
-        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
-                                          &error_abort);
-        Error *err = NULL;
-
-        qemu_opt_set(opts, "file", filename, &error_abort);
-
-        acpi_table_add_builtin(opts, &err);
-        if (err) {
-            warn_reportf_err(err, "failed to load %s: ", filename);
-        }
-        g_free(filename);
-    }
-}
-
 void xen_load_linux(PCMachineState *pcms)
 {
     int i;
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 9d29c4b1df..541124ba6d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
 
 void pc_cpus_init(PCMachineState *pcms);
 void pc_hot_add_cpu(const int64_t id, Error **errp);
-void pc_acpi_init(const char *default_dsdt);
 
 void pc_guest_info_init(PCMachineState *pcms);
 
-- 
2.19.1

  reply	other threads:[~2019-01-30  0:21 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  0:06 [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-30  0:06 ` [Qemu-devel] " Wei Yang
2019-01-30  0:06 ` Wei Yang [this message]
2019-01-30  0:06   ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-30  8:10   ` [Qemu-trivial] " Igor Mammedov
2019-01-30  8:10     ` [Qemu-devel] " Igor Mammedov
2019-01-30  9:50   ` [Qemu-trivial] " Thomas Huth
2019-01-30  9:50     ` Thomas Huth
2019-01-30 11:07     ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-01-30 11:07       ` Philippe Mathieu-Daudé
2019-01-30 12:58       ` [Qemu-trivial] " Wei Yang
2019-01-30 12:58         ` Wei Yang
2019-01-30  0:06 ` [Qemu-trivial] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-30  0:06   ` [Qemu-devel] " Wei Yang
2019-01-30  8:11   ` [Qemu-trivial] " Igor Mammedov
2019-01-30  8:11     ` [Qemu-devel] " Igor Mammedov
2019-01-30  0:06 ` [Qemu-trivial] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-30  0:06   ` [Qemu-devel] " Wei Yang
2019-01-30  8:11   ` [Qemu-trivial] " Igor Mammedov
2019-01-30  8:11     ` [Qemu-devel] " Igor Mammedov
2019-02-12  5:22 ` [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-02-12  5:22   ` [Qemu-devel] " Wei Yang
2019-02-12  5:34   ` [Qemu-trivial] " Michael S. Tsirkin
2019-02-12  5:34     ` [Qemu-devel] " Michael S. Tsirkin
2019-02-13  6:26     ` [Qemu-trivial] " Wei Yang
2019-02-13  6:26       ` [Qemu-devel] " Wei Yang
2019-02-13  6:32       ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-02-13  6:32         ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-02-13  7:01         ` [Qemu-trivial] " Wei Yang
2019-02-13  7:01           ` [Qemu-devel] " Wei Yang
2019-02-13  8:49     ` [Qemu-trivial] " Laurent Vivier
2019-02-13  8:49       ` [Qemu-devel] " Laurent Vivier
2019-02-13  8:54       ` [Qemu-trivial] " Wei Yang
2019-02-13  8:54         ` [Qemu-devel] " Wei Yang
2019-02-13  8:56       ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-02-13  8:56         ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-02-13 13:31         ` [Qemu-trivial] " Wei Yang
2019-02-13 13:31           ` Wei Yang
2019-02-13 13:45         ` [Qemu-trivial] " Laurent Vivier
2019-02-13 13:45           ` [Qemu-devel] " Laurent Vivier
2019-02-14  0:03           ` [Qemu-trivial] " Wei Yang
2019-02-14  0:03             ` [Qemu-devel] " Wei Yang
2019-02-14  7:57             ` [Qemu-trivial] " Laurent Vivier
2019-02-14  7:57               ` [Qemu-devel] " Laurent Vivier
2019-02-14  8:10               ` [Qemu-trivial] " Laurent Vivier
2019-02-14  8:10                 ` [Qemu-devel] " Laurent Vivier
2019-02-14  8:18                 ` [Qemu-trivial] " Wei Yang
2019-02-14  8:18                   ` [Qemu-devel] " Wei Yang
2019-02-14  8:23                   ` [Qemu-trivial] " Laurent Vivier
2019-02-14  8:23                     ` [Qemu-devel] " Laurent Vivier
2019-02-14  8:39                     ` [Qemu-trivial] " Wei Yang
2019-02-14  8:39                       ` [Qemu-devel] " Wei Yang
2019-02-14  8:51                     ` [Qemu-trivial] " Wei Yang
2019-02-14  8:51                       ` [Qemu-devel] " Wei Yang
2019-02-14  9:11                       ` [Qemu-trivial] " Laurent Vivier
2019-02-14  9:11                         ` [Qemu-devel] " Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130000653.16267-2-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=imammedo@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=mst@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.