All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	Wei Yang <richardw.yang@linux.intel.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	imammedo@redhat.com, laurent@vivier.eu, mst@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
Date: Wed, 30 Jan 2019 12:58:20 +0000	[thread overview]
Message-ID: <20190130125820.n7py34wx2oojsaex@master> (raw)
In-Reply-To: <0dcf35c6-1b12-9e20-a0f5-b3fe2ea0ae74@redhat.com>

On Wed, Jan 30, 2019 at 12:07:02PM +0100, Philippe Mathieu-Daudé wrote:
>On 1/30/19 10:50 AM, Thomas Huth wrote:
>> On 2019-01-30 01:06, Wei Yang wrote:
>>> Function pc_acpi_init() is not used anymore.
>>>
>>> Remove the definition and declaration.
>>>
>>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>>> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>> 
>>  Hi,
>> 
>> at least in my e-mail client here, it looks like Philippe's last name
>> got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know.
>> Same thing also happened in patch 2 and 3.
>
>Thanks!
>

Opps, sorry for that.

Not sure which part changes the encoding.

>> 
>> Apart from that:
>> 
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> 

-- 
Wei Yang
Help you, Help me


WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richard.weiyang@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	Wei Yang <richardw.yang@linux.intel.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	imammedo@redhat.com, laurent@vivier.eu, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
Date: Wed, 30 Jan 2019 12:58:20 +0000	[thread overview]
Message-ID: <20190130125820.n7py34wx2oojsaex@master> (raw)
In-Reply-To: <0dcf35c6-1b12-9e20-a0f5-b3fe2ea0ae74@redhat.com>

On Wed, Jan 30, 2019 at 12:07:02PM +0100, Philippe Mathieu-Daudé wrote:
>On 1/30/19 10:50 AM, Thomas Huth wrote:
>> On 2019-01-30 01:06, Wei Yang wrote:
>>> Function pc_acpi_init() is not used anymore.
>>>
>>> Remove the definition and declaration.
>>>
>>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>>> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>> 
>>  Hi,
>> 
>> at least in my e-mail client here, it looks like Philippe's last name
>> got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know.
>> Same thing also happened in patch 2 and 3.
>
>Thanks!
>

Opps, sorry for that.

Not sure which part changes the encoding.

>> 
>> Apart from that:
>> 
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> 

-- 
Wei Yang
Help you, Help me

  reply	other threads:[~2019-01-30 12:58 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  0:06 [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-30  0:06 ` [Qemu-devel] " Wei Yang
2019-01-30  0:06 ` [Qemu-trivial] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-30  0:06   ` [Qemu-devel] " Wei Yang
2019-01-30  8:10   ` [Qemu-trivial] " Igor Mammedov
2019-01-30  8:10     ` [Qemu-devel] " Igor Mammedov
2019-01-30  9:50   ` [Qemu-trivial] " Thomas Huth
2019-01-30  9:50     ` Thomas Huth
2019-01-30 11:07     ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-01-30 11:07       ` Philippe Mathieu-Daudé
2019-01-30 12:58       ` Wei Yang [this message]
2019-01-30 12:58         ` Wei Yang
2019-01-30  0:06 ` [Qemu-trivial] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-30  0:06   ` [Qemu-devel] " Wei Yang
2019-01-30  8:11   ` [Qemu-trivial] " Igor Mammedov
2019-01-30  8:11     ` [Qemu-devel] " Igor Mammedov
2019-01-30  0:06 ` [Qemu-trivial] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-30  0:06   ` [Qemu-devel] " Wei Yang
2019-01-30  8:11   ` [Qemu-trivial] " Igor Mammedov
2019-01-30  8:11     ` [Qemu-devel] " Igor Mammedov
2019-02-12  5:22 ` [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-02-12  5:22   ` [Qemu-devel] " Wei Yang
2019-02-12  5:34   ` [Qemu-trivial] " Michael S. Tsirkin
2019-02-12  5:34     ` [Qemu-devel] " Michael S. Tsirkin
2019-02-13  6:26     ` [Qemu-trivial] " Wei Yang
2019-02-13  6:26       ` [Qemu-devel] " Wei Yang
2019-02-13  6:32       ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-02-13  6:32         ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-02-13  7:01         ` [Qemu-trivial] " Wei Yang
2019-02-13  7:01           ` [Qemu-devel] " Wei Yang
2019-02-13  8:49     ` [Qemu-trivial] " Laurent Vivier
2019-02-13  8:49       ` [Qemu-devel] " Laurent Vivier
2019-02-13  8:54       ` [Qemu-trivial] " Wei Yang
2019-02-13  8:54         ` [Qemu-devel] " Wei Yang
2019-02-13  8:56       ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-02-13  8:56         ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-02-13 13:31         ` [Qemu-trivial] " Wei Yang
2019-02-13 13:31           ` Wei Yang
2019-02-13 13:45         ` [Qemu-trivial] " Laurent Vivier
2019-02-13 13:45           ` [Qemu-devel] " Laurent Vivier
2019-02-14  0:03           ` [Qemu-trivial] " Wei Yang
2019-02-14  0:03             ` [Qemu-devel] " Wei Yang
2019-02-14  7:57             ` [Qemu-trivial] " Laurent Vivier
2019-02-14  7:57               ` [Qemu-devel] " Laurent Vivier
2019-02-14  8:10               ` [Qemu-trivial] " Laurent Vivier
2019-02-14  8:10                 ` [Qemu-devel] " Laurent Vivier
2019-02-14  8:18                 ` [Qemu-trivial] " Wei Yang
2019-02-14  8:18                   ` [Qemu-devel] " Wei Yang
2019-02-14  8:23                   ` [Qemu-trivial] " Laurent Vivier
2019-02-14  8:23                     ` [Qemu-devel] " Laurent Vivier
2019-02-14  8:39                     ` [Qemu-trivial] " Wei Yang
2019-02-14  8:39                       ` [Qemu-devel] " Wei Yang
2019-02-14  8:51                     ` [Qemu-trivial] " Wei Yang
2019-02-14  8:51                       ` [Qemu-devel] " Wei Yang
2019-02-14  9:11                       ` [Qemu-trivial] " Laurent Vivier
2019-02-14  9:11                         ` [Qemu-devel] " Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130125820.n7py34wx2oojsaex@master \
    --to=richard.weiyang@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=mst@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richardw.yang@linux.intel.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.