All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <broonie@kernel.org>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>
Cc: Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org
Subject: [PATCH 1/9] spi: atmel-quadspi: optimize qspi init
Date: Wed, 30 Jan 2019 15:08:29 +0000	[thread overview]
Message-ID: <20190130150818.24902-2-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20190130150818.24902-1-tudor.ambarus@microchip.com>

From: Tudor Ambarus <tudor.ambarus@microchip.com>

Set the QSPI controller in Serial Memory Mode at init and not
at each exec_op() call.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/spi/atmel-quadspi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index ddc712410812..f79b17792a11 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -238,8 +238,6 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
 	icr = QSPI_ICR_INST(op->cmd.opcode);
 	ifr = QSPI_IFR_INSTEN;
 
-	qspi_writel(aq, QSPI_MR, QSPI_MR_SMM);
-
 	mode = find_mode(op);
 	if (mode < 0)
 		return -ENOTSUPP;
@@ -381,6 +379,9 @@ static int atmel_qspi_init(struct atmel_qspi *aq)
 	/* Reset the QSPI controller */
 	qspi_writel(aq, QSPI_CR, QSPI_CR_SWRST);
 
+	/* Set the QSPI controller in Serial Memory Mode */
+	qspi_writel(aq, QSPI_MR, QSPI_MR_SMM);
+
 	/* Enable the QSPI controller */
 	qspi_writel(aq, QSPI_CR, QSPI_CR_QSPIEN);
 
-- 
2.9.5


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com>
To: <broonie@kernel.org>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>
Cc: <linux-spi@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<Tudor.Ambarus@microchip.com>
Subject: [PATCH 1/9] spi: atmel-quadspi: optimize qspi init
Date: Wed, 30 Jan 2019 15:08:29 +0000	[thread overview]
Message-ID: <20190130150818.24902-2-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20190130150818.24902-1-tudor.ambarus@microchip.com>

From: Tudor Ambarus <tudor.ambarus@microchip.com>

Set the QSPI controller in Serial Memory Mode at init and not
at each exec_op() call.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/spi/atmel-quadspi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index ddc712410812..f79b17792a11 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -238,8 +238,6 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
 	icr = QSPI_ICR_INST(op->cmd.opcode);
 	ifr = QSPI_IFR_INSTEN;
 
-	qspi_writel(aq, QSPI_MR, QSPI_MR_SMM);
-
 	mode = find_mode(op);
 	if (mode < 0)
 		return -ENOTSUPP;
@@ -381,6 +379,9 @@ static int atmel_qspi_init(struct atmel_qspi *aq)
 	/* Reset the QSPI controller */
 	qspi_writel(aq, QSPI_CR, QSPI_CR_SWRST);
 
+	/* Set the QSPI controller in Serial Memory Mode */
+	qspi_writel(aq, QSPI_MR, QSPI_MR_SMM);
+
 	/* Enable the QSPI controller */
 	qspi_writel(aq, QSPI_CR, QSPI_CR_QSPIEN);
 
-- 
2.9.5

WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com>
To: <broonie@kernel.org>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>
Cc: Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org
Subject: [PATCH 1/9] spi: atmel-quadspi: optimize qspi init
Date: Wed, 30 Jan 2019 15:08:29 +0000	[thread overview]
Message-ID: <20190130150818.24902-2-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20190130150818.24902-1-tudor.ambarus@microchip.com>

From: Tudor Ambarus <tudor.ambarus@microchip.com>

Set the QSPI controller in Serial Memory Mode at init and not
at each exec_op() call.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/spi/atmel-quadspi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index ddc712410812..f79b17792a11 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -238,8 +238,6 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
 	icr = QSPI_ICR_INST(op->cmd.opcode);
 	ifr = QSPI_IFR_INSTEN;
 
-	qspi_writel(aq, QSPI_MR, QSPI_MR_SMM);
-
 	mode = find_mode(op);
 	if (mode < 0)
 		return -ENOTSUPP;
@@ -381,6 +379,9 @@ static int atmel_qspi_init(struct atmel_qspi *aq)
 	/* Reset the QSPI controller */
 	qspi_writel(aq, QSPI_CR, QSPI_CR_SWRST);
 
+	/* Set the QSPI controller in Serial Memory Mode */
+	qspi_writel(aq, QSPI_MR, QSPI_MR_SMM);
+
 	/* Enable the QSPI controller */
 	qspi_writel(aq, QSPI_CR, QSPI_CR_QSPIEN);
 
-- 
2.9.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-01-30 15:25 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30 15:08 [PATCH 0/9] spi: atmel-quadspi: introduce sam9x60 qspi contoller Tudor.Ambarus
2019-01-30 15:08 ` Tudor.Ambarus
2019-01-30 15:08 ` Tudor.Ambarus
2019-01-30 15:08 ` Tudor.Ambarus [this message]
2019-01-30 15:08   ` [PATCH 1/9] spi: atmel-quadspi: optimize qspi init Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:15   ` Boris Brezillon
2019-01-30 17:15     ` Boris Brezillon
2019-01-30 17:15     ` Boris Brezillon
2019-01-31 10:42     ` Tudor.Ambarus
2019-01-31 10:42       ` Tudor.Ambarus
2019-01-31 10:42       ` Tudor.Ambarus
2019-01-30 15:08 ` [PATCH 2/9] spi: atmel-quadspi: order header files inclusion alphabetically Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:16   ` Boris Brezillon
2019-01-30 17:16     ` Boris Brezillon
2019-01-30 17:16     ` Boris Brezillon
2019-01-30 15:08 ` [PATCH 3/9] spi: atmel-quadspi: fix naming scheme Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:19   ` Boris Brezillon
2019-01-30 17:19     ` Boris Brezillon
2019-01-30 17:19     ` Boris Brezillon
2019-01-31 10:43     ` Tudor.Ambarus
2019-01-31 10:43       ` Tudor.Ambarus
2019-01-31 10:43       ` Tudor.Ambarus
2019-01-30 15:08 ` [PATCH 4/9] spi: atmel-quadspi: remove unnecessary cast Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:20   ` Boris Brezillon
2019-01-30 17:20     ` Boris Brezillon
2019-01-30 17:20     ` Boris Brezillon
2019-01-30 15:08 ` [PATCH 5/9] spi: atmel-quadspi: return appropriate error code Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:21   ` Boris Brezillon
2019-01-30 17:21     ` Boris Brezillon
2019-01-30 17:21     ` Boris Brezillon
2019-01-30 15:08 ` [PATCH 6/9] spi: atmel-quadspi: switch to SPDX license identifiers Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:23   ` Boris Brezillon
2019-01-30 17:23     ` Boris Brezillon
2019-01-30 17:23     ` Boris Brezillon
2019-01-30 15:08 ` [PATCH 7/9] dt-bindings: spi: atmel-quadspi: update example to new clock binding Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:25   ` Boris Brezillon
2019-01-30 17:25     ` Boris Brezillon
2019-01-30 17:25     ` Boris Brezillon
2019-01-30 15:08 ` [PATCH 8/9] dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60 Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:30   ` Boris Brezillon
2019-01-30 17:30     ` Boris Brezillon
2019-01-30 17:30     ` Boris Brezillon
2019-01-31 10:45     ` Tudor.Ambarus
2019-01-31 10:45       ` Tudor.Ambarus
2019-01-31 10:45       ` Tudor.Ambarus
2019-01-30 15:08 ` [PATCH 9/9] spi: atmel-quadspi: add support for sam9x60 qspi controller Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 15:08   ` Tudor.Ambarus
2019-01-30 17:43   ` Boris Brezillon
2019-01-30 17:43     ` Boris Brezillon
2019-01-30 17:43     ` Boris Brezillon
2019-01-31 10:46     ` Tudor.Ambarus
2019-01-31 10:46       ` Tudor.Ambarus
2019-01-31 10:46       ` Tudor.Ambarus
2019-01-31 11:55   ` Boris Brezillon
2019-01-31 11:55     ` Boris Brezillon
2019-01-31 11:55     ` Boris Brezillon
2019-01-31 12:40     ` Tudor.Ambarus
2019-01-31 12:40       ` Tudor.Ambarus
2019-01-31 12:40       ` Tudor.Ambarus
2019-01-31 13:12       ` Boris Brezillon
2019-01-31 13:12         ` Boris Brezillon
2019-01-31 13:12         ` Boris Brezillon
2019-01-31 12:01   ` Boris Brezillon
2019-01-31 12:01     ` Boris Brezillon
2019-01-31 12:01     ` Boris Brezillon
2019-01-31 12:01     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130150818.24902-2-tudor.ambarus@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.