All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kevin Hilman <khilman@kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Peng Donglin <dolinux.peng@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions
Date: Wed, 30 Jan 2019 18:21:02 +0000	[thread overview]
Message-ID: <20190130182102.GK18558@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190122144114.9816-2-gregkh@linuxfoundation.org>

Hi Greg,

On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Peng Donglin <dolinux.peng@gmail.com>
> Cc: <linux-arm-kernel@lists.infradead.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  arch/arm64/include/asm/ptdump.h | 9 +++------
>  arch/arm64/mm/dump.c            | 4 ++--
>  arch/arm64/mm/ptdump_debugfs.c  | 7 ++-----
>  3 files changed, 7 insertions(+), 13 deletions(-)

Are you taking this via your tree, or would you like us to queue it in
arm64?

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Kevin Hilman <khilman@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marc Zyngier <marc.zyngier@arm.com>,
	Peng Donglin <dolinux.peng@gmail.com>
Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions
Date: Wed, 30 Jan 2019 18:21:02 +0000	[thread overview]
Message-ID: <20190130182102.GK18558@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190122144114.9816-2-gregkh@linuxfoundation.org>

Hi Greg,

On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Peng Donglin <dolinux.peng@gmail.com>
> Cc: <linux-arm-kernel@lists.infradead.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  arch/arm64/include/asm/ptdump.h | 9 +++------
>  arch/arm64/mm/dump.c            | 4 ++--
>  arch/arm64/mm/ptdump_debugfs.c  | 7 ++-----
>  3 files changed, 7 insertions(+), 13 deletions(-)

Are you taking this via your tree, or would you like us to queue it in
arm64?

Will

  parent reply	other threads:[~2019-01-30 18:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 14:41 [PATCH 0/4] ARM: cleanup debugfs usage Greg Kroah-Hartman
2019-01-22 14:41 ` Greg Kroah-Hartman
2019-01-22 14:41 ` [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 14:41   ` Greg Kroah-Hartman
2019-01-25 18:13   ` Catalin Marinas
2019-01-25 18:13     ` Catalin Marinas
2019-01-30 18:21   ` Will Deacon [this message]
2019-01-30 18:21     ` Will Deacon
2019-01-30 19:33     ` Greg Kroah-Hartman
2019-01-30 19:33       ` Greg Kroah-Hartman
2019-01-31 13:57       ` Will Deacon
2019-01-31 13:57         ` Will Deacon
2019-01-22 14:41 ` [PATCH 2/4] arm: " Greg Kroah-Hartman
2019-01-22 14:41   ` Greg Kroah-Hartman
2019-01-22 21:25   ` Kees Cook
2019-01-22 21:25     ` Kees Cook
2019-01-23  9:42   ` Laura Abbott
2019-01-23  9:42     ` Laura Abbott
2019-01-22 14:41 ` [PATCH 3/4] arm: omap1: " Greg Kroah-Hartman
2019-01-22 14:41   ` Greg Kroah-Hartman
2019-01-22 23:05   ` Tony Lindgren
2019-01-22 23:05     ` Tony Lindgren
2019-01-22 14:41 ` [PATCH 4/4] arm: omap2: " Greg Kroah-Hartman
2019-01-22 14:41   ` Greg Kroah-Hartman
2019-01-22 23:06   ` Tony Lindgren
2019-01-22 23:06     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130182102.GK18558@fuggles.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dolinux.peng@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marc.zyngier@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.