From: Christoph Hellwig <hch@infradead.org>
To: John Dorminy <jdorminy@redhat.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
dm-devel@redhat.com, Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: block: Fix a WRITE SAME BUG_ON
Date: Thu, 31 Jan 2019 23:35:27 -0800 [thread overview]
Message-ID: <20190201073527.GA14758@infradead.org> (raw)
In-Reply-To: <CAMeeMh-uxiee7rKutnr3jrMjzkc8=R2Y3DPPBLvLYjqSwjfi_w@mail.gmail.com>
On Thu, Jan 31, 2019 at 02:41:52PM -0500, John Dorminy wrote:
> > On Wed, Jan 30, 2019 at 09:08:50AM -0500, John Dorminy wrote:
> > > (I use WRITE_SAME to fill devices with a particular pattern in order
> > > to catch failures to initialize disk structures appropriately,
> > > personally, but it's just for convenience/speed.)
> >
> > How do you use it? We don't have a user interface to generate
> > REQ_OP_WRITE_SAME requests.
>
> A not-checked-in test module, similar to Zhang Xiaoxu's reproducer,
> exposing a sysfs node to trigger filling a block device with a test
> pattern.
Any reason you don't just use SCSI/NVMe passthrough directly from
userspace for that?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: John Dorminy <jdorminy@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
dm-devel@redhat.com, Alasdair G Kergon <agk@redhat.com>
Subject: Re: block: Fix a WRITE SAME BUG_ON
Date: Thu, 31 Jan 2019 23:35:27 -0800 [thread overview]
Message-ID: <20190201073527.GA14758@infradead.org> (raw)
In-Reply-To: <CAMeeMh-uxiee7rKutnr3jrMjzkc8=R2Y3DPPBLvLYjqSwjfi_w@mail.gmail.com>
On Thu, Jan 31, 2019 at 02:41:52PM -0500, John Dorminy wrote:
> > On Wed, Jan 30, 2019 at 09:08:50AM -0500, John Dorminy wrote:
> > > (I use WRITE_SAME to fill devices with a particular pattern in order
> > > to catch failures to initialize disk structures appropriately,
> > > personally, but it's just for convenience/speed.)
> >
> > How do you use it? We don't have a user interface to generate
> > REQ_OP_WRITE_SAME requests.
>
> A not-checked-in test module, similar to Zhang Xiaoxu's reproducer,
> exposing a sysfs node to trigger filling a block device with a test
> pattern.
Any reason you don't just use SCSI/NVMe passthrough directly from
userspace for that?
next prev parent reply other threads:[~2019-02-01 7:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 2:11 [v2] block: Fix a WRITE SAME BUG_ON Zhang Xiaoxu
2019-01-26 11:17 ` John Dorminy
2019-01-26 11:17 ` [dm-devel] " John Dorminy
2019-01-28 5:48 ` zhangxiaoxu (A)
2019-01-28 5:48 ` [dm-devel] " zhangxiaoxu (A)
2019-01-28 22:14 ` Mike Snitzer
2019-01-28 22:14 ` Mike Snitzer
2019-01-29 4:54 ` Martin K. Petersen
2019-01-29 4:54 ` Martin K. Petersen
2019-01-29 8:52 ` Christoph Hellwig
2019-01-29 8:52 ` Christoph Hellwig
2019-01-30 6:50 ` zhangxiaoxu (A)
2019-01-30 6:50 ` zhangxiaoxu (A)
2019-01-30 14:08 ` John Dorminy
2019-01-30 14:08 ` John Dorminy
2019-01-31 0:58 ` zhangxiaoxu (A)
2019-01-31 0:58 ` zhangxiaoxu (A)
2019-01-31 2:23 ` Martin K. Petersen
2019-01-31 2:23 ` Martin K. Petersen
2019-01-31 10:39 ` Christoph Hellwig
2019-01-31 10:39 ` Christoph Hellwig
2019-01-31 19:41 ` John Dorminy
2019-01-31 19:41 ` John Dorminy
2019-02-01 7:35 ` Christoph Hellwig [this message]
2019-02-01 7:35 ` Christoph Hellwig
2019-02-01 14:09 ` John Dorminy
2019-02-01 14:09 ` John Dorminy
2019-02-01 16:03 ` Heinz Mauelshagen
2019-02-01 16:03 ` [dm-devel] " Heinz Mauelshagen
2019-02-01 16:18 ` Christoph Hellwig
2019-02-01 16:18 ` [dm-devel] " Christoph Hellwig
2019-02-12 3:11 ` zhangxiaoxu (A)
2019-02-12 3:11 ` [dm-devel] " zhangxiaoxu (A)
2019-02-14 2:31 ` Martin K. Petersen
2019-02-14 2:31 ` [dm-devel] " Martin K. Petersen
2019-02-14 9:36 ` zhangxiaoxu (A)
2019-02-14 9:36 ` [dm-devel] " zhangxiaoxu (A)
2019-02-18 14:10 ` zhangxiaoxu (A)
2019-02-18 14:10 ` [dm-devel] " zhangxiaoxu (A)
2019-02-19 23:10 ` Martin K. Petersen
2019-02-19 23:10 ` [dm-devel] " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201073527.GA14758@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=jdorminy@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.