From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] drm/bochs: fix bochs_gem_prime_mmap
Date: Tue, 5 Feb 2019 10:01:28 +0100 [thread overview]
Message-ID: <20190205090128.GA3271@phenom.ffwll.local> (raw)
In-Reply-To: <20190204183858.8976-1-kraxel@redhat.com>
On Mon, Feb 04, 2019 at 07:38:58PM +0100, Gerd Hoffmann wrote:
> ttm_fbdev_mmap() just doesn't work. It appears to work fine, mmap()
> returns success, but any attempt to actually access the mapping causes a
> SIGBUS.
>
> We can just use drm_gem_prime_mmap() instead. Almost. We have to copy
> over the start offset from the ttm_buffer_object vm_node to the
> drm_gem_object vm_node so the offset math in drm_gem_prime_mmap() works
> correctly for us even though we use ttm to manage our objects.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Would be kinda neat if we could teach ttm to not have it's own vma node
...
Anyway, lgtm.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/bochs/bochs_mm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
> index 641a33f134..49463348a0 100644
> --- a/drivers/gpu/drm/bochs/bochs_mm.c
> +++ b/drivers/gpu/drm/bochs/bochs_mm.c
> @@ -442,5 +442,6 @@ int bochs_gem_prime_mmap(struct drm_gem_object *obj,
> {
> struct bochs_bo *bo = gem_to_bochs_bo(obj);
>
> - return ttm_fbdev_mmap(vma, &bo->bo);
> + bo->gem.vma_node.vm_node.start = bo->bo.vma_node.vm_node.start;
> + return drm_gem_prime_mmap(obj, vma);
> }
> --
> 2.9.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/bochs: fix bochs_gem_prime_mmap
Date: Tue, 5 Feb 2019 10:01:28 +0100 [thread overview]
Message-ID: <20190205090128.GA3271@phenom.ffwll.local> (raw)
In-Reply-To: <20190204183858.8976-1-kraxel@redhat.com>
On Mon, Feb 04, 2019 at 07:38:58PM +0100, Gerd Hoffmann wrote:
> ttm_fbdev_mmap() just doesn't work. It appears to work fine, mmap()
> returns success, but any attempt to actually access the mapping causes a
> SIGBUS.
>
> We can just use drm_gem_prime_mmap() instead. Almost. We have to copy
> over the start offset from the ttm_buffer_object vm_node to the
> drm_gem_object vm_node so the offset math in drm_gem_prime_mmap() works
> correctly for us even though we use ttm to manage our objects.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Would be kinda neat if we could teach ttm to not have it's own vma node
...
Anyway, lgtm.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/bochs/bochs_mm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
> index 641a33f134..49463348a0 100644
> --- a/drivers/gpu/drm/bochs/bochs_mm.c
> +++ b/drivers/gpu/drm/bochs/bochs_mm.c
> @@ -442,5 +442,6 @@ int bochs_gem_prime_mmap(struct drm_gem_object *obj,
> {
> struct bochs_bo *bo = gem_to_bochs_bo(obj);
>
> - return ttm_fbdev_mmap(vma, &bo->bo);
> + bo->gem.vma_node.vm_node.start = bo->bo.vma_node.vm_node.start;
> + return drm_gem_prime_mmap(obj, vma);
> }
> --
> 2.9.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-02-05 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:38 [PATCH] drm/bochs: fix bochs_gem_prime_mmap Gerd Hoffmann
2019-02-04 18:38 ` Gerd Hoffmann
2019-02-05 9:01 ` Daniel Vetter
2019-02-05 9:01 ` Daniel Vetter [this message]
2019-02-05 9:01 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2019-02-04 18:38 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205090128.GA3271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.