From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Jun Li <jun.li@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Chen Yu <chenyu56@huawei.com>,
Hans de Goede <hdegoede@redhat.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [v2,6/9] usb: roles: Find the muxes by also matching against the device node
Date: Mon, 11 Feb 2019 12:46:29 +0200 [thread overview]
Message-ID: <20190211104629.GE16987@kuha.fi.intel.com> (raw)
On Mon, Feb 11, 2019 at 09:58:04AM +0000, Jun Li wrote:
> Hi Heikki,
>
> > @@ -84,7 +85,12 @@ enum usb_role usb_role_switch_get_role(struct
> > usb_role_switch *sw) } EXPORT_SYMBOL_GPL(usb_role_switch_get_role);
> >
> > -static int __switch_match(struct device *dev, const void *name)
> > +static int switch_fwnode_match(struct device *dev, const void *fwnode)
> > +{
> > + return dev_fwnode(dev) == fwnode;
>
> You missed the comment
> https://lkml.org/lkml/2019/1/22/437
>
> return dev_fwnode(dev->parent) == fwnode;
That's actually not the case. struct usb_role_switch_desc has a member
for fwnode, and that's what we use with the actual mux device. Check
usb_role_switch_register():
...
sw->dev.fwnode = desc->fwnode;
...
Sorry for not realizing it before.
thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Jun Li <jun.li@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Chen Yu <chenyu56@huawei.com>,
Hans de Goede <hdegoede@redhat.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/9] usb: roles: Find the muxes by also matching against the device node
Date: Mon, 11 Feb 2019 12:46:29 +0200 [thread overview]
Message-ID: <20190211104629.GE16987@kuha.fi.intel.com> (raw)
In-Reply-To: <VI1PR04MB4558283CA9D752D5452FA09989640@VI1PR04MB4558.eurprd04.prod.outlook.com>
On Mon, Feb 11, 2019 at 09:58:04AM +0000, Jun Li wrote:
> Hi Heikki,
>
> > @@ -84,7 +85,12 @@ enum usb_role usb_role_switch_get_role(struct
> > usb_role_switch *sw) } EXPORT_SYMBOL_GPL(usb_role_switch_get_role);
> >
> > -static int __switch_match(struct device *dev, const void *name)
> > +static int switch_fwnode_match(struct device *dev, const void *fwnode)
> > +{
> > + return dev_fwnode(dev) == fwnode;
>
> You missed the comment
> https://lkml.org/lkml/2019/1/22/437
>
> return dev_fwnode(dev->parent) == fwnode;
That's actually not the case. struct usb_role_switch_desc has a member
for fwnode, and that's what we use with the actual mux device. Check
usb_role_switch_register():
...
sw->dev.fwnode = desc->fwnode;
...
Sorry for not realizing it before.
thanks,
--
heikki
next reply other threads:[~2019-02-11 10:46 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 10:46 Heikki Krogerus [this message]
2019-02-11 10:46 ` [PATCH v2 6/9] usb: roles: Find the muxes by also matching against the device node Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2019-02-12 11:24 [v2,6/9] " Heikki Krogerus
2019-02-12 11:24 ` [PATCH v2 6/9] " Heikki Krogerus
2019-02-12 10:41 [v2,6/9] " Jun Li
2019-02-12 10:41 ` [PATCH v2 6/9] " Jun Li
2019-02-12 8:50 [v2,6/9] " Heikki Krogerus
2019-02-12 8:50 ` [PATCH v2 6/9] " Heikki Krogerus
2019-02-12 6:03 [v2,6/9] " Jun Li
2019-02-12 6:03 ` [PATCH v2 6/9] " Jun Li
2019-02-11 12:40 [v2,6/9] " Heikki Krogerus
2019-02-11 12:40 ` [PATCH v2 6/9] " Heikki Krogerus
2019-02-11 11:52 [v2,7/9] usb: typec: Find the ports " Andy Shevchenko
2019-02-11 11:52 ` [PATCH v2 7/9] " Andy Shevchenko
2019-02-11 9:58 [v2,6/9] usb: roles: Find the muxes " Jun Li
2019-02-11 9:58 ` [PATCH v2 6/9] " Jun Li
2019-02-11 8:39 [v2,7/9] usb: typec: Find the ports " Heikki Krogerus
2019-02-11 8:39 ` [PATCH v2 7/9] " Heikki Krogerus
2019-01-31 13:35 [v2,7/9] " Heikki Krogerus
2019-01-31 13:35 ` [PATCH v2 7/9] " Heikki Krogerus
2019-01-30 16:51 [v2,7/9] " Andy Shevchenko
2019-01-30 16:51 ` [PATCH v2 7/9] " Andy Shevchenko
2019-01-30 16:02 [v2,9/9] device connection: Find device connections also from device graphs Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 9/9] " Heikki Krogerus
2019-01-30 16:02 [v2,8/9] device connection: Prepare support for firmware described connections Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 8/9] " Heikki Krogerus
2019-01-30 16:02 [v2,7/9] usb: typec: Find the ports by also matching against the device node Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 7/9] " Heikki Krogerus
2019-01-30 16:02 [v2,6/9] usb: roles: Find the muxes " Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 6/9] " Heikki Krogerus
2019-01-30 16:02 [v2,5/9] usb: typec: mux: " Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 5/9] " Heikki Krogerus
2019-01-30 16:02 [v2,4/9] device connection: Add fwnode member to struct device_connection Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 4/9] " Heikki Krogerus
2019-01-30 16:02 [v2,3/9] platform/x86: intel_cht_int33fe: Remove old style mux connections Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 3/9] " Heikki Krogerus
2019-01-30 16:02 [v2,2/9] usb: typec: Rationalize the API for the muxes Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 2/9] " Heikki Krogerus
2019-01-30 16:02 [v2,1/9] platform/x86: intel_cht_int33fe: Prepare for better mux naming scheme Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 1/9] " Heikki Krogerus
2019-01-30 16:02 [PATCH v2 0/9] device connection: Add support for device graphs Heikki Krogerus
2019-01-31 10:06 ` Hans de Goede
2019-01-31 13:36 ` Heikki Krogerus
2019-02-12 10:44 ` Jun Li
2019-02-12 11:31 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211104629.GE16987@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=chenyu56@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.