All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chen Yu <chenyu56@huawei.com>, Jun Li <jun.li@nxp.com>,
	Hans de Goede <hdegoede@redhat.com>,
	USB <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [v2,7/9] usb: typec: Find the ports by also matching against the device node
Date: Thu, 31 Jan 2019 15:35:37 +0200	[thread overview]
Message-ID: <20190131133537.GA13072@kuha.fi.intel.com> (raw)

On Wed, Jan 30, 2019 at 06:51:56PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > When the connections are defined in firmware, struct
> > device_connection will have the fwnode member pointing to
> > the device node (struct fwnode_handle) of the requested
> > device, and the endpoint will not be used at all in that
> > case.
> 
> > +       /*
> > +        * FIXME: Check does the fwnode supports the requested SVID. If it does
> > +        * we need to return ERR_PTR(-PROBE_DEFER) when there is no device.
> > +        */
> > +       if (con->fwnode)
> > +               return class_find_device(typec_class, NULL, con->fwnode,
> > +                                        typec_port_fwnode_match);
> > +
> > +       dev = class_find_device(typec_class, NULL, con->endpoint[ep],
> > +                               typec_port_name_match);
> > +
> > +       return dev ? dev : ERR_PTR(-EPROBE_DEFER);
> 
> Just  to be clear, this one takes a reference on dev. Is it taken into account?

Yes. That is what we want it to do.

thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chen Yu <chenyu56@huawei.com>, Jun Li <jun.li@nxp.com>,
	Hans de Goede <hdegoede@redhat.com>,
	USB <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 7/9] usb: typec: Find the ports by also matching against the device node
Date: Thu, 31 Jan 2019 15:35:37 +0200	[thread overview]
Message-ID: <20190131133537.GA13072@kuha.fi.intel.com> (raw)
In-Reply-To: <CAHp75Vdq+T4vKsihhUJjV85-mkWfY2G=npJLPaGiGjbzD_m32w@mail.gmail.com>

On Wed, Jan 30, 2019 at 06:51:56PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > When the connections are defined in firmware, struct
> > device_connection will have the fwnode member pointing to
> > the device node (struct fwnode_handle) of the requested
> > device, and the endpoint will not be used at all in that
> > case.
> 
> > +       /*
> > +        * FIXME: Check does the fwnode supports the requested SVID. If it does
> > +        * we need to return ERR_PTR(-PROBE_DEFER) when there is no device.
> > +        */
> > +       if (con->fwnode)
> > +               return class_find_device(typec_class, NULL, con->fwnode,
> > +                                        typec_port_fwnode_match);
> > +
> > +       dev = class_find_device(typec_class, NULL, con->endpoint[ep],
> > +                               typec_port_name_match);
> > +
> > +       return dev ? dev : ERR_PTR(-EPROBE_DEFER);
> 
> Just  to be clear, this one takes a reference on dev. Is it taken into account?

Yes. That is what we want it to do.

thanks,

-- 
heikki

             reply	other threads:[~2019-01-31 13:35 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31 13:35 Heikki Krogerus [this message]
2019-01-31 13:35 ` [PATCH v2 7/9] usb: typec: Find the ports by also matching against the device node Heikki Krogerus
  -- strict thread matches above, loose matches on Subject: below --
2019-02-12 11:24 [v2,6/9] usb: roles: Find the muxes " Heikki Krogerus
2019-02-12 11:24 ` [PATCH v2 6/9] " Heikki Krogerus
2019-02-12 10:41 [v2,6/9] " Jun Li
2019-02-12 10:41 ` [PATCH v2 6/9] " Jun Li
2019-02-12  8:50 [v2,6/9] " Heikki Krogerus
2019-02-12  8:50 ` [PATCH v2 6/9] " Heikki Krogerus
2019-02-12  6:03 [v2,6/9] " Jun Li
2019-02-12  6:03 ` [PATCH v2 6/9] " Jun Li
2019-02-11 12:40 [v2,6/9] " Heikki Krogerus
2019-02-11 12:40 ` [PATCH v2 6/9] " Heikki Krogerus
2019-02-11 11:52 [v2,7/9] usb: typec: Find the ports " Andy Shevchenko
2019-02-11 11:52 ` [PATCH v2 7/9] " Andy Shevchenko
2019-02-11 10:46 [v2,6/9] usb: roles: Find the muxes " Heikki Krogerus
2019-02-11 10:46 ` [PATCH v2 6/9] " Heikki Krogerus
2019-02-11  9:58 [v2,6/9] " Jun Li
2019-02-11  9:58 ` [PATCH v2 6/9] " Jun Li
2019-02-11  8:39 [v2,7/9] usb: typec: Find the ports " Heikki Krogerus
2019-02-11  8:39 ` [PATCH v2 7/9] " Heikki Krogerus
2019-01-30 16:51 [v2,7/9] " Andy Shevchenko
2019-01-30 16:51 ` [PATCH v2 7/9] " Andy Shevchenko
2019-01-30 16:02 [v2,9/9] device connection: Find device connections also from device graphs Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 9/9] " Heikki Krogerus
2019-01-30 16:02 [v2,8/9] device connection: Prepare support for firmware described connections Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 8/9] " Heikki Krogerus
2019-01-30 16:02 [v2,7/9] usb: typec: Find the ports by also matching against the device node Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 7/9] " Heikki Krogerus
2019-01-30 16:02 [v2,6/9] usb: roles: Find the muxes " Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 6/9] " Heikki Krogerus
2019-01-30 16:02 [v2,5/9] usb: typec: mux: " Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 5/9] " Heikki Krogerus
2019-01-30 16:02 [v2,4/9] device connection: Add fwnode member to struct device_connection Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 4/9] " Heikki Krogerus
2019-01-30 16:02 [v2,3/9] platform/x86: intel_cht_int33fe: Remove old style mux connections Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 3/9] " Heikki Krogerus
2019-01-30 16:02 [v2,2/9] usb: typec: Rationalize the API for the muxes Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 2/9] " Heikki Krogerus
2019-01-30 16:02 [v2,1/9] platform/x86: intel_cht_int33fe: Prepare for better mux naming scheme Heikki Krogerus
2019-01-30 16:02 ` [PATCH v2 1/9] " Heikki Krogerus
2019-01-30 16:02 [PATCH v2 0/9] device connection: Add support for device graphs Heikki Krogerus
2019-01-31 10:06 ` Hans de Goede
2019-01-31 13:36   ` Heikki Krogerus
2019-02-12 10:44 ` Jun Li
2019-02-12 11:31   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131133537.GA13072@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=chenyu56@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=jun.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.