* [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330
@ 2019-02-13 10:14 David Santamaría Rogado via dri-devel
2019-02-13 12:43 ` Thierry Reding via dri-devel
0 siblings, 1 reply; 6+ messages in thread
From: David Santamaría Rogado via dri-devel @ 2019-02-13 10:14 UTC (permalink / raw)
To: Jani Nikula, David Airlie, Daniel Vetter, Thierry Reding,
dri-devel
Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console
ouput gets rotated at boot as Miix 310.
Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 61d3361381b73..835574e2d5bf7 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data
lcd800x1280_rightside_up = {
.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
};
+static const struct drm_dmi_panel_orientation_data
lcd1200x1920_rightside_up = {
+ .width = 1200,
+ .height = 1920,
+ .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
static const struct dmi_system_id orientation_data[] = {
{ /* Acer One 10 (S1003) */
.matches = {
@@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
},
.driver_data = &itworks_tw891,
+ }, { /* Lenovo Ideapad D330 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+ },
+ .driver_data = &lcd1200x1920_rightside_up,
}, { /*
* Lenovo Ideapad Miix 310 laptop, only some production batches
* have a portrait screen, the resolution checks makes the quirk
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330
2019-02-13 10:14 [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330 David Santamaría Rogado via dri-devel
@ 2019-02-13 12:43 ` Thierry Reding via dri-devel
2019-02-13 17:18 ` David Santamaría Rogado via dri-devel
0 siblings, 1 reply; 6+ messages in thread
From: Thierry Reding via dri-devel @ 2019-02-13 12:43 UTC (permalink / raw)
To: David Santamaría Rogado; +Cc: David Airlie, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1890 bytes --]
On Wed, Feb 13, 2019 at 11:14:51AM +0100, David Santamaría Rogado wrote:
> Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console
> ouput gets rotated at boot as Miix 310.
>
> Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
Is something obfuscating your email address here?
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 61d3361381b73..835574e2d5bf7 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data
> lcd800x1280_rightside_up = {
> .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> };
>
> +static const struct drm_dmi_panel_orientation_data
> lcd1200x1920_rightside_up = {
> + .width = 1200,
> + .height = 1920,
> + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> +};
> +
Looks like that something may be messing up the whitespace in your patch
as well.
Thierry
> static const struct dmi_system_id orientation_data[] = {
> { /* Acer One 10 (S1003) */
> .matches = {
> @@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
> },
> .driver_data = &itworks_tw891,
> + }, { /* Lenovo Ideapad D330 */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
> + },
> + .driver_data = &lcd1200x1920_rightside_up,
> }, { /*
> * Lenovo Ideapad Miix 310 laptop, only some production batches
> * have a portrait screen, the resolution checks makes the quirk
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330
2019-02-13 12:43 ` Thierry Reding via dri-devel
@ 2019-02-13 17:18 ` David Santamaría Rogado via dri-devel
2019-02-14 10:53 ` Thierry Reding via dri-devel
0 siblings, 1 reply; 6+ messages in thread
From: David Santamaría Rogado via dri-devel @ 2019-02-13 17:18 UTC (permalink / raw)
To: Thierry Reding; +Cc: David Airlie, dri-devel
I was about to forget the signed off like the void removal patch, so I
mistake adding it just with @ as at. I can resend it with mail
corrected.
I can't see the white spaces issue, The whitespaces issue I send it
like the mails before as text without format. Anyways I can resend
this entire patch if needed.
Thanks for your attention.
El mié., 13 feb. 2019 a las 13:43, Thierry Reding
(<thierry.reding@gmail.com>) escribió:
>
> On Wed, Feb 13, 2019 at 11:14:51AM +0100, David Santamaría Rogado wrote:
> > Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console
> > ouput gets rotated at boot as Miix 310.
> >
> > Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
>
> Is something obfuscating your email address here?
>
> > ---
> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 61d3361381b73..835574e2d5bf7 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data
> > lcd800x1280_rightside_up = {
> > .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> > };
> >
> > +static const struct drm_dmi_panel_orientation_data
> > lcd1200x1920_rightside_up = {
> > + .width = 1200,
> > + .height = 1920,
> > + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> > +};
> > +
>
> Looks like that something may be messing up the whitespace in your patch
> as well.
>
> Thierry
>
> > static const struct dmi_system_id orientation_data[] = {
> > { /* Acer One 10 (S1003) */
> > .matches = {
> > @@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = {
> > DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
> > },
> > .driver_data = &itworks_tw891,
> > + }, { /* Lenovo Ideapad D330 */
> > + .matches = {
> > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
> > + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
> > + },
> > + .driver_data = &lcd1200x1920_rightside_up,
> > }, { /*
> > * Lenovo Ideapad Miix 310 laptop, only some production batches
> > * have a portrait screen, the resolution checks makes the quirk
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330
2019-02-13 17:18 ` David Santamaría Rogado via dri-devel
@ 2019-02-14 10:53 ` Thierry Reding via dri-devel
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding via dri-devel @ 2019-02-14 10:53 UTC (permalink / raw)
To: David Santamaría Rogado; +Cc: David Airlie, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2436 bytes --]
On Wed, Feb 13, 2019 at 06:18:26PM +0100, David Santamaría Rogado wrote:
> I was about to forget the signed off like the void removal patch, so I
> mistake adding it just with @ as at. I can resend it with mail
> corrected.
>
> I can't see the white spaces issue, The whitespaces issue I send it
> like the mails before as text without format. Anyways I can resend
> this entire patch if needed.
Resending is probably not going to help if we don't figure out first
what's messing with the whitespace.
> Thanks for your attention.
>
> El mié., 13 feb. 2019 a las 13:43, Thierry Reding
> (<thierry.reding@gmail.com>) escribió:
> >
> > On Wed, Feb 13, 2019 at 11:14:51AM +0100, David Santamaría Rogado wrote:
> > > Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console
> > > ouput gets rotated at boot as Miix 310.
> > >
> > > Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
> >
> > Is something obfuscating your email address here?
> >
> > > ---
> > > drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > index 61d3361381b73..835574e2d5bf7 100644
> > > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data
> > > lcd800x1280_rightside_up = {
> > > .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> > > };
> > >
> > > +static const struct drm_dmi_panel_orientation_data
> > > lcd1200x1920_rightside_up = {
> > > + .width = 1200,
> > > + .height = 1920,
> > > + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> > > +};
> > > +
> >
> > Looks like that something may be messing up the whitespace in your patch
> > as well.
If you look at what arrived in my inbox, there is a single space after
the + for the lines in the patch. There should be a tab if you've
correctly followed the existing indentation in the file. Given that a
single space is also present for existing lines (those without a +), I
think you must've either generated the patch in a non-standard way, or
your email client or server are getting in the way.
Are you using gmail to send this patch? Also, are you using git
send-email?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330
@ 2019-01-03 20:40 David Santamaría Rogado
2019-01-21 1:12 ` David Santamaría Rogado
0 siblings, 1 reply; 6+ messages in thread
From: David Santamaría Rogado @ 2019-01-03 20:40 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Thierry Reding, dri-devel
Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console
ouput gets rotated at boot as Miix 310.
Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 52e445bb1aa58..521aff99b08a6 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data
lcd800x1280_rightside_up = {
.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
};
+static const struct drm_dmi_panel_orientation_data
lcd1200x1920_rightside_up = {
+ .width = 1200,
+ .height = 1920,
+ .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
static const struct dmi_system_id orientation_data[] = {
{ /* Acer One 10 (S1003) */
.matches = {
@@ -148,6 +154,13 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
},
.driver_data = (void *)&lcd800x1280_rightside_up,
+ }, { /* Lenovo Ideapad D330 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+ },
+ .driver_data = (void *)&lcd1200x1920_rightside_up,
}, { /* VIOS LTH17 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330
2019-01-03 20:40 David Santamaría Rogado
@ 2019-01-21 1:12 ` David Santamaría Rogado
0 siblings, 0 replies; 6+ messages in thread
From: David Santamaría Rogado @ 2019-01-21 1:12 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Thierry Reding, dri-devel
There are also 1280x800 versions of the Ideapad D330. I don't know the
dmi strings for the lower versions, but they could be equal between
versions of the same model.
Could be possible to add orientation_data matrix elements with the
same dmi strings and different driver data to complain both
resolutions?
If I or someone could get dmi strings from one of these models I can
write patch v2.
If someone can review this and explain the situation of two
resolutions in the same model, would be great.
Is needed to provide a way to verify the dmi strings?
El jue., 3 ene. 2019 a las 21:40, David Santamaría Rogado
(<howl.nsp@gmail.com>) escribió:
>
> Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console
> ouput gets rotated at boot as Miix 310.
>
> Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com>
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 52e445bb1aa58..521aff99b08a6 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data
> lcd800x1280_rightside_up = {
> .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> };
>
> +static const struct drm_dmi_panel_orientation_data
> lcd1200x1920_rightside_up = {
> + .width = 1200,
> + .height = 1920,
> + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> +};
> +
> static const struct dmi_system_id orientation_data[] = {
> { /* Acer One 10 (S1003) */
> .matches = {
> @@ -148,6 +154,13 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
> },
> .driver_data = (void *)&lcd800x1280_rightside_up,
> + }, { /* Lenovo Ideapad D330 */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
> + },
> + .driver_data = (void *)&lcd1200x1920_rightside_up,
> }, { /* VIOS LTH17 */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-14 10:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-13 10:14 [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330 David Santamaría Rogado via dri-devel
2019-02-13 12:43 ` Thierry Reding via dri-devel
2019-02-13 17:18 ` David Santamaría Rogado via dri-devel
2019-02-14 10:53 ` Thierry Reding via dri-devel
-- strict thread matches above, loose matches on Subject: below --
2019-01-03 20:40 David Santamaría Rogado
2019-01-21 1:12 ` David Santamaría Rogado
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.