* [PATCH 0/3] PM / devfreq: do some cleanup @ 2019-02-16 15:18 ` Yangtao Li 0 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra, Yangtao Li The informations come from the coccinelle tool. drivers/devfreq/tegra-devfreq.c:577:5-8: Unneeded variable: "ret". Return "0" on line 603 drivers/devfreq/rk3399_dmc.c:325:2-3: Unneeded semicolon drivers/devfreq/event/rockchip-dfi.c:214:2-3: Unneeded semicolon Yangtao Li (3): PM / devfreq: rk3399_dmc: remove unneeded semicolon PM / devfreq: rockchip-dfi: remove unneeded semicolon PM / devfreq: tegra: remove unneeded variable drivers/devfreq/event/rockchip-dfi.c | 2 +- drivers/devfreq/rk3399_dmc.c | 2 +- drivers/devfreq/tegra-devfreq.c | 7 ++----- 3 files changed, 4 insertions(+), 7 deletions(-) -- 2.17.0 ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 0/3] PM / devfreq: do some cleanup @ 2019-02-16 15:18 ` Yangtao Li 0 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, Yangtao Li, linux-kernel, linux-rockchip, linux-tegra, linux-arm-kernel The informations come from the coccinelle tool. drivers/devfreq/tegra-devfreq.c:577:5-8: Unneeded variable: "ret". Return "0" on line 603 drivers/devfreq/rk3399_dmc.c:325:2-3: Unneeded semicolon drivers/devfreq/event/rockchip-dfi.c:214:2-3: Unneeded semicolon Yangtao Li (3): PM / devfreq: rk3399_dmc: remove unneeded semicolon PM / devfreq: rockchip-dfi: remove unneeded semicolon PM / devfreq: tegra: remove unneeded variable drivers/devfreq/event/rockchip-dfi.c | 2 +- drivers/devfreq/rk3399_dmc.c | 2 +- drivers/devfreq/tegra-devfreq.c | 7 ++----- 3 files changed, 4 insertions(+), 7 deletions(-) -- 2.17.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon 2019-02-16 15:18 ` Yangtao Li @ 2019-02-16 15:18 ` Yangtao Li -1 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra, Yangtao Li The semicolon is unneeded, so remove it. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/devfreq/rk3399_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index e795ad2b3f6b..a228dad2bee4 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) dev_err(dev, "Cannot get the clk dmc_clk\n"); return PTR_ERR(data->dmc_clk); - }; + } data->edev = devfreq_event_get_edev_by_phandle(dev, 0); if (IS_ERR(data->edev)) -- 2.17.0 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon @ 2019-02-16 15:18 ` Yangtao Li 0 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, Yangtao Li, linux-kernel, linux-rockchip, linux-tegra, linux-arm-kernel The semicolon is unneeded, so remove it. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/devfreq/rk3399_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index e795ad2b3f6b..a228dad2bee4 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) dev_err(dev, "Cannot get the clk dmc_clk\n"); return PTR_ERR(data->dmc_clk); - }; + } data->edev = devfreq_event_get_edev_by_phandle(dev, 0); if (IS_ERR(data->edev)) -- 2.17.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 25+ messages in thread
[parent not found: <20190216151826.11584-2-tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon 2019-02-16 15:18 ` Yangtao Li (?) @ 2019-02-18 0:34 ` Chanwoo Choi -1 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:34 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ, heiko-4mtYJXux2i+zQB+pC5nmwQ, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, jonathanh-DDmLM1+adcrQT0dZR+AlfA Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-pm-u79uwXL29TY76Z2rM5mHXA Hi, On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > The semicolon is unneeded, so remove it. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/rk3399_dmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > index e795ad2b3f6b..a228dad2bee4 100644 > --- a/drivers/devfreq/rk3399_dmc.c > +++ b/drivers/devfreq/rk3399_dmc.c > @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) > > dev_err(dev, "Cannot get the clk dmc_clk\n"); > return PTR_ERR(data->dmc_clk); > - }; > + } > > data->edev = devfreq_event_get_edev_by_phandle(dev, 0); > if (IS_ERR(data->edev)) > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon @ 2019-02-18 0:34 ` Chanwoo Choi 0 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:34 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra Hi, On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > The semicolon is unneeded, so remove it. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/rk3399_dmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > index e795ad2b3f6b..a228dad2bee4 100644 > --- a/drivers/devfreq/rk3399_dmc.c > +++ b/drivers/devfreq/rk3399_dmc.c > @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) > > dev_err(dev, "Cannot get the clk dmc_clk\n"); > return PTR_ERR(data->dmc_clk); > - }; > + } > > data->edev = devfreq_event_get_edev_by_phandle(dev, 0); > if (IS_ERR(data->edev)) > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon @ 2019-02-18 0:34 ` Chanwoo Choi 0 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:34 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-tegra, linux-rockchip, linux-kernel, linux-arm-kernel, linux-pm Hi, On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > The semicolon is unneeded, so remove it. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/rk3399_dmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > index e795ad2b3f6b..a228dad2bee4 100644 > --- a/drivers/devfreq/rk3399_dmc.c > +++ b/drivers/devfreq/rk3399_dmc.c > @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) > > dev_err(dev, "Cannot get the clk dmc_clk\n"); > return PTR_ERR(data->dmc_clk); > - }; > + } > > data->edev = devfreq_event_get_edev_by_phandle(dev, 0); > if (IS_ERR(data->edev)) > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon 2019-02-18 0:34 ` Chanwoo Choi @ 2019-02-20 13:55 ` MyungJoo Ham -1 siblings, 0 replies; 25+ messages in thread From: MyungJoo Ham @ 2019-02-20 13:55 UTC (permalink / raw) To: Chanwoo Choi Cc: Yangtao Li, Kyungmin Park, Heiko Stübner, Thierry Reding, Jonathan Hunter, Linux PM list, linux-arm-kernel, linux-rockchip, LKML, linux-tegra On Mon, Feb 18, 2019 at 10:09 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > Hi, > > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > > The semicolon is unneeded, so remove it. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/devfreq/rk3399_dmc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > > index e795ad2b3f6b..a228dad2bee4 100644 > > --- a/drivers/devfreq/rk3399_dmc.c > > +++ b/drivers/devfreq/rk3399_dmc.c > > @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) > > > > dev_err(dev, "Cannot get the clk dmc_clk\n"); > > return PTR_ERR(data->dmc_clk); > > - }; > > + } > > > > data->edev = devfreq_event_get_edev_by_phandle(dev, 0); > > if (IS_ERR(data->edev)) > > > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Merged. > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon @ 2019-02-20 13:55 ` MyungJoo Ham 0 siblings, 0 replies; 25+ messages in thread From: MyungJoo Ham @ 2019-02-20 13:55 UTC (permalink / raw) To: Chanwoo Choi Cc: Heiko Stübner, Linux PM list, Yangtao Li, LKML, Jonathan Hunter, linux-rockchip, Kyungmin Park, Thierry Reding, linux-tegra, linux-arm-kernel On Mon, Feb 18, 2019 at 10:09 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > Hi, > > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > > The semicolon is unneeded, so remove it. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/devfreq/rk3399_dmc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > > index e795ad2b3f6b..a228dad2bee4 100644 > > --- a/drivers/devfreq/rk3399_dmc.c > > +++ b/drivers/devfreq/rk3399_dmc.c > > @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) > > > > dev_err(dev, "Cannot get the clk dmc_clk\n"); > > return PTR_ERR(data->dmc_clk); > > - }; > > + } > > > > data->edev = devfreq_event_get_edev_by_phandle(dev, 0); > > if (IS_ERR(data->edev)) > > > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Merged. > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon 2019-02-16 15:18 ` Yangtao Li @ 2019-02-16 15:18 ` Yangtao Li -1 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra, Yangtao Li The semicolon is unneeded, so remove it. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/devfreq/event/rockchip-dfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c index 22b113363ffc..fcbf76ebf55d 100644 --- a/drivers/devfreq/event/rockchip-dfi.c +++ b/drivers/devfreq/event/rockchip-dfi.c @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) if (IS_ERR(data->clk)) { dev_err(dev, "Cannot get the clk dmc_clk\n"); return PTR_ERR(data->clk); - }; + } /* try to find the optional reference to the pmu syscon */ node = of_parse_phandle(np, "rockchip,pmu", 0); -- 2.17.0 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon @ 2019-02-16 15:18 ` Yangtao Li 0 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, Yangtao Li, linux-kernel, linux-rockchip, linux-tegra, linux-arm-kernel The semicolon is unneeded, so remove it. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/devfreq/event/rockchip-dfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c index 22b113363ffc..fcbf76ebf55d 100644 --- a/drivers/devfreq/event/rockchip-dfi.c +++ b/drivers/devfreq/event/rockchip-dfi.c @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) if (IS_ERR(data->clk)) { dev_err(dev, "Cannot get the clk dmc_clk\n"); return PTR_ERR(data->clk); - }; + } /* try to find the optional reference to the pmu syscon */ node = of_parse_phandle(np, "rockchip,pmu", 0); -- 2.17.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 25+ messages in thread
[parent not found: <20190216151826.11584-3-tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon 2019-02-16 15:18 ` Yangtao Li (?) @ 2019-02-18 0:35 ` Chanwoo Choi -1 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:35 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ, heiko-4mtYJXux2i+zQB+pC5nmwQ, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, jonathanh-DDmLM1+adcrQT0dZR+AlfA Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-pm-u79uwXL29TY76Z2rM5mHXA Hi, On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > The semicolon is unneeded, so remove it. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/event/rockchip-dfi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 22b113363ffc..fcbf76ebf55d 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > if (IS_ERR(data->clk)) { > dev_err(dev, "Cannot get the clk dmc_clk\n"); > return PTR_ERR(data->clk); > - }; > + } > > /* try to find the optional reference to the pmu syscon */ > node = of_parse_phandle(np, "rockchip,pmu", 0); > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon @ 2019-02-18 0:35 ` Chanwoo Choi 0 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:35 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra Hi, On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > The semicolon is unneeded, so remove it. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/event/rockchip-dfi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 22b113363ffc..fcbf76ebf55d 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > if (IS_ERR(data->clk)) { > dev_err(dev, "Cannot get the clk dmc_clk\n"); > return PTR_ERR(data->clk); > - }; > + } > > /* try to find the optional reference to the pmu syscon */ > node = of_parse_phandle(np, "rockchip,pmu", 0); > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon @ 2019-02-18 0:35 ` Chanwoo Choi 0 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:35 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-tegra, linux-rockchip, linux-kernel, linux-arm-kernel, linux-pm Hi, On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > The semicolon is unneeded, so remove it. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/event/rockchip-dfi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 22b113363ffc..fcbf76ebf55d 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > if (IS_ERR(data->clk)) { > dev_err(dev, "Cannot get the clk dmc_clk\n"); > return PTR_ERR(data->clk); > - }; > + } > > /* try to find the optional reference to the pmu syscon */ > node = of_parse_phandle(np, "rockchip,pmu", 0); > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon 2019-02-18 0:35 ` Chanwoo Choi @ 2019-02-20 13:57 ` MyungJoo Ham -1 siblings, 0 replies; 25+ messages in thread From: MyungJoo Ham @ 2019-02-20 13:57 UTC (permalink / raw) To: Chanwoo Choi Cc: Yangtao Li, Kyungmin Park, Heiko Stübner, Thierry Reding, Jonathan Hunter, Linux PM list, linux-arm-kernel, linux-rockchip, LKML, linux-tegra On Mon, Feb 18, 2019 at 9:41 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > Hi, > > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > > The semicolon is unneeded, so remove it. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/devfreq/event/rockchip-dfi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > > index 22b113363ffc..fcbf76ebf55d 100644 > > --- a/drivers/devfreq/event/rockchip-dfi.c > > +++ b/drivers/devfreq/event/rockchip-dfi.c > > @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > > if (IS_ERR(data->clk)) { > > dev_err(dev, "Cannot get the clk dmc_clk\n"); > > return PTR_ERR(data->clk); > > - }; > > + } > > > > /* try to find the optional reference to the pmu syscon */ > > node = of_parse_phandle(np, "rockchip,pmu", 0); > > > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Merged. Thanks. > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 2/3] PM / devfreq: rockchip-dfi: remove unneeded semicolon @ 2019-02-20 13:57 ` MyungJoo Ham 0 siblings, 0 replies; 25+ messages in thread From: MyungJoo Ham @ 2019-02-20 13:57 UTC (permalink / raw) To: Chanwoo Choi Cc: Heiko Stübner, Linux PM list, Yangtao Li, LKML, Jonathan Hunter, linux-rockchip, Kyungmin Park, Thierry Reding, linux-tegra, linux-arm-kernel On Mon, Feb 18, 2019 at 9:41 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > Hi, > > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > > The semicolon is unneeded, so remove it. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/devfreq/event/rockchip-dfi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > > index 22b113363ffc..fcbf76ebf55d 100644 > > --- a/drivers/devfreq/event/rockchip-dfi.c > > +++ b/drivers/devfreq/event/rockchip-dfi.c > > @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > > if (IS_ERR(data->clk)) { > > dev_err(dev, "Cannot get the clk dmc_clk\n"); > > return PTR_ERR(data->clk); > > - }; > > + } > > > > /* try to find the optional reference to the pmu syscon */ > > node = of_parse_phandle(np, "rockchip,pmu", 0); > > > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Merged. Thanks. > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable 2019-02-16 15:18 ` Yangtao Li @ 2019-02-16 15:18 ` Yangtao Li -1 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra, Yangtao Li This variable is not used after initialization, so remove it. And in order to unify the code style, move the location where the dev_get_drvdata is called by the way. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/devfreq/tegra-devfreq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index c59d2eee5d30..c89ba7b834ff 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, static int tegra_governor_event_handler(struct devfreq *devfreq, unsigned int event, void *data) { - struct tegra_devfreq *tegra; - int ret = 0; - - tegra = dev_get_drvdata(devfreq->dev.parent); + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); switch (event) { case DEVFREQ_GOV_START: @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, break; } - return ret; + return 0; } static struct devfreq_governor tegra_devfreq_governor = { -- 2.17.0 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable @ 2019-02-16 15:18 ` Yangtao Li 0 siblings, 0 replies; 25+ messages in thread From: Yangtao Li @ 2019-02-16 15:18 UTC (permalink / raw) To: cw00.choi, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, Yangtao Li, linux-kernel, linux-rockchip, linux-tegra, linux-arm-kernel This variable is not used after initialization, so remove it. And in order to unify the code style, move the location where the dev_get_drvdata is called by the way. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/devfreq/tegra-devfreq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index c59d2eee5d30..c89ba7b834ff 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, static int tegra_governor_event_handler(struct devfreq *devfreq, unsigned int event, void *data) { - struct tegra_devfreq *tegra; - int ret = 0; - - tegra = dev_get_drvdata(devfreq->dev.parent); + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); switch (event) { case DEVFREQ_GOV_START: @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, break; } - return ret; + return 0; } static struct devfreq_governor tegra_devfreq_governor = { -- 2.17.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable 2019-02-16 15:18 ` Yangtao Li @ 2019-02-18 0:38 ` Chanwoo Choi -1 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:38 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-tegra, linux-rockchip, linux-kernel, linux-arm-kernel, linux-pm On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > This variable is not used after initialization, so > remove it. And in order to unify the code style, > move the location where the dev_get_drvdata is called > by the way. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/tegra-devfreq.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index c59d2eee5d30..c89ba7b834ff 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, > static int tegra_governor_event_handler(struct devfreq *devfreq, > unsigned int event, void *data) > { > - struct tegra_devfreq *tegra; > - int ret = 0; > - > - tegra = dev_get_drvdata(devfreq->dev.parent); > + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); > > switch (event) { > case DEVFREQ_GOV_START: > @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, > break; > } > > - return ret; > + return 0; > } > > static struct devfreq_governor tegra_devfreq_governor = { > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable @ 2019-02-18 0:38 ` Chanwoo Choi 0 siblings, 0 replies; 25+ messages in thread From: Chanwoo Choi @ 2019-02-18 0:38 UTC (permalink / raw) To: Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding, jonathanh Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > This variable is not used after initialization, so > remove it. And in order to unify the code style, > move the location where the dev_get_drvdata is called > by the way. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/tegra-devfreq.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index c59d2eee5d30..c89ba7b834ff 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, > static int tegra_governor_event_handler(struct devfreq *devfreq, > unsigned int event, void *data) > { > - struct tegra_devfreq *tegra; > - int ret = 0; > - > - tegra = dev_get_drvdata(devfreq->dev.parent); > + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); > > switch (event) { > case DEVFREQ_GOV_START: > @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, > break; > } > > - return ret; > + return 0; > } > > static struct devfreq_governor tegra_devfreq_governor = { > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable 2019-02-18 0:38 ` Chanwoo Choi (?) @ 2019-02-18 9:55 ` Jon Hunter -1 siblings, 0 replies; 25+ messages in thread From: Jon Hunter @ 2019-02-18 9:55 UTC (permalink / raw) To: Chanwoo Choi, Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra On 18/02/2019 00:38, Chanwoo Choi wrote: > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: >> This variable is not used after initialization, so >> remove it. And in order to unify the code style, >> move the location where the dev_get_drvdata is called >> by the way. >> >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> >> --- >> drivers/devfreq/tegra-devfreq.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index c59d2eee5d30..c89ba7b834ff 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, >> static int tegra_governor_event_handler(struct devfreq *devfreq, >> unsigned int event, void *data) >> { >> - struct tegra_devfreq *tegra; >> - int ret = 0; >> - >> - tegra = dev_get_drvdata(devfreq->dev.parent); >> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); >> >> switch (event) { >> case DEVFREQ_GOV_START: >> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, >> break; >> } >> >> - return ret; >> + return 0; >> } >> >> static struct devfreq_governor tegra_devfreq_governor = { >> > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Jon Hunter <jonathanh@nvidia.com> Thanks! Jon -- nvpublic ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable @ 2019-02-18 9:55 ` Jon Hunter 0 siblings, 0 replies; 25+ messages in thread From: Jon Hunter @ 2019-02-18 9:55 UTC (permalink / raw) To: Chanwoo Choi, Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, linux-tegra On 18/02/2019 00:38, Chanwoo Choi wrote: > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: >> This variable is not used after initialization, so >> remove it. And in order to unify the code style, >> move the location where the dev_get_drvdata is called >> by the way. >> >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> >> --- >> drivers/devfreq/tegra-devfreq.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index c59d2eee5d30..c89ba7b834ff 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, >> static int tegra_governor_event_handler(struct devfreq *devfreq, >> unsigned int event, void *data) >> { >> - struct tegra_devfreq *tegra; >> - int ret = 0; >> - >> - tegra = dev_get_drvdata(devfreq->dev.parent); >> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); >> >> switch (event) { >> case DEVFREQ_GOV_START: >> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, >> break; >> } >> >> - return ret; >> + return 0; >> } >> >> static struct devfreq_governor tegra_devfreq_governor = { >> > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Jon Hunter <jonathanh@nvidia.com> Thanks! Jon -- nvpublic ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable @ 2019-02-18 9:55 ` Jon Hunter 0 siblings, 0 replies; 25+ messages in thread From: Jon Hunter @ 2019-02-18 9:55 UTC (permalink / raw) To: Chanwoo Choi, Yangtao Li, myungjoo.ham, kyungmin.park, heiko, thierry.reding Cc: linux-tegra, linux-rockchip, linux-kernel, linux-arm-kernel, linux-pm On 18/02/2019 00:38, Chanwoo Choi wrote: > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: >> This variable is not used after initialization, so >> remove it. And in order to unify the code style, >> move the location where the dev_get_drvdata is called >> by the way. >> >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> >> --- >> drivers/devfreq/tegra-devfreq.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index c59d2eee5d30..c89ba7b834ff 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, >> static int tegra_governor_event_handler(struct devfreq *devfreq, >> unsigned int event, void *data) >> { >> - struct tegra_devfreq *tegra; >> - int ret = 0; >> - >> - tegra = dev_get_drvdata(devfreq->dev.parent); >> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); >> >> switch (event) { >> case DEVFREQ_GOV_START: >> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, >> break; >> } >> >> - return ret; >> + return 0; >> } >> >> static struct devfreq_governor tegra_devfreq_governor = { >> > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Jon Hunter <jonathanh@nvidia.com> Thanks! Jon -- nvpublic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable 2019-02-18 9:55 ` Jon Hunter @ 2019-02-20 14:25 ` MyungJoo Ham -1 siblings, 0 replies; 25+ messages in thread From: MyungJoo Ham @ 2019-02-20 14:25 UTC (permalink / raw) To: Jon Hunter Cc: Chanwoo Choi, Yangtao Li, Kyungmin Park, Heiko Stübner, Thierry Reding, Linux PM list, linux-arm-kernel, linux-rockchip, LKML, linux-tegra On Mon, Feb 18, 2019 at 6:58 PM Jon Hunter <jonathanh@nvidia.com> wrote: > > > On 18/02/2019 00:38, Chanwoo Choi wrote: > > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > >> This variable is not used after initialization, so > >> remove it. And in order to unify the code style, > >> move the location where the dev_get_drvdata is called > >> by the way. > >> > >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > >> --- > >> drivers/devfreq/tegra-devfreq.c | 7 ++----- > >> 1 file changed, 2 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > >> index c59d2eee5d30..c89ba7b834ff 100644 > >> --- a/drivers/devfreq/tegra-devfreq.c > >> +++ b/drivers/devfreq/tegra-devfreq.c > >> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, > >> static int tegra_governor_event_handler(struct devfreq *devfreq, > >> unsigned int event, void *data) > >> { > >> - struct tegra_devfreq *tegra; > >> - int ret = 0; > >> - > >> - tegra = dev_get_drvdata(devfreq->dev.parent); > >> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); > >> > >> switch (event) { > >> case DEVFREQ_GOV_START: > >> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, > >> break; > >> } > >> > >> - return ret; > >> + return 0; > >> } > >> > >> static struct devfreq_governor tegra_devfreq_governor = { > >> > > > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > > > Acked-by: Jon Hunter <jonathanh@nvidia.com> > > Thanks! > Jon Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Merged. Thanks! > > -- > nvpublic -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable @ 2019-02-20 14:25 ` MyungJoo Ham 0 siblings, 0 replies; 25+ messages in thread From: MyungJoo Ham @ 2019-02-20 14:25 UTC (permalink / raw) To: Jon Hunter Cc: Heiko Stübner, Linux PM list, Yangtao Li, LKML, Chanwoo Choi, Kyungmin Park, Thierry Reding, linux-tegra, linux-rockchip, linux-arm-kernel On Mon, Feb 18, 2019 at 6:58 PM Jon Hunter <jonathanh@nvidia.com> wrote: > > > On 18/02/2019 00:38, Chanwoo Choi wrote: > > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: > >> This variable is not used after initialization, so > >> remove it. And in order to unify the code style, > >> move the location where the dev_get_drvdata is called > >> by the way. > >> > >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > >> --- > >> drivers/devfreq/tegra-devfreq.c | 7 ++----- > >> 1 file changed, 2 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > >> index c59d2eee5d30..c89ba7b834ff 100644 > >> --- a/drivers/devfreq/tegra-devfreq.c > >> +++ b/drivers/devfreq/tegra-devfreq.c > >> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq, > >> static int tegra_governor_event_handler(struct devfreq *devfreq, > >> unsigned int event, void *data) > >> { > >> - struct tegra_devfreq *tegra; > >> - int ret = 0; > >> - > >> - tegra = dev_get_drvdata(devfreq->dev.parent); > >> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); > >> > >> switch (event) { > >> case DEVFREQ_GOV_START: > >> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, > >> break; > >> } > >> > >> - return ret; > >> + return 0; > >> } > >> > >> static struct devfreq_governor tegra_devfreq_governor = { > >> > > > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > > > Acked-by: Jon Hunter <jonathanh@nvidia.com> > > Thanks! > Jon Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Merged. Thanks! > > -- > nvpublic -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2019-02-20 14:26 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-16 15:18 [PATCH 0/3] PM / devfreq: do some cleanup Yangtao Li
2019-02-16 15:18 ` Yangtao Li
2019-02-16 15:18 ` [PATCH 1/3] PM / devfreq: rk3399_dmc: remove unneeded semicolon Yangtao Li
2019-02-16 15:18 ` Yangtao Li
[not found] ` <20190216151826.11584-2-tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-18 0:34 ` Chanwoo Choi
2019-02-18 0:34 ` Chanwoo Choi
2019-02-18 0:34 ` Chanwoo Choi
2019-02-20 13:55 ` MyungJoo Ham
2019-02-20 13:55 ` MyungJoo Ham
2019-02-16 15:18 ` [PATCH 2/3] PM / devfreq: rockchip-dfi: " Yangtao Li
2019-02-16 15:18 ` Yangtao Li
[not found] ` <20190216151826.11584-3-tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-18 0:35 ` Chanwoo Choi
2019-02-18 0:35 ` Chanwoo Choi
2019-02-18 0:35 ` Chanwoo Choi
2019-02-20 13:57 ` MyungJoo Ham
2019-02-20 13:57 ` MyungJoo Ham
2019-02-16 15:18 ` [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable Yangtao Li
2019-02-16 15:18 ` Yangtao Li
2019-02-18 0:38 ` Chanwoo Choi
2019-02-18 0:38 ` Chanwoo Choi
2019-02-18 9:55 ` Jon Hunter
2019-02-18 9:55 ` Jon Hunter
2019-02-18 9:55 ` Jon Hunter
2019-02-20 14:25 ` MyungJoo Ham
2019-02-20 14:25 ` MyungJoo Ham
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.