From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] carl9170: clean up a clamp() call
Date: Tue, 19 Feb 2019 15:18:31 +0000 [thread overview]
Message-ID: <20190219151831.77563608CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20190218093154.GC7712@kadam>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The parameter order for clamp is supposed to be clamp(value, low, high).
> When we write it in this order it's equivalent to
> min(head->plcp[3] & 0x7f, 75) which works in this context where the min
> is zero. But it's not a correct use of the API.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Christian Lamparter <chunkeey@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
dc76bb1e12e9 carl9170: clean up a clamp() call
--
https://patchwork.kernel.org/patch/10817541/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] carl9170: clean up a clamp() call
Date: Tue, 19 Feb 2019 15:18:31 +0000 (UTC) [thread overview]
Message-ID: <20190219151831.77563608CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20190218093154.GC7712@kadam>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The parameter order for clamp is supposed to be clamp(value, low, high).
> When we write it in this order it's equivalent to
> min(head->plcp[3] & 0x7f, 75) which works in this context where the min
> is zero. But it's not a correct use of the API.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Christian Lamparter <chunkeey@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
dc76bb1e12e9 carl9170: clean up a clamp() call
--
https://patchwork.kernel.org/patch/10817541/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-02-19 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 9:31 [PATCH] carl9170: clean up a clamp() call Dan Carpenter
2019-02-18 9:31 ` Dan Carpenter
2019-02-18 16:04 ` Christian Lamparter
2019-02-18 16:04 ` Christian Lamparter
2019-02-19 15:18 ` Kalle Valo [this message]
2019-02-19 15:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219151831.77563608CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=chunkeey@googlemail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.