From: Christian Lamparter <chunkeey@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] carl9170: clean up a clamp() call
Date: Mon, 18 Feb 2019 16:04:49 +0000 [thread overview]
Message-ID: <2108216.StK4OeqmAv@debian64> (raw)
In-Reply-To: <20190218093154.GC7712@kadam>
On Monday, February 18, 2019 10:31:54 AM CET Dan Carpenter wrote:
> The parameter order for clamp is supposed to be clamp(value, low, high).
> When we write it in this order it's equivalent to
> min(head->plcp[3] & 0x7f, 75) which works in this context where the min
> is zero. But it's not a correct use of the API.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/net/wireless/ath/carl9170/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c
> index f7c2f19e81c1..8e154f6364a3 100644
> --- a/drivers/net/wireless/ath/carl9170/rx.c
> +++ b/drivers/net/wireless/ath/carl9170/rx.c
> @@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,
> if (head->plcp[6] & 0x80)
> status->enc_flags |= RX_ENC_FLAG_SHORT_GI;
>
> - status->rate_idx = clamp(0, 75, head->plcp[3] & 0x7f);
> + status->rate_idx = clamp(head->plcp[3] & 0x7f, 0, 75);
> status->encoding = RX_ENC_HT;
> break;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Christian Lamparter <chunkeey@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] carl9170: clean up a clamp() call
Date: Mon, 18 Feb 2019 17:04:49 +0100 [thread overview]
Message-ID: <2108216.StK4OeqmAv@debian64> (raw)
In-Reply-To: <20190218093154.GC7712@kadam>
On Monday, February 18, 2019 10:31:54 AM CET Dan Carpenter wrote:
> The parameter order for clamp is supposed to be clamp(value, low, high).
> When we write it in this order it's equivalent to
> min(head->plcp[3] & 0x7f, 75) which works in this context where the min
> is zero. But it's not a correct use of the API.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/net/wireless/ath/carl9170/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c
> index f7c2f19e81c1..8e154f6364a3 100644
> --- a/drivers/net/wireless/ath/carl9170/rx.c
> +++ b/drivers/net/wireless/ath/carl9170/rx.c
> @@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,
> if (head->plcp[6] & 0x80)
> status->enc_flags |= RX_ENC_FLAG_SHORT_GI;
>
> - status->rate_idx = clamp(0, 75, head->plcp[3] & 0x7f);
> + status->rate_idx = clamp(head->plcp[3] & 0x7f, 0, 75);
> status->encoding = RX_ENC_HT;
> break;
>
>
next prev parent reply other threads:[~2019-02-18 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 9:31 [PATCH] carl9170: clean up a clamp() call Dan Carpenter
2019-02-18 9:31 ` Dan Carpenter
2019-02-18 16:04 ` Christian Lamparter [this message]
2019-02-18 16:04 ` Christian Lamparter
2019-02-19 15:18 ` Kalle Valo
2019-02-19 15:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2108216.StK4OeqmAv@debian64 \
--to=chunkeey@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.