From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static
Date: Wed, 20 Feb 2019 10:45:56 +0000 [thread overview]
Message-ID: <20190220104556.GO17104@kadam> (raw)
In-Reply-To: <CAFA6WYODEymSPh6gQjUL3wRmoPy=zoMv-Z1Q1TbKtWFH=UUgMw@mail.gmail.com>
On Wed, Feb 20, 2019 at 04:04:17PM +0530, Sumit Garg wrote:
> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> >
> > Fixes the following sparse warning:
^^^^^^
> >
> > drivers/char/hw_random/optee-rng.c:265:35: warning:
> > symbol 'optee_rng_id_table' was not declared. Should it be static?
> >
>
> I haven't observed this warning during my normal Linux build using
> gcc. Is there any specific configuration you are using?
>
It's from the Sparse tool.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static
Date: Wed, 20 Feb 2019 13:45:56 +0300 [thread overview]
Message-ID: <20190220104556.GO17104@kadam> (raw)
In-Reply-To: <CAFA6WYODEymSPh6gQjUL3wRmoPy=zoMv-Z1Q1TbKtWFH=UUgMw@mail.gmail.com>
On Wed, Feb 20, 2019 at 04:04:17PM +0530, Sumit Garg wrote:
> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> >
> > Fixes the following sparse warning:
^^^^^^
> >
> > drivers/char/hw_random/optee-rng.c:265:35: warning:
> > symbol 'optee_rng_id_table' was not declared. Should it be static?
> >
>
> I haven't observed this warning during my normal Linux build using
> gcc. Is there any specific configuration you are using?
>
It's from the Sparse tool.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-20 10:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 9:34 [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static Wei Yongjun
2019-02-20 9:34 ` Wei Yongjun
2019-02-20 10:34 ` Sumit Garg
2019-02-20 10:46 ` Sumit Garg
2019-02-20 10:37 ` Ard Biesheuvel
2019-02-20 10:37 ` Ard Biesheuvel
2019-02-20 10:49 ` Colin Ian King
2019-02-20 11:17 ` Sumit Garg
2019-02-20 11:29 ` Sumit Garg
2019-02-20 15:34 ` Arnd Bergmann
2019-02-20 15:34 ` Arnd Bergmann
2019-02-20 16:25 ` Sumit Garg
2019-02-20 16:37 ` Sumit Garg
2019-02-20 16:33 ` Greg Kroah-Hartman
2019-02-20 16:33 ` Greg Kroah-Hartman
2019-02-21 5:22 ` Sumit Garg
2019-02-21 5:34 ` Sumit Garg
2019-02-20 17:01 ` Arnd Bergmann
2019-02-20 17:01 ` Arnd Bergmann
2019-02-20 10:45 ` Dan Carpenter [this message]
2019-02-20 10:45 ` Dan Carpenter
2019-02-20 19:36 ` Jeffrey Walton
2019-02-20 19:36 ` Jeffrey Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220104556.GO17104@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=sumit.garg@linaro.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.