From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Colin Ian King <colin.king@canonical.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static
Date: Wed, 20 Feb 2019 16:33:13 +0000 [thread overview]
Message-ID: <20190220163313.GA3454@kroah.com> (raw)
In-Reply-To: <CAFA6WYNCxGTqw6LKUPK-ceWD1NbAhJQmzrH5fwOVRP5f2Auz2Q@mail.gmail.com>
On Wed, Feb 20, 2019 at 09:55:50PM +0530, Sumit Garg wrote:
> Hi Arnd,
>
> On Wed, 20 Feb 2019 at 21:04, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Wed, Feb 20, 2019 at 12:17 PM Sumit Garg <sumit.garg@linaro.org> wrote:
> > >
> > > On Wed, 20 Feb 2019 at 16:19, Colin Ian King <colin.king@canonical.com> wrote:
> > > >
> > > > On 20/02/2019 10:37, Ard Biesheuvel wrote:
> > > > > On Wed, 20 Feb 2019 at 11:34, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > >>
> > > > >> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> > > > >>>
> > > > >>> Fixes the following sparse warning:
> > > > >>>
> > > > >>> drivers/char/hw_random/optee-rng.c:265:35: warning:
> > > > >>> symbol 'optee_rng_id_table' was not declared. Should it be static?
> > > > >>>
> > > > >>
> > > > >> I haven't observed this warning during my normal Linux build using
> > > > >> gcc. Is there any specific configuration you are using?
> > > > >>
> > > > >
> > > > > This is a sparse warning, not GCC. You need to install it separately
> > > > > and build with C=1 (iirc)
> > > > >
> > >
> > > TBH, I wasn't aware about this sparse tool. I did install sparse and
> > > build with C=1 option. But I could only get following such
> > > errors/warnings for drivers/char/hw_random/optee-rng.c:
> > >
> > > ./arch/arm64/include/asm/lse.h:18:37: warning: Unknown escape 'l'
> > > ./arch/arm64/include/asm/alternative.h:213:28: warning: Unknown escape 'o'
> > > ./include/linux/compiler.h:194:8: error: attribute '__gnu_inline__':
> > > unknown attribute
> > >
> > > But not the one mentioned in this patch.
> >
> > Not sure what went wrong, I see the same warning as the others.
> > Maybe you have an outdated version of sparse that runs into unrelated
> > issues?
> >
>
> $ apt list sparse
> Listing... Done
> sparse/xenial,now 0.5.0-1build1 amd64 [installed]
Ick, really obsolete, please use the sparse version on kernel.org for
kernel stuff:
git://git.kernel.org/pub/scm/devel/sparse/sparse.git
Loads of things have been fixed and resolved from 0.5.0 which is very
old.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Colin Ian King <colin.king@canonical.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static
Date: Wed, 20 Feb 2019 17:33:13 +0100 [thread overview]
Message-ID: <20190220163313.GA3454@kroah.com> (raw)
In-Reply-To: <CAFA6WYNCxGTqw6LKUPK-ceWD1NbAhJQmzrH5fwOVRP5f2Auz2Q@mail.gmail.com>
On Wed, Feb 20, 2019 at 09:55:50PM +0530, Sumit Garg wrote:
> Hi Arnd,
>
> On Wed, 20 Feb 2019 at 21:04, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Wed, Feb 20, 2019 at 12:17 PM Sumit Garg <sumit.garg@linaro.org> wrote:
> > >
> > > On Wed, 20 Feb 2019 at 16:19, Colin Ian King <colin.king@canonical.com> wrote:
> > > >
> > > > On 20/02/2019 10:37, Ard Biesheuvel wrote:
> > > > > On Wed, 20 Feb 2019 at 11:34, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > >>
> > > > >> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> > > > >>>
> > > > >>> Fixes the following sparse warning:
> > > > >>>
> > > > >>> drivers/char/hw_random/optee-rng.c:265:35: warning:
> > > > >>> symbol 'optee_rng_id_table' was not declared. Should it be static?
> > > > >>>
> > > > >>
> > > > >> I haven't observed this warning during my normal Linux build using
> > > > >> gcc. Is there any specific configuration you are using?
> > > > >>
> > > > >
> > > > > This is a sparse warning, not GCC. You need to install it separately
> > > > > and build with C=1 (iirc)
> > > > >
> > >
> > > TBH, I wasn't aware about this sparse tool. I did install sparse and
> > > build with C=1 option. But I could only get following such
> > > errors/warnings for drivers/char/hw_random/optee-rng.c:
> > >
> > > ./arch/arm64/include/asm/lse.h:18:37: warning: Unknown escape 'l'
> > > ./arch/arm64/include/asm/alternative.h:213:28: warning: Unknown escape 'o'
> > > ./include/linux/compiler.h:194:8: error: attribute '__gnu_inline__':
> > > unknown attribute
> > >
> > > But not the one mentioned in this patch.
> >
> > Not sure what went wrong, I see the same warning as the others.
> > Maybe you have an outdated version of sparse that runs into unrelated
> > issues?
> >
>
> $ apt list sparse
> Listing... Done
> sparse/xenial,now 0.5.0-1build1 amd64 [installed]
Ick, really obsolete, please use the sparse version on kernel.org for
kernel stuff:
git://git.kernel.org/pub/scm/devel/sparse/sparse.git
Loads of things have been fixed and resolved from 0.5.0 which is very
old.
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-20 16:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 9:34 [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static Wei Yongjun
2019-02-20 9:34 ` Wei Yongjun
2019-02-20 10:34 ` Sumit Garg
2019-02-20 10:46 ` Sumit Garg
2019-02-20 10:37 ` Ard Biesheuvel
2019-02-20 10:37 ` Ard Biesheuvel
2019-02-20 10:49 ` Colin Ian King
2019-02-20 11:17 ` Sumit Garg
2019-02-20 11:29 ` Sumit Garg
2019-02-20 15:34 ` Arnd Bergmann
2019-02-20 15:34 ` Arnd Bergmann
2019-02-20 16:25 ` Sumit Garg
2019-02-20 16:37 ` Sumit Garg
2019-02-20 16:33 ` Greg Kroah-Hartman [this message]
2019-02-20 16:33 ` Greg Kroah-Hartman
2019-02-21 5:22 ` Sumit Garg
2019-02-21 5:34 ` Sumit Garg
2019-02-20 17:01 ` Arnd Bergmann
2019-02-20 17:01 ` Arnd Bergmann
2019-02-20 10:45 ` Dan Carpenter
2019-02-20 10:45 ` Dan Carpenter
2019-02-20 19:36 ` Jeffrey Walton
2019-02-20 19:36 ` Jeffrey Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220163313.GA3454@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=sumit.garg@linaro.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.