[PATCH 1/4] staging: netlogic: Add SPDX license Identifier

[PATCH 1/4] staging: netlogic: Add SPDX license Identifier

[Bhanusree Pola]

adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
Issue found with checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
 drivers/staging/netlogic/xlr_net.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h
index f76e16cfd15d..de51d64c1f23 100644
--- a/drivers/staging/netlogic/xlr_net.h
+++ b/drivers/staging/netlogic/xlr_net.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (c) 2003-2012 Broadcom Corporation
  * All Rights Reserved
-- 
2.17.1

Re: [PATCH 1/4] staging: netlogic: Add SPDX license Identifier

[Greg Kroah-Hartman]

On Thu, Feb 21, 2019 at 04:46:27PM +0530, Bhanusree Pola wrote:
> adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
> Issue found with checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/netlogic/xlr_net.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h
> index f76e16cfd15d..de51d64c1f23 100644
> --- a/drivers/staging/netlogic/xlr_net.h
> +++ b/drivers/staging/netlogic/xlr_net.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Wait, no, that is NOT the proper license for this file.  The text below
your added line spells that out in detail.

Never mess with licensing information unless you _REALLY_ know what you
are doing, as doing it wrong (like this), is much more dangerous than
leaving it alone.

So all of these are not correct at all, please be more careful.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH 1/4] staging: netlogic: Add SPDX license Identifier

[Greg Kroah-Hartman]

On Thu, Feb 21, 2019 at 12:24:55PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 21, 2019 at 04:46:27PM +0530, Bhanusree Pola wrote:
> > adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
> > Issue found with checkpatch.pl warning:
> > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> > 
> > Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> > ---
> >  drivers/staging/netlogic/xlr_net.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h
> > index f76e16cfd15d..de51d64c1f23 100644
> > --- a/drivers/staging/netlogic/xlr_net.h
> > +++ b/drivers/staging/netlogic/xlr_net.h
> > @@ -1,3 +1,4 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> 
> Wait, no, that is NOT the proper license for this file.  The text below
> your added line spells that out in detail.
> 
> Never mess with licensing information unless you _REALLY_ know what you
> are doing, as doing it wrong (like this), is much more dangerous than
> leaving it alone.

And, the reason that I didn't already put the proper SPDX line on these
files is that _I_ don't even know what the correct line should be.
Someone needs to do a bunch of research to determine that, if they
really want to fix this up.  Personally, there are many other more
interesting things to do in the kernel than mess with this :)

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH 1/4] staging: netlogic: Add SPDX license Identifier

[Bhanusree Mahesh]

On Thu, 21 Feb 2019 at 17:02, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Feb 21, 2019 at 12:24:55PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Feb 21, 2019 at 04:46:27PM +0530, Bhanusree Pola wrote:
> > > adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning
> > > Issue found with checkpatch.pl warning:
> > > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> > >
> > > Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> > > ---
> > >  drivers/staging/netlogic/xlr_net.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h
> > > index f76e16cfd15d..de51d64c1f23 100644
> > > --- a/drivers/staging/netlogic/xlr_net.h
> > > +++ b/drivers/staging/netlogic/xlr_net.h
> > > @@ -1,3 +1,4 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> >
> > Wait, no, that is NOT the proper license for this file.  The text below
> > your added line spells that out in detail.
> >
> > Never mess with licensing information unless you _REALLY_ know what you
> > are doing, as doing it wrong (like this), is much more dangerous than
> > leaving it alone.
>
> And, the reason that I didn't already put the proper SPDX line on these
> files is that _I_ don't even know what the correct line should be.
> Someone needs to do a bunch of research to determine that, if they
> really want to fix this up.  Personally, there are many other more
> interesting things to do in the kernel than mess with this :)

ok. I'll take care of that. :)
>
> thanks,
>
> greg k-h