All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <bbrezillon@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Julien Su <juliensu@mxic.com.tw>,
	Richard Weinberger <richard@nod.at>,
	Schrempf Frieder <frieder.schrempf@kontron.de>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 09/27] mtd: nand: ecc: Turn the software BCH implementation generic
Date: Thu, 21 Feb 2019 13:26:52 +0100	[thread overview]
Message-ID: <20190221132652.417f0c5d@kernel.org> (raw)
In-Reply-To: <20190221100216.25255-10-miquel.raynal@bootlin.com>

On Thu, 21 Feb 2019 11:01:58 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:


>  /**
> - * nand_bch_correct_data - [NAND Interface] Detect and correct bit error(s)
> - * @chip:	NAND chip object
> - * @buf:	raw data read from the chip
> - * @read_ecc:	ECC from the chip
> - * @calc_ecc:	the ECC calculated from raw data
> + * ecc_sw_bch_correct - Detect, correct and report bit error(s)
>   *
> - * Detect and correct bit errors for a data byte block
> + * @nand: NAND device
> + * @buf: Raw data read from the chip
> + * @read_ecc: ECC bytes from the chip
> + * @calc_ecc: ECC calculated from the raw data
> + *
> + * Detect and correct bit errors for a data block.
>   */
> -int nand_bch_correct_data(struct nand_chip *chip, unsigned char *buf,
> -			  unsigned char *read_ecc, unsigned char *calc_ecc)
> +int ecc_sw_bch_correct(struct nand_device *nand, unsigned char *buf,
> +		       unsigned char *read_ecc, unsigned char *calc_ecc)

I'd keep the nand_ prefix, as ECC is employed in other places in the
kernel and here the API is clearly tied to the nand_device object.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Julien Su <juliensu@mxic.com.tw>,
	Richard Weinberger <richard@nod.at>,
	Schrempf Frieder <frieder.schrempf@kontron.de>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 09/27] mtd: nand: ecc: Turn the software BCH implementation generic
Date: Thu, 21 Feb 2019 13:26:52 +0100	[thread overview]
Message-ID: <20190221132652.417f0c5d@kernel.org> (raw)
In-Reply-To: <20190221100216.25255-10-miquel.raynal@bootlin.com>

On Thu, 21 Feb 2019 11:01:58 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:


>  /**
> - * nand_bch_correct_data - [NAND Interface] Detect and correct bit error(s)
> - * @chip:	NAND chip object
> - * @buf:	raw data read from the chip
> - * @read_ecc:	ECC from the chip
> - * @calc_ecc:	the ECC calculated from raw data
> + * ecc_sw_bch_correct - Detect, correct and report bit error(s)
>   *
> - * Detect and correct bit errors for a data byte block
> + * @nand: NAND device
> + * @buf: Raw data read from the chip
> + * @read_ecc: ECC bytes from the chip
> + * @calc_ecc: ECC calculated from the raw data
> + *
> + * Detect and correct bit errors for a data block.
>   */
> -int nand_bch_correct_data(struct nand_chip *chip, unsigned char *buf,
> -			  unsigned char *read_ecc, unsigned char *calc_ecc)
> +int ecc_sw_bch_correct(struct nand_device *nand, unsigned char *buf,
> +		       unsigned char *read_ecc, unsigned char *calc_ecc)

I'd keep the nand_ prefix, as ECC is employed in other places in the
kernel and here the API is clearly tied to the nand_device object.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-21 12:27 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 10:01 [RFC PATCH 00/27] Introduce the generic ECC engine abstraction Miquel Raynal
2019-02-21 10:01 ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 01/27] mtd: nand: Move nand_device forward declaration to the top Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 02/27] mtd: nand: Compile in the NAND core by default Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 10:55   ` Boris Brezillon
2019-02-21 10:55     ` Boris Brezillon
2019-02-21 11:06     ` Miquel Raynal
2019-02-21 11:06       ` Miquel Raynal
2019-02-21 11:14       ` Boris Brezillon
2019-02-21 11:14         ` Boris Brezillon
2019-02-21 11:46         ` Miquel Raynal
2019-02-21 11:46           ` Miquel Raynal
2019-02-21 12:08           ` Boris Brezillon
2019-02-21 12:08             ` Boris Brezillon
2019-02-21 12:52             ` Miquel Raynal
2019-02-21 12:52               ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 03/27] mtd: nand: Introduce the ECC engine abstraction Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 11:16   ` Boris Brezillon
2019-02-21 11:16     ` Boris Brezillon
2019-02-27  9:26     ` Miquel Raynal
2019-02-27  9:26       ` Miquel Raynal
2019-02-27  9:47       ` Boris Brezillon
2019-02-27  9:47         ` Boris Brezillon
2019-02-25 18:55   ` Boris Brezillon
2019-02-25 18:55     ` Boris Brezillon
2019-02-27 13:56     ` Miquel Raynal
2019-02-27 13:56       ` Miquel Raynal
2019-02-27 14:06       ` Boris Brezillon
2019-02-27 14:06         ` Boris Brezillon
2019-02-27 14:19         ` Miquel Raynal
2019-02-27 14:19           ` Miquel Raynal
2019-02-27 14:28           ` Boris Brezillon
2019-02-27 14:28             ` Boris Brezillon
2019-02-27 14:34             ` Miquel Raynal
2019-02-27 14:34               ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 04/27] mtd: Fix typo in mtd_ooblayout_set_databytes() description Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 05/27] mtd: nand: Move standard OOB layouts to the NAND core Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 11:19   ` Boris Brezillon
2019-02-21 11:19     ` Boris Brezillon
2019-02-21 11:47     ` Miquel Raynal
2019-02-21 11:47       ` Miquel Raynal
2019-02-21 12:10       ` Boris Brezillon
2019-02-21 12:10         ` Boris Brezillon
2019-02-21 10:01 ` [RFC PATCH 06/27] mtd: nand: Move ECC specific functions to ecc/engine.c Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 07/27] mtd: nand: ecc: Move BCH code into the ecc/ directory Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 08/27] mtd: nand: ecc: Use SPDX license identifier for the software BCH code Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 11:25   ` Boris Brezillon
2019-02-21 11:25     ` Boris Brezillon
2019-02-21 11:48     ` Miquel Raynal
2019-02-21 11:48       ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 09/27] mtd: nand: ecc: Turn the software BCH implementation generic Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 12:26   ` Boris Brezillon [this message]
2019-02-21 12:26     ` Boris Brezillon
2019-02-21 12:53     ` Miquel Raynal
2019-02-21 12:53       ` Miquel Raynal
2019-02-21 10:01 ` [RFC PATCH 10/27] mtd: rawnand: Get rid of chip->ecc.priv Miquel Raynal
2019-02-21 10:01   ` Miquel Raynal
2019-02-21 13:01   ` Boris Brezillon
2019-02-21 13:01     ` Boris Brezillon
2019-02-21 10:02 ` [RFC PATCH 11/27] mtd: nand: ecc: Move Hamming code into the ecc/ directory Miquel Raynal
2019-02-21 10:02   ` Miquel Raynal
2019-02-21 10:02 ` [RFC PATCH 12/27] mtd: nand: ecc: Use SPDX license identifier for the software Hamming code Miquel Raynal
2019-02-21 10:02   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190221132652.417f0c5d@kernel.org \
    --to=bbrezillon@kernel.org \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.