From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
devicetree@vger.kernel.org
Subject: [1/2] USB: gadget: pxa25x: Add DT bindings
Date: Mon, 25 Feb 2019 15:23:54 -0600 [thread overview]
Message-ID: <20190225212354.GA9627@bogus> (raw)
On Sun, Feb 03, 2019 at 12:59:07AM +0100, Linus Walleij wrote:
> This adds device tree bindings for the PXA25x USB Device
> Controller as found in the PXA25x and the IXP4xx.
>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../devicetree/bindings/usb/pxa25x-udc.txt | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/pxa25x-udc.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/pxa25x-udc.txt b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt
> new file mode 100644
> index 000000000000..bbdbe0df3565
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt
> @@ -0,0 +1,27 @@
> +PXA25x UDC (USB Device Controller)
> +
> +The PXA25x and IXP4xx USB Device Controller is different from the
> +PXA27x UDC described in pxa-usb.txt and is compatible between the
> +Marvell PXA25x and the Intel IXP4xx devices.
> +
> +Required properties:
> + - compatible: Should be one of
> + "marvell,pxa25x-udc"
Look at the 'has_cfr' flag in the driver. You should have 250 and 255
compatible strings to distinguish. That would get rid of the assembly
instruction helping towards building on !ARM.
> + "intel,ixp4xx-udc"
> + for USB controllers used in device mode.
> + - reg: usb device MMIO address space
> + - interrupts: single interrupt generated by the UDC IP
> + - clocks: input clock of the UDC IP (see clock-bindings.txt)
> +
> +Optional properties:
> + - gpios:
> + - gpio activated to control the USB D+ pullup (see gpio.txt)
This really should be part of a connector. Also, the Lubbock board is
different.
> +
> +Example:
> +
> +usb@c800b000 {
> + compatible = "intel,ixp4xx-udc";
> + reg = <0xc800b000 0x1000>;
> + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&pclk 0>;
> +};
> --
> 2.20.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: gadget: pxa25x: Add DT bindings
Date: Mon, 25 Feb 2019 15:23:54 -0600 [thread overview]
Message-ID: <20190225212354.GA9627@bogus> (raw)
In-Reply-To: <20190202235908.30751-1-linus.walleij@linaro.org>
On Sun, Feb 03, 2019 at 12:59:07AM +0100, Linus Walleij wrote:
> This adds device tree bindings for the PXA25x USB Device
> Controller as found in the PXA25x and the IXP4xx.
>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../devicetree/bindings/usb/pxa25x-udc.txt | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/pxa25x-udc.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/pxa25x-udc.txt b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt
> new file mode 100644
> index 000000000000..bbdbe0df3565
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt
> @@ -0,0 +1,27 @@
> +PXA25x UDC (USB Device Controller)
> +
> +The PXA25x and IXP4xx USB Device Controller is different from the
> +PXA27x UDC described in pxa-usb.txt and is compatible between the
> +Marvell PXA25x and the Intel IXP4xx devices.
> +
> +Required properties:
> + - compatible: Should be one of
> + "marvell,pxa25x-udc"
Look at the 'has_cfr' flag in the driver. You should have 250 and 255
compatible strings to distinguish. That would get rid of the assembly
instruction helping towards building on !ARM.
> + "intel,ixp4xx-udc"
> + for USB controllers used in device mode.
> + - reg: usb device MMIO address space
> + - interrupts: single interrupt generated by the UDC IP
> + - clocks: input clock of the UDC IP (see clock-bindings.txt)
> +
> +Optional properties:
> + - gpios:
> + - gpio activated to control the USB D+ pullup (see gpio.txt)
This really should be part of a connector. Also, the Lubbock board is
different.
> +
> +Example:
> +
> +usb@c800b000 {
> + compatible = "intel,ixp4xx-udc";
> + reg = <0xc800b000 0x1000>;
> + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&pclk 0>;
> +};
> --
> 2.20.1
>
next reply other threads:[~2019-02-25 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 21:23 Rob Herring [this message]
2019-02-25 21:23 ` [PATCH 1/2] USB: gadget: pxa25x: Add DT bindings Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-02-02 23:59 [1/2] " Linus Walleij
2019-02-02 23:59 ` [PATCH 1/2] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225212354.GA9627@bogus \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.