[PATCH v3] Staging: vt6655: Alignment of static function declaration

[PATCH v3] Staging: vt6655: Alignment of static function declaration

[Madhumitha Prabakaran]

Align function arguments and function return type to improve
readability.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
Changes in v3
- Included driver name in subject line.

Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 229137f29690..8d0182f5725c 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
 
 static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
 				       unsigned char *pbyTxRate,
-				       unsigned char *pbyRsvTime)
+				       unsigned char *pbyRsvTime);
 
 /*---------------------  Export Functions  --------------------------*/
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of static function declaration

[Greg KH]

On Wed, Feb 27, 2019 at 10:01:48AM -0600, Madhumitha Prabakaran wrote:
> Align function arguments and function return type to improve
> readability.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> Changes in v3
> - Included driver name in subject line.
> 
> Changes in v2
> - Improved alignment of function declaration
> - Modified subject line and commit log
> ---
>  drivers/staging/vt6655/card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 229137f29690..8d0182f5725c 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
>  
>  static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
>  				       unsigned char *pbyTxRate,
> -				       unsigned char *pbyRsvTime)
> +				       unsigned char *pbyRsvTime);

The patch does not do what your changelog text says it is doing :(

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of static function declaration

[Madhumthia Prabakaran]

On Wed, Feb 27, 2019 at 05:28:34PM +0100, Greg KH wrote:
> On Wed, Feb 27, 2019 at 10:01:48AM -0600, Madhumitha Prabakaran wrote:
> > Align function arguments and function return type to improve
> > readability.
> > 
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> > Changes in v3
> > - Included driver name in subject line.
> > 
> > Changes in v2
> > - Improved alignment of function declaration
> > - Modified subject line and commit log
> > ---
> >  drivers/staging/vt6655/card.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > index 229137f29690..8d0182f5725c 100644
> > --- a/drivers/staging/vt6655/card.c
> > +++ b/drivers/staging/vt6655/card.c
> > @@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> >  
> >  static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
> >  				       unsigned char *pbyTxRate,
> > -				       unsigned char *pbyRsvTime)
> > +				       unsigned char *pbyRsvTime);
> 
> The patch does not do what your changelog text says it is doing :(

I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of static function declaration

[Greg KH]

On Wed, Feb 27, 2019 at 10:39:52AM -0600, Madhumthia Prabakaran wrote:
> On Wed, Feb 27, 2019 at 05:28:34PM +0100, Greg KH wrote:
> > On Wed, Feb 27, 2019 at 10:01:48AM -0600, Madhumitha Prabakaran wrote:
> > > Align function arguments and function return type to improve
> > > readability.
> > > 
> > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > > ---
> > > Changes in v3
> > > - Included driver name in subject line.
> > > 
> > > Changes in v2
> > > - Improved alignment of function declaration
> > > - Modified subject line and commit log
> > > ---
> > >  drivers/staging/vt6655/card.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > > index 229137f29690..8d0182f5725c 100644
> > > --- a/drivers/staging/vt6655/card.c
> > > +++ b/drivers/staging/vt6655/card.c
> > > @@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> > >  
> > >  static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
> > >  				       unsigned char *pbyTxRate,
> > > -				       unsigned char *pbyRsvTime)
> > > +				       unsigned char *pbyRsvTime);
> > 
> > The patch does not do what your changelog text says it is doing :(
> 
> I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong

I have no idea what you did here, but the diff here is not doing what
your changelog says it is doing.  So something got out of sync.

greg k-h

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of static function declaration

[Madhumthia Prabakaran]

On Wed, Feb 27, 2019 at 05:42:40PM +0100, Greg KH wrote:
> On Wed, Feb 27, 2019 at 10:39:52AM -0600, Madhumthia Prabakaran wrote:
> > On Wed, Feb 27, 2019 at 05:28:34PM +0100, Greg KH wrote:
> > > On Wed, Feb 27, 2019 at 10:01:48AM -0600, Madhumitha Prabakaran wrote:
> > > > Align function arguments and function return type to improve
> > > > readability.
> > > > 
> > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > > > ---
> > > > Changes in v3
> > > > - Included driver name in subject line.
> > > > 
> > > > Changes in v2
> > > > - Improved alignment of function declaration
> > > > - Modified subject line and commit log
> > > > ---
> > > >  drivers/staging/vt6655/card.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > > > index 229137f29690..8d0182f5725c 100644
> > > > --- a/drivers/staging/vt6655/card.c
> > > > +++ b/drivers/staging/vt6655/card.c
> > > > @@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> > > >  
> > > >  static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
> > > >  				       unsigned char *pbyTxRate,
> > > > -				       unsigned char *pbyRsvTime)
> > > > +				       unsigned char *pbyRsvTime);
> > > 
> > > The patch does not do what your changelog text says it is doing :(
> > 
> > I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong
> 
> I have no idea what you did here, but the diff here is not doing what
> your changelog says it is doing.  So something got out of sync.
> 
> greg k-h

I will fix it and update it. Thanks

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of static function declaration

[Julia Lawall]

On Wed, 27 Feb 2019, Madhumthia Prabakaran wrote:

> On Wed, Feb 27, 2019 at 05:28:34PM +0100, Greg KH wrote:
> > On Wed, Feb 27, 2019 at 10:01:48AM -0600, Madhumitha Prabakaran wrote:
> > > Align function arguments and function return type to improve
> > > readability.
> > >
> > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > > ---
> > > Changes in v3
> > > - Included driver name in subject line.
> > >
> > > Changes in v2
> > > - Improved alignment of function declaration
> > > - Modified subject line and commit log
> > > ---
> > >  drivers/staging/vt6655/card.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > > index 229137f29690..8d0182f5725c 100644
> > > --- a/drivers/staging/vt6655/card.c
> > > +++ b/drivers/staging/vt6655/card.c
> > > @@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> > >
> > >  static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
> > >  				       unsigned char *pbyTxRate,
> > > -				       unsigned char *pbyRsvTime)
> > > +				       unsigned char *pbyRsvTime);
> >
> > The patch does not do what your changelog text says it is doing :(
>
> I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong

The issue is that the effect of your patch is to add a semicolon.  But I
suspect that the semicolon was there in the original code.  You removed it
at some point, and then added it back.

julia

>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227163950.GA22354%40madhuleo.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of static function declaration

[Madhumthia Prabakaran]

On Wed, Feb 27, 2019 at 08:45:26PM +0100, Julia Lawall wrote:
> 
> 
> On Wed, 27 Feb 2019, Madhumthia Prabakaran wrote:
> 
> > On Wed, Feb 27, 2019 at 05:28:34PM +0100, Greg KH wrote:
> > > On Wed, Feb 27, 2019 at 10:01:48AM -0600, Madhumitha Prabakaran wrote:
> > > > Align function arguments and function return type to improve
> > > > readability.
> > > >
> > > > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > > > ---
> > > > Changes in v3
> > > > - Included driver name in subject line.
> > > >
> > > > Changes in v2
> > > > - Improved alignment of function declaration
> > > > - Modified subject line and commit log
> > > > ---
> > > >  drivers/staging/vt6655/card.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > > > index 229137f29690..8d0182f5725c 100644
> > > > --- a/drivers/staging/vt6655/card.c
> > > > +++ b/drivers/staging/vt6655/card.c
> > > > @@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> > > >
> > > >  static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
> > > >  				       unsigned char *pbyTxRate,
> > > > -				       unsigned char *pbyRsvTime)
> > > > +				       unsigned char *pbyRsvTime);
> > >
> > > The patch does not do what your changelog text says it is doing :(
> >
> > I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong
> 
> The issue is that the effect of your patch is to add a semicolon.  But I
> suspect that the semicolon was there in the original code.  You removed it
> at some point, and then added it back.
> 
> julia
> 
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227163950.GA22354%40madhuleo.
> > For more options, visit https://groups.google.com/d/optout.
> >


Instead of reviewing and rebasing a patch, I used a wrong technique to commit it. I will fix and resend it.

Thanks,
Madhumitha