[PATCH] Staging: pi433: Fix line over 80 characters issue

[PATCH] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

Delete extra whitespace and tab space to remove
checkpatch.pl warning:
WARNING: line over 80 characters

Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
 drivers/staging/pi433/pi433_if.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b231463..53928af 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -45,10 +45,10 @@
 #include "pi433_if.h"
 #include "rf69.h"
 
-#define N_PI433_MINORS			BIT(MINORBITS) /*32*/	/* ... up to 256 */
-#define MAX_MSG_SIZE			900	/* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE			65536   /* 65536 = 2^16  */
-#define NUM_DIO				2
+#define N_PI433_MINORS		BIT(MINORBITS) /*32*/	/* ... up to 256 */
+#define MAX_MSG_SIZE		900	/* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE		65536   /* 65536 = 2^16  */
+#define NUM_DIO			2
 
 static dev_t pi433_dev;
 static DEFINE_IDR(pi433_idr);
-- 
2.7.4

Re: [PATCH] Staging: pi433: Fix line over 80 characters issue

[Greg KH]

On Sun, Mar 03, 2019 at 10:05:30PM -0800, Debleena Sen wrote:
> Delete extra whitespace and tab space to remove
> checkpatch.pl warning:
> WARNING: line over 80 characters
> 
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index b231463..53928af 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -45,10 +45,10 @@
>  #include "pi433_if.h"
>  #include "rf69.h"
>  
> -#define N_PI433_MINORS			BIT(MINORBITS) /*32*/	/* ... up to 256 */
> -#define MAX_MSG_SIZE			900	/* min: FIFO_SIZE! */
> -#define MSG_FIFO_SIZE			65536   /* 65536 = 2^16  */
> -#define NUM_DIO				2
> +#define N_PI433_MINORS		BIT(MINORBITS) /*32*/	/* ... up to 256 */
> +#define MAX_MSG_SIZE		900	/* min: FIFO_SIZE! */
> +#define MSG_FIFO_SIZE		65536   /* 65536 = 2^16  */

The comment above should also use a tab, right?

thanks,

greg k-h

Re: [PATCH] Staging: pi433: Fix line over 80 characters issue

[idebleenasen]

[-- Attachment #1.1: Type: text/plain, Size: 1417 bytes --]

On Monday, March 4, 2019 at 1:16:54 PM UTC+5:30, gregkh wrote:
>
> On Sun, Mar 03, 2019 at 10:05:30PM -0800, Debleena Sen wrote: 
> > Delete extra whitespace and tab space to remove 
> > checkpatch.pl warning: 
> > WARNING: line over 80 characters 
> > 
> > Signed-off-by: Debleena Sen <ideble...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/pi433/pi433_if.c | 8 ++++---- 
> >  1 file changed, 4 insertions(+), 4 deletions(-) 
> > 
> > diff --git a/drivers/staging/pi433/pi433_if.c 
> b/drivers/staging/pi433/pi433_if.c 
> > index b231463..53928af 100644 
> > --- a/drivers/staging/pi433/pi433_if.c 
> > +++ b/drivers/staging/pi433/pi433_if.c 
> > @@ -45,10 +45,10 @@ 
> >  #include "pi433_if.h" 
> >  #include "rf69.h" 
> >   
> > -#define N_PI433_MINORS                        BIT(MINORBITS) 
> /*32*/        /* ... up to 256 */ 
> > -#define MAX_MSG_SIZE                        900        /* min: 
> FIFO_SIZE! */ 
> > -#define MSG_FIFO_SIZE                        65536   /* 65536 = 2^16 
>  */ 
> > -#define NUM_DIO                                2 
> > +#define N_PI433_MINORS                BIT(MINORBITS) /*32*/        /* 
> ... up to 256 */ 
> > +#define MAX_MSG_SIZE                900        /* min: FIFO_SIZE! */ 
> > +#define MSG_FIFO_SIZE                65536   /* 65536 = 2^16  */ 
>
> The comment above should also use a tab, right? 
>
> thanks, 
>
> greg k-h 
>

Yes. Should I resend it ?

[-- Attachment #1.2: Type: text/html, Size: 2596 bytes --]

[PATCH] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

Break the lines after '&' and match the alignment with '(' to remove the
checkpatch.pl warning. Remove whitespace after '&' if any.

Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
 drivers/staging/pi433/rf69.c | 48 +++++++++++++++++++++++++++++---------------
 1 file changed, 32 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 0c189a7..815fc9f 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -566,39 +566,55 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
 		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
 			MASK_IRQFLAGS1_MODE_READY);
 	case ready_to_receive:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RX_READY);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_RX_READY);
 	case ready_to_send:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_TX_READY);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_TX_READY);
 	case pll_locked:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_PLL_LOCK);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_PLL_LOCK);
 	case rssi_exceeded_threshold:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RSSI);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_RSSI);
 	case timeout:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_TIMEOUT);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_TIMEOUT);
 	case automode:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_AUTOMODE);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_AUTOMODE);
 	case sync_address_match:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_SYNC_ADDRESS_MATCH);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_SYNC_ADDRESS_MATCH);
 	case fifo_full:
-		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
+		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_FIFO_FULL);
 /*
  *	case fifo_not_empty:
- *		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
+ *		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+ *			MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
  */
 	case fifo_empty:
-		return !(rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
+		return !(rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
 	case fifo_level_below_threshold:
-		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_LEVEL);
+		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_FIFO_LEVEL);
 	case fifo_overrun:
-		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_OVERRUN);
+		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_FIFO_OVERRUN);
 	case packet_sent:
-		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_PACKET_SENT);
+		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_PACKET_SENT);
 	case payload_ready:
-		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_PAYLOAD_READY);
+		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_PAYLOAD_READY);
 	case crc_ok:
-		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_CRC_OK);
+		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_CRC_OK);
 	case battery_low:
-		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_LOW_BAT);
+		return (rf69_read_reg(spi, REG_IRQFLAGS2) &
+			MASK_IRQFLAGS2_LOW_BAT);
 	default:			 return false;
 	}
 }
-- 
2.7.4

Re: [PATCH] Staging: pi433: Fix line over 80 characters issue

[Greg KH]

On Tue, Mar 05, 2019 at 09:13:06AM -0800, Debleena Sen wrote:
> Break the lines after '&' and match the alignment with '(' to remove the
> checkpatch.pl warning. Remove whitespace after '&' if any.
> 
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>

This has the same subject line as your previous patch, yet does
different things :(

Please resend them all, as a patch series, with unique subject lines.

thanks,

greg k-h

Re: [PATCH] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

On Wed, Mar 6, 2019 at 3:14 PM Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Mar 06, 2019 at 02:54:44PM +0530, Debleena Sen wrote:
>
> <snip>
>
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list.  I'll be glad to respond if you
> resend it to everyone.
>
> thanks,
>
> greg k-h
>

Sorry didn't notice

[-- Attachment #2: Type: text/html, Size: 699 bytes --]

Fwd: [PATCH] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

---------- Forwarded message ---------
From: Debleena Sen <idebleenasen@gmail.com>
Date: Wed, Mar 6, 2019 at 2:54 PM
Subject: Re: [PATCH] Staging: pi433: Fix line over 80 characters issue
To: Greg KH <gregkh@linuxfoundation.org>


On Wed, Mar 6, 2019 at 2:45 PM Greg KH <gregkh@linuxfoundation.org> wrote:

> On Tue, Mar 05, 2019 at 09:13:06AM -0800, Debleena Sen wrote:
> > Break the lines after '&' and match the alignment with '(' to remove the
> > checkpatch.pl warning. Remove whitespace after '&' if any.
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
>
> This has the same subject line as your previous patch, yet does
> different things :(
>
> Please resend them all, as a patch series, with unique subject lines.
>
> thanks,
>
> greg k-h
>

Actually in pi433/rf69.c there were like 16 warnings of the same type. In
my previous patch I had fixed only one warning. In this patch, I fixed all
of them. They have the same styling issue and I did the same thing on all
the lines. So I thought to put the same subject because essentially all of
them are same.

Debleena

[-- Attachment #2: Type: text/html, Size: 1940 bytes --]

Re: [Outreachy kernel] Fwd: [PATCH] Staging: pi433: Fix line over 80 characters issue

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]



On Wed, 6 Mar 2019, Debleena Sen wrote:

>
>
> ---------- Forwarded message ---------
> From: Debleena Sen <idebleenasen@gmail.com>
> Date: Wed, Mar 6, 2019 at 2:54 PM
> Subject: Re: [PATCH] Staging: pi433: Fix line over 80 characters issue
> To: Greg KH <gregkh@linuxfoundation.org>
>
>
> On Wed, Mar 6, 2019 at 2:45 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>       On Tue, Mar 05, 2019 at 09:13:06AM -0800, Debleena Sen wrote:
>       > Break the lines after '&' and match the alignment with '(' to
>       remove the
>       > checkpatch.pl warning. Remove whitespace after '&' if any.
>       >
>       > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
>
>       This has the same subject line as your previous patch, yet does
>       different things :(
>
>       Please resend them all, as a patch series, with unique subject
>       lines.
>
>       thanks,
>
>       greg k-h
>
> ￜ
> Actually in pi433/rf69.c there were like 16 warnings of the same type. In my
> previous patch I had fixed only one warning. In this patch, I fixed all of
> them. They have the same styling issue and I did the same thing on all the
> lines. So I thought to put the same subject because essentially all of them
> are same.

Every patch in the Linux kernel needs a different subject.

julia

>
> Debleenaￜ
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CACw%2Bu4FaS0PDoxh2urUrq
> gBfRJWD7qY7xchgVEaKLZ06PD6a%2BA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>