* [PATCH 1/2] drm/i915: Sort ICL PCI IDs
@ 2019-03-07 20:56 José Roberto de Souza
2019-03-07 20:56 ` [PATCH 2/2] drm/i915: Add new ICL PCI ID José Roberto de Souza
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: José Roberto de Souza @ 2019-03-07 20:56 UTC (permalink / raw)
To: intel-gfx
Lets keep it sorted to make easy to spot missing PCI IDs.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
include/drm/i915_pciids.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index d2fad7b0fcf6..be735811591d 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -459,16 +459,16 @@
#define INTEL_ICL_11_IDS(info) \
INTEL_VGA_DEVICE(0x8A50, info), \
INTEL_VGA_DEVICE(0x8A51, info), \
- INTEL_VGA_DEVICE(0x8A5C, info), \
- INTEL_VGA_DEVICE(0x8A5D, info), \
- INTEL_VGA_DEVICE(0x8A59, info), \
- INTEL_VGA_DEVICE(0x8A58, info), \
INTEL_VGA_DEVICE(0x8A52, info), \
+ INTEL_VGA_DEVICE(0x8A56, info), \
+ INTEL_VGA_DEVICE(0x8A57, info), \
+ INTEL_VGA_DEVICE(0x8A58, info), \
+ INTEL_VGA_DEVICE(0x8A59, info), \
INTEL_VGA_DEVICE(0x8A5A, info), \
INTEL_VGA_DEVICE(0x8A5B, info), \
- INTEL_VGA_DEVICE(0x8A57, info), \
- INTEL_VGA_DEVICE(0x8A56, info), \
- INTEL_VGA_DEVICE(0x8A71, info), \
- INTEL_VGA_DEVICE(0x8A70, info)
+ INTEL_VGA_DEVICE(0x8A5C, info), \
+ INTEL_VGA_DEVICE(0x8A5D, info), \
+ INTEL_VGA_DEVICE(0x8A70, info), \
+ INTEL_VGA_DEVICE(0x8A71, info)
#endif /* _I915_PCIIDS_H */
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] drm/i915: Add new ICL PCI ID
2019-03-07 20:56 [PATCH 1/2] drm/i915: Sort ICL PCI IDs José Roberto de Souza
@ 2019-03-07 20:56 ` José Roberto de Souza
2019-03-08 21:23 ` Rodrigo Vivi
2019-03-07 21:48 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Sort ICL PCI IDs Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: José Roberto de Souza @ 2019-03-07 20:56 UTC (permalink / raw)
To: intel-gfx
A new PCI ID for ICL was added to BSpec, lets keep it in tight sync
as ICL is not protected by the alpha support flag anymore.
BSepc: 21141
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
include/drm/i915_pciids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index be735811591d..6a287f0b3c6d 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -460,6 +460,7 @@
INTEL_VGA_DEVICE(0x8A50, info), \
INTEL_VGA_DEVICE(0x8A51, info), \
INTEL_VGA_DEVICE(0x8A52, info), \
+ INTEL_VGA_DEVICE(0x8A53, info), \
INTEL_VGA_DEVICE(0x8A56, info), \
INTEL_VGA_DEVICE(0x8A57, info), \
INTEL_VGA_DEVICE(0x8A58, info), \
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] drm/i915: Add new ICL PCI ID
2019-03-07 20:56 ` [PATCH 2/2] drm/i915: Add new ICL PCI ID José Roberto de Souza
@ 2019-03-08 21:23 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2019-03-08 21:23 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Thu, Mar 07, 2019 at 12:56:56PM -0800, José Roberto de Souza wrote:
> A new PCI ID for ICL was added to BSpec, lets keep it in tight sync
> as ICL is not protected by the alpha support flag anymore.
>
> BSepc: 21141
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> include/drm/i915_pciids.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index be735811591d..6a287f0b3c6d 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -460,6 +460,7 @@
> INTEL_VGA_DEVICE(0x8A50, info), \
> INTEL_VGA_DEVICE(0x8A51, info), \
> INTEL_VGA_DEVICE(0x8A52, info), \
> + INTEL_VGA_DEVICE(0x8A53, info), \
With this as the last item of the current list feel free to use:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> INTEL_VGA_DEVICE(0x8A56, info), \
> INTEL_VGA_DEVICE(0x8A57, info), \
> INTEL_VGA_DEVICE(0x8A58, info), \
> --
> 2.21.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Sort ICL PCI IDs
2019-03-07 20:56 [PATCH 1/2] drm/i915: Sort ICL PCI IDs José Roberto de Souza
2019-03-07 20:56 ` [PATCH 2/2] drm/i915: Add new ICL PCI ID José Roberto de Souza
@ 2019-03-07 21:48 ` Patchwork
2019-03-07 23:58 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-08 21:17 ` [PATCH 1/2] " Rodrigo Vivi
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-03-07 21:48 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Sort ICL PCI IDs
URL : https://patchwork.freedesktop.org/series/57707/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5716 -> Patchwork_12410
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57707/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12410 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7560u: PASS -> INCOMPLETE [fdo#109831]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@basic-rte:
- fi-bsw-kefka: PASS -> FAIL [fdo#108800]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +3
#### Possible fixes ####
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: DMESG-WARN [fdo#107709] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: DMESG-FAIL [fdo#103182] -> PASS
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109831]: https://bugs.freedesktop.org/show_bug.cgi?id=109831
Participating hosts (46 -> 40)
------------------------------
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* Linux: CI_DRM_5716 -> Patchwork_12410
CI_DRM_5716: 93fc972e0143fb8c46c73c55b732e30eae9ecd83 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12410: 575d76b831005fbc0608975062cb927fab5f3a77 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
575d76b83100 drm/i915: Add new ICL PCI ID
f340793fef56 drm/i915: Sort ICL PCI IDs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12410/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Sort ICL PCI IDs
2019-03-07 20:56 [PATCH 1/2] drm/i915: Sort ICL PCI IDs José Roberto de Souza
2019-03-07 20:56 ` [PATCH 2/2] drm/i915: Add new ICL PCI ID José Roberto de Souza
2019-03-07 21:48 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Sort ICL PCI IDs Patchwork
@ 2019-03-07 23:58 ` Patchwork
2019-03-08 21:17 ` [PATCH 1/2] " Rodrigo Vivi
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-03-07 23:58 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Sort ICL PCI IDs
URL : https://patchwork.freedesktop.org/series/57707/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5716_full -> Patchwork_12410_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12410_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_big:
- shard-hsw: PASS -> TIMEOUT [fdo#107937]
* igt@gem_pread@stolen-normal:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +83
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-apl: PASS -> FAIL [fdo#109660]
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-oldfb-render-f:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_color@pipe-c-legacy-gamma:
- shard-glk: PASS -> FAIL [fdo#104782]
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> FAIL [fdo#108597] / [fdo#108739]
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-skl: PASS -> FAIL [fdo#103184]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +34
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-blt:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +8
* igt@kms_panel_fitting@legacy:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +34
- shard-skl: NOTRUN -> FAIL [fdo#105456]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_vblank@pipe-c-ts-continuation-modeset:
- shard-kbl: NOTRUN -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP [fdo#109271] -> PASS
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: FAIL [fdo#109660] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-128x42-offscreen:
- shard-skl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +5
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled:
- shard-skl: FAIL [fdo#103184] -> PASS +1
* igt@kms_flip_tiling@flip-changes-tiling:
- shard-skl: FAIL [fdo#108303] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +3
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: INCOMPLETE [fdo#104108] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
- shard-apl: FAIL [fdo#104894] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-hsw: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-skl: SKIP [fdo#109271] -> INCOMPLETE [fdo#107807]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105456]: https://bugs.freedesktop.org/show_bug.cgi?id=105456
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107937]: https://bugs.freedesktop.org/show_bug.cgi?id=107937
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (6 -> 6)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5716 -> Patchwork_12410
CI_DRM_5716: 93fc972e0143fb8c46c73c55b732e30eae9ecd83 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12410: 575d76b831005fbc0608975062cb927fab5f3a77 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12410/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] drm/i915: Sort ICL PCI IDs
2019-03-07 20:56 [PATCH 1/2] drm/i915: Sort ICL PCI IDs José Roberto de Souza
` (2 preceding siblings ...)
2019-03-07 23:58 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-08 21:17 ` Rodrigo Vivi
2019-03-08 21:41 ` Souza, Jose
3 siblings, 1 reply; 7+ messages in thread
From: Rodrigo Vivi @ 2019-03-08 21:17 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Thu, Mar 07, 2019 at 12:56:55PM -0800, José Roberto de Souza wrote:
> Lets keep it sorted to make easy to spot missing PCI IDs.
Hmm... In my opinion leaving it as the identical order
of the spec is the way to make it easier to spot if we missed
something...
Otherwise when reviewing I have to stop and sort one or another.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> include/drm/i915_pciids.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index d2fad7b0fcf6..be735811591d 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -459,16 +459,16 @@
> #define INTEL_ICL_11_IDS(info) \
> INTEL_VGA_DEVICE(0x8A50, info), \
> INTEL_VGA_DEVICE(0x8A51, info), \
> - INTEL_VGA_DEVICE(0x8A5C, info), \
> - INTEL_VGA_DEVICE(0x8A5D, info), \
> - INTEL_VGA_DEVICE(0x8A59, info), \
> - INTEL_VGA_DEVICE(0x8A58, info), \
> INTEL_VGA_DEVICE(0x8A52, info), \
> + INTEL_VGA_DEVICE(0x8A56, info), \
> + INTEL_VGA_DEVICE(0x8A57, info), \
> + INTEL_VGA_DEVICE(0x8A58, info), \
> + INTEL_VGA_DEVICE(0x8A59, info), \
> INTEL_VGA_DEVICE(0x8A5A, info), \
> INTEL_VGA_DEVICE(0x8A5B, info), \
> - INTEL_VGA_DEVICE(0x8A57, info), \
> - INTEL_VGA_DEVICE(0x8A56, info), \
> - INTEL_VGA_DEVICE(0x8A71, info), \
> - INTEL_VGA_DEVICE(0x8A70, info)
> + INTEL_VGA_DEVICE(0x8A5C, info), \
> + INTEL_VGA_DEVICE(0x8A5D, info), \
> + INTEL_VGA_DEVICE(0x8A70, info), \
> + INTEL_VGA_DEVICE(0x8A71, info)
>
> #endif /* _I915_PCIIDS_H */
> --
> 2.21.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] drm/i915: Sort ICL PCI IDs
2019-03-08 21:17 ` [PATCH 1/2] " Rodrigo Vivi
@ 2019-03-08 21:41 ` Souza, Jose
0 siblings, 0 replies; 7+ messages in thread
From: Souza, Jose @ 2019-03-08 21:41 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: intel-gfx@lists.freedesktop.org
[-- Attachment #1.1: Type: text/plain, Size: 1920 bytes --]
On Fri, 2019-03-08 at 13:17 -0800, Rodrigo Vivi wrote:
> On Thu, Mar 07, 2019 at 12:56:55PM -0800, José Roberto de Souza
> wrote:
> > Lets keep it sorted to make easy to spot missing PCI IDs.
>
> Hmm... In my opinion leaving it as the identical order
> of the spec is the way to make it easier to spot if we missed
> something...
>
> Otherwise when reviewing I have to stop and sort one or another.
Oh it is following the order of the second table, okay makes sense keep
this way.
>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > include/drm/i915_pciids.h | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index d2fad7b0fcf6..be735811591d 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -459,16 +459,16 @@
> > #define INTEL_ICL_11_IDS(info) \
> > INTEL_VGA_DEVICE(0x8A50, info), \
> > INTEL_VGA_DEVICE(0x8A51, info), \
> > - INTEL_VGA_DEVICE(0x8A5C, info), \
> > - INTEL_VGA_DEVICE(0x8A5D, info), \
> > - INTEL_VGA_DEVICE(0x8A59, info), \
> > - INTEL_VGA_DEVICE(0x8A58, info), \
> > INTEL_VGA_DEVICE(0x8A52, info), \
> > + INTEL_VGA_DEVICE(0x8A56, info), \
> > + INTEL_VGA_DEVICE(0x8A57, info), \
> > + INTEL_VGA_DEVICE(0x8A58, info), \
> > + INTEL_VGA_DEVICE(0x8A59, info), \
> > INTEL_VGA_DEVICE(0x8A5A, info), \
> > INTEL_VGA_DEVICE(0x8A5B, info), \
> > - INTEL_VGA_DEVICE(0x8A57, info), \
> > - INTEL_VGA_DEVICE(0x8A56, info), \
> > - INTEL_VGA_DEVICE(0x8A71, info), \
> > - INTEL_VGA_DEVICE(0x8A70, info)
> > + INTEL_VGA_DEVICE(0x8A5C, info), \
> > + INTEL_VGA_DEVICE(0x8A5D, info), \
> > + INTEL_VGA_DEVICE(0x8A70, info), \
> > + INTEL_VGA_DEVICE(0x8A71, info)
> >
> > #endif /* _I915_PCIIDS_H */
> > --
> > 2.21.0
> >
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-08 21:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07 20:56 [PATCH 1/2] drm/i915: Sort ICL PCI IDs José Roberto de Souza
2019-03-07 20:56 ` [PATCH 2/2] drm/i915: Add new ICL PCI ID José Roberto de Souza
2019-03-08 21:23 ` Rodrigo Vivi
2019-03-07 21:48 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Sort ICL PCI IDs Patchwork
2019-03-07 23:58 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-08 21:17 ` [PATCH 1/2] " Rodrigo Vivi
2019-03-08 21:41 ` Souza, Jose
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.